From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F365DC0502A for ; Tue, 30 Aug 2022 10:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63376940007; Tue, 30 Aug 2022 06:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E20B6B0074; Tue, 30 Aug 2022 06:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A9DA940007; Tue, 30 Aug 2022 06:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3BE726B0073 for ; Tue, 30 Aug 2022 06:48:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 17DD780488 for ; Tue, 30 Aug 2022 10:48:52 +0000 (UTC) X-FDA: 79855936104.07.59CD5AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 3E354A0013 for ; Tue, 30 Aug 2022 10:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661856530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sz4srs09/QpWeixG0gmN9bILh9AJeJA7X0RTBdy8P7Y=; b=Xkf1tVKmIm8UhF3D4Ar+/8BYk9KLSaK9mc+rtxHkFEytOoBd6c8Kno6BKuotXaN1P3ofe9 C48dGI4FOLVfRkN+IF3pmb/5uv9qIeyP8W1V8yQ+stpR/aDzIO1jvoFgYMOT/ntj4UV7bp zd49P6IOHIU11av99skudlnAs6PmjUc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-539-xY3cDnuMOj2ZDNfztho8QA-1; Tue, 30 Aug 2022 06:48:47 -0400 X-MC-Unique: xY3cDnuMOj2ZDNfztho8QA-1 Received: by mail-wr1-f71.google.com with SMTP id e13-20020adfa44d000000b002260797ca0cso1662305wra.20 for ; Tue, 30 Aug 2022 03:48:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=Sz4srs09/QpWeixG0gmN9bILh9AJeJA7X0RTBdy8P7Y=; b=jnCdTVN8IChaLqEx2ahnk8Qoxs2VmMZQnnNWyTiEani8YwPWCSUtlWiupsL4hHDOc/ zbBVWzEDe45k/1cpwkHHtFPfLX73h0cdmBZPGLV0lQhIf7YXgOMif+Apum9cyh7K0B/M SSP/dsBm0sugLNvFHnyLVVDYyQwUTJEtYl9rKW5uyzUZp+xNkx/BVYuSJZcth8dJof3t g5Poi3BVO5JsEpG7Dl1oqfob+inIz4HTir2kn0qpDsDyD2QJpUiqePfRkJsjr55vMug9 uSAwtfUb+vUau53BKjL3AJmYUUwcEf2SKV+Mx+9AzI/PoNQgHqou3cu5apL46HrZCuHf Y5mg== X-Gm-Message-State: ACgBeo3e7SZO0XoBdU5dLS1GkbnGAUgisvj13KwDfXssAgIiVGBpfoRQ 2770Tp3PE5ALOu0X93B+R6Q8l5MZdsMxf9a2OxkiA6hVDz3D2rXpS3XSlBKqQmN1kzj8rsg8pwK s6XZCW/Gc57g= X-Received: by 2002:a5d:5e89:0:b0:226:d149:25e3 with SMTP id ck9-20020a5d5e89000000b00226d14925e3mr8696816wrb.597.1661856526034; Tue, 30 Aug 2022 03:48:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR5K0SsZxQvvhMWnX/ASH1Felv6+t/7b/gE74TKt0G5s+NX3VFZ2KHV3NfUz8w/YGJYCKedISQ== X-Received: by 2002:a5d:5e89:0:b0:226:d149:25e3 with SMTP id ck9-20020a5d5e89000000b00226d14925e3mr8696804wrb.597.1661856525804; Tue, 30 Aug 2022 03:48:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:1000:ecb4:919b:e3d3:e20b? (p200300cbc70a1000ecb4919be3d3e20b.dip0.t-ipconnect.de. [2003:cb:c70a:1000:ecb4:919b:e3d3:e20b]) by smtp.gmail.com with ESMTPSA id f13-20020a05600c154d00b003a8434530bbsm9301002wmg.13.2022.08.30.03.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 03:48:45 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 12:48:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] mm: kill is_memblock_offlined() To: Kefeng Wang , Oscar Salvador , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220827112043.187028-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220827112043.187028-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661856531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sz4srs09/QpWeixG0gmN9bILh9AJeJA7X0RTBdy8P7Y=; b=i1UqzCtJ+vQKT0sQRm0tOZ9PlKFSrJWCXQrdrG0x0v9C80Q1pfh071Pd2zR/VugWMW9V5+ DCszGGdgY/LgI3uHZAhL1gqAVYxLrx+oSG0lpAOVKyNPnHW21eJbqvgpIZVIGddw2z6PPl i07NTL/Yl+XCM7mV1iUU8jTiHx0fYPU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xkf1tVKm; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661856531; a=rsa-sha256; cv=none; b=S3vrHW8lyy/h7Y2ei1rRqL8wNzVv+d8mGgjabIzDYkspeDdvH1y8BzD/Tai9kwUh8rZm1g HCSzBnmyXC9ihk7ffUCYHZVjxRxDewAnxzWLNhWhl9A8OHFbnYQ+y3FSw/M+TJE3AGlJlL b6UYT7hwKb+uggy1SfY73MD9u1GtZ6w= X-Stat-Signature: a5h5rwfxrgd3xfhu9yf87j1fum9eqtxf X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3E354A0013 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xkf1tVKm; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1661856531-372197 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.08.22 13:20, Kefeng Wang wrote: > Directly check state of struct memory_block, no need a single function. > > Signed-off-by: Kefeng Wang > --- > drivers/base/memory.c | 6 ------ > include/linux/memory_hotplug.h | 2 -- > mm/memory_hotplug.c | 3 +-- > 3 files changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index bc60c9cd3230..9aa0da991cfb 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -869,12 +869,6 @@ void remove_memory_block_devices(unsigned long start, unsigned long size) > } > } > > -/* return true if the memory block is offlined, otherwise, return false */ > -bool is_memblock_offlined(struct memory_block *mem) > -{ > - return mem->state == MEM_OFFLINE; > -} > - > static struct attribute *memory_root_attrs[] = { > #ifdef CONFIG_ARCH_MEMORY_PROBE > &dev_attr_probe.attr, > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 409196ef8038..de87545eabe9 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -11,7 +11,6 @@ struct page; > struct zone; > struct pglist_data; > struct mem_section; > -struct memory_block; > struct memory_group; > struct resource; > struct vmem_altmap; > @@ -352,7 +351,6 @@ extern void move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn, > extern void remove_pfn_range_from_zone(struct zone *zone, > unsigned long start_pfn, > unsigned long nr_pages); > -extern bool is_memblock_offlined(struct memory_block *mem); > extern int sparse_add_section(int nid, unsigned long pfn, > unsigned long nr_pages, struct vmem_altmap *altmap, > struct dev_pagemap *pgmap); > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 2fd45ccbce45..9ae1f98548b1 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1969,11 +1969,10 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > > static int check_memblock_offlined_cb(struct memory_block *mem, void *arg) > { > - int ret = !is_memblock_offlined(mem); > int *nid = arg; > > *nid = mem->nid; > - if (unlikely(ret)) { > + if (unlikely(mem->state != MEM_OFFLINE)) { > phys_addr_t beginpa, endpa; > > beginpa = PFN_PHYS(section_nr_to_pfn(mem->start_section_nr)); Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb