From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177ACC0218D for ; Wed, 29 Jan 2025 17:31:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4E5D280052; Wed, 29 Jan 2025 12:31:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FDD628004D; Wed, 29 Jan 2025 12:31:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 877DE280052; Wed, 29 Jan 2025 12:31:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6885C28004D for ; Wed, 29 Jan 2025 12:31:08 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0B68C1A014B for ; Wed, 29 Jan 2025 17:31:08 +0000 (UTC) X-FDA: 83061180216.02.3D9F321 Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf23.hostedemail.com (Postfix) with ESMTP id D4DF614002A for ; Wed, 29 Jan 2025 17:31:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=0gi7jjXf; spf=pass (imf23.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738171866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1TlmWlLzdiXOK3rluf9Wmbc+0/Pe9s8d8EO+Xcqr/p4=; b=H8/ZGMm26vRnmjFJNXnKGMecZxR4O/IN2WzkRCv34FGf0tsd8n7EBn1mbI6TeJkGB2IuNC iS2HaNK+71lnD9RVJ0i38qeTQ3ZbPOBMVZlBZE7HqTIIaojvoaZg2L7Eawu+N2FLv4HqkC YoqQc0e8uxe+osb80QKX+1UL/GqgRPU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=0gi7jjXf; spf=pass (imf23.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738171866; a=rsa-sha256; cv=none; b=xuRvKTlkB86gmngD8o6Jz8wRfEHJofGPpEU1PcEAl2G161zINQdbLLQtFevZOwJRhOvtbE nkCzoNhR1Zx6afw+PxgMJYAaXuAI8I+wPn7HxVUrNW1Yab3dVUvZ5Zm2lxnLAgJW8+JD/9 YMNhwo5St4Nf3iOeP5H6UGWYCNU8low= Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4Yjq204yzLzlgTWQ; Wed, 29 Jan 2025 17:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1738171857; x=1740763858; bh=1TlmWlLzdiXOK3rluf9Wmbc+ 0/Pe9s8d8EO+Xcqr/p4=; b=0gi7jjXf6zjqlWxH6GnKer9Ex9e8L577EWRDknHk DWr/DvPUfiLEhIigXE5uiijmW7X446B7tOXZS/+itYSH+gUwXd+5+iXXTx3tyVGu dFnOh5YSMVRSxq4DMz6AbIVkLQYsl45v2vG+KpfCCxy48NPzXE/ulvnakxWK2Bx9 fmBt2SZWfdrP8GB6bHCS3kFKRfWMkJFGVNU217Ulf+ii1Rukg0y0hljWN0Tf7xG6 /dMjYybummRNblMFaICWGm5+ETZrixAuCFiWiYVpZavUu3AN7vl1JAH6fvmJnCUn 5hPwW+YDe5vTvc2kOoygt8ancZ9HGhKuDom7/Tg+po97Fw== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id fzeF2YK-OYcN; Wed, 29 Jan 2025 17:30:57 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4Yjq1k2zGvzlgTWG; Wed, 29 Jan 2025 17:30:49 +0000 (UTC) Message-ID: Date: Wed, 29 Jan 2025 09:30:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmstat: Fix a W=1 clang compiler warning To: Vlastimil Babka , Ivan Shapovalov , Andrew Morton Cc: Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Pasha Tatashin , David Rientjes , David Hildenbrand , Joel Granados , Sourav Panda , Kaiyang Zhao , Johannes Weiner , Konstantin Khlebnikov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20241212182425.ad1f7894cd0f00b2e34bbaed@linux-foundation.org> <20250122015818.3308696-1-intelfx@intelfx.name> <6a45a521-71a3-4087-9320-b8aeecea205a@acm.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D4DF614002A X-Stat-Signature: dnos8q5cjphhygyefcfwp7c1spbcpdtt X-Rspam-User: X-HE-Tag: 1738171865-421415 X-HE-Meta: U2FsdGVkX19EqutL7DahyI2Y0bdwvGYE9jM+f2JUBucyzXhlSZQy1dH9DWcPEIVAbdgJd56qmKzix1hl7eY85rXNHzRzMStuzBD7MgVB8k64gQWZxH+1MsntReX5oaxucvdI2q2Se+t1AXnTmzFUPS8bQpWF3IgtC3sl1iVoIPptO2FRHE+R5/CDpWhuMmHCOyHFD9MIXgIAI7LrDY2P9sdcQFOdhd3vYXxueM/CHQz15l61Sj9y6oN9phpGP5HSBZYtjaPZ+eB4VQAwcR0wf9EkRdONEHyrtrrop5fjFFofPfj7I/5BDnTkPx6H6Z5ZYb5+DC3qAEhQxU33/46Hho7FRRkLpHlIwPsYMC9M/GrLGtsOzza7FFrzfTQBprzBdSqkiuZRnskc1mI82cTuPKOULIf75x4t9pxX0HIIMXD4B21W2EC8GLr3gt2wJuxQlfblbB8+xkw59e8oddq+RlM+XHY5eErH8lrNq3jDTDzqekZM37UkVPMmwdpoRKIusVVff9NNfu2UQzlEAeYXJy/xa7U59Mok3wi3vexct76CMNxxwbHMydQcUujXLM9yvBr7Tx7jef8g01++REqRMJ3rervOH9snL7epkAnyTTMCh5ZHsgckMjZoeIFxuVXwmRFDUgH0ErdU/5upP/IoJyrJgcNfF4WG0gI18Gnpcu6v8fEcdVg7AKvTZ1UOtMbYH2KuLWSeJ6Je7FfIt1aBLyqI0xMMpAfs2J2fRRyC4R5R8VllQV5J9i8BRkPZ6gOiN7kzA0akaLvEH9pjbTiKV7p9CMF/y/9+D82Tcmt6A40X/gNLU4d3GKyoUf1pmV1NbnjY2OWgsv1Pc6cRCXFhymMtOTMoYIGUqGJwGCabZBIGlU8cSxzY0RccwvKHWDDIKnwFmcRVMYkDU4Rl9legsebCN9bF/gstHUb/uKatDJ70QO1KmvqzC+2+k3NeucROR42VfP8ET+PjVdqi4Fb 6rcncFYM H+wUL3nHqVbgRcTpZhusbPTPHVYeL5nxmiTWqUQ8BgCsfgY+yqmge3S41minc0CueNuSBSqLxPG7fC4daDh/+3DEThjjxRDM6MDB8C6XvxFmg4QwRk4a2qEVkFbp/Xkkl6WPxdmzfHPiXxH3T1sj2h06aBtDJ+t1q24bj+HrzzaVFCz/L7PxJ4LP5vOHGQL58z3YDVaK6YikGbvMZRPvPAy7yvojIasgQY5G1Z961vhtGZqp4cnbvKxOMxEUvBKDRgK/oWEvg5Dt8fN/alpUurjI3bW0coYIGdiPI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/29/25 2:22 AM, Vlastimil Babka wrote: > On 1/28/25 22:36, Bart Van Assche wrote: >> +#define NR_ZONE_LRU_BASE (1 * __NR_ZONE_LRU_BASE) >> +#define NR_VM_ZONE_STAT_ITEMS (1 * __NR_VM_ZONE_STAT_ITEMS) > > Seems an acceptable approach, dunno if this multiply by one is any better > than casting to int? For enumeration types that are wider than an int, casting to an int causes the highest bits to be lost. Multiplying by one doesn't have this disadvantage. Please note that I don't have a strong opinion about this and that casting to int would also work here. >> + >> enum zone_stat_item { >> /* First 128 byte cacheline (assuming 64 bit words) */ >> NR_FREE_PAGES, >> - NR_ZONE_LRU_BASE, /* Used only for compaction and reclaim retry */ >> + __NR_ZONE_LRU_BASE, /* Used only for compaction and reclaim retry */ >> NR_ZONE_INACTIVE_ANON = NR_ZONE_LRU_BASE, > > Should we rather use __NR_ZONE_LRU_BASE here? Right, I will fix this and also a similar issue below. Thanks, Bart.