From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7FBC369BD for ; Wed, 16 Apr 2025 14:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6905A280129; Wed, 16 Apr 2025 10:53:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 618B4280126; Wed, 16 Apr 2025 10:53:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41B5F280129; Wed, 16 Apr 2025 10:53:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 249F9280126 for ; Wed, 16 Apr 2025 10:53:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5DA021CAD81 for ; Wed, 16 Apr 2025 14:54:00 +0000 (UTC) X-FDA: 83340201840.26.99BC0CF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id C6FB318000A for ; Wed, 16 Apr 2025 14:53:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mLDHyHOA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=36EYFSdW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sskh7Uax; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=M76MfYdE; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744815238; a=rsa-sha256; cv=none; b=Frirzx2K2c2Mpy7XrKPRp3xEglZ7wzMEzh6wvaTxy30BXliGEXctkHdWreDe5/4eEJuff5 0uLRI6DNLdVwTEDbTKyAUoRt7YTLAVcJXBgD6zvuh/D0Xi//5dNsLCjJSAFgoTxn4Q5K5p AyYg7pUqR90fPfS6ASytp99nObp97qM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mLDHyHOA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=36EYFSdW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sskh7Uax; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=M76MfYdE; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744815238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YkgtQ+UWIbfCZnWoGZ6JgnphjyVNxz8iN4SOVzgTZFE=; b=tiId1z9Xi2Amq8VCfeZfFJRM24jkbCAUzvEwEZTPPjdm7u86/UIta+ohOyb3uBidCQd1k/ tky2ozvwBnlJmGF++69MRDO+bHAxMF1DqxjVQwTCic7+N/04PD1hDYp+0ukbTARoZpfOBO 089Gtx7PIO+YJ/E/8Mj+szJ8J1AsxlU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E10AE21184; Wed, 16 Apr 2025 14:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744815236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YkgtQ+UWIbfCZnWoGZ6JgnphjyVNxz8iN4SOVzgTZFE=; b=mLDHyHOA02XoeRDv7orOfwnWt88ZO1StLQmXSvGnWxL9gDE/8VJ8D5NVnI+KctV1Jn6rrX GxZLHwc40muTbDlwW0nP8jQKYmrXecuv84urpZ/ShkkleE+ZxLZtwbqBv5J/GC8jXnJ3cc eyrFiZDqo5wtJVKVx0RhRPmQUQkTPw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744815236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YkgtQ+UWIbfCZnWoGZ6JgnphjyVNxz8iN4SOVzgTZFE=; b=36EYFSdWakGluSIT6lBAAewxH893XIgtKEHaDivnL5XmIKl7cqsXQUpOTRErhFJ2omySpJ /PljNxP8a3DejrDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744815235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YkgtQ+UWIbfCZnWoGZ6JgnphjyVNxz8iN4SOVzgTZFE=; b=sskh7UaxDvdKcUVeXYdZCbgSwmNCHM7fENy1DuT6JKUrUDFz5Uf1WIW4SPjp7siCMBbHFL oZTfNqWHn/ZzcvR8nSWo2AqHsrqjaq1q71/6eLVnDe2ujgGTuJK0v2oQ8tT7zgkw0NAUu2 aun2RPz5J8t1c6QunXOt4o1oaMwd7mM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744815235; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YkgtQ+UWIbfCZnWoGZ6JgnphjyVNxz8iN4SOVzgTZFE=; b=M76MfYdEo9Bmzw/mtzHRkBohJA6vW2j7W0gcin0vcm7Dd62pnG6tw9WVw3l+bsPmTqJTJm xC9QMG8YOn4KSSBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D33DA13976; Wed, 16 Apr 2025 14:53:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0xdBM4PE/2e9VQAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 14:53:55 +0000 Message-ID: Date: Wed, 16 Apr 2025 16:53:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: vmscan: restore high-cpu watermark safety in kswapd Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Brendan Jackman , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250416135142.778933-1-hannes@cmpxchg.org> <20250416135142.778933-2-hannes@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20250416135142.778933-2-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C6FB318000A X-Stat-Signature: dberj41o13fwc571nx3e5f8y7wt8jeo9 X-Rspam-User: X-HE-Tag: 1744815237-753305 X-HE-Meta: U2FsdGVkX189Eod4Zw+MfVe02jT0mIKKiRCzeVlLZmCrazgdhI3Co+vQaix+P/3KxwychD1wNlgIS8ViA2Wm3vKxkWgE8//QJBxsDT+KMTi2K46e5qLre3819LHCO7YLSOtyojYMG7q0fxfR2MNd77cxaZBXekKD7u88oLGtJi77i9DpDWl2wSRgsw7k8gJv25EGNHQtwlmc8FpWcX0PlfZvu/Bl4099gfcOXT14VBcyeRflOxo6rxf9AT74DmtVWdVQ31xRyhazgmssHkckf5t74rKmvdQ9BJC+f1fbIJKhyZYvJGgX88UAd6rGCsUmD+H7uhNPOSkgcuoanvh9vpHFMyzhKFYLJgBkugSaeoci4VNveLZG3u8ixOVXFVPPkckf5kYUM7OXQPy6wXEtWmKUG+jH6/RLIQR4d4r4jG0j5tfNEn9zIKB3owoYbsRLXQAlY7fQopTuKt5R3B1hunRwlKvnlBcd6f+LsJ1nVfGRSn0B7TAHe6YZ3RoLJGglAhlFr/sb2wA38UvbMlePjdKu9DjQF2TTC5gGiqFa/8XpTVt7/cWKPwij4aSgo2nPv2doA/39jnlAyoO3oAblCscXP3yVAz+irTd4yJ5JxTR1LiXnL2833s6gFfGMqFDg2AIxxyf4ZgpsuoXZnsk+ulqFjhW8hiuljoGyX62A+/2Urs6/NGPF0UJ7tpjEw8kxEjIFD+tOzSbuzNmxlFts5xT7vZPV0AJih2dphNNELwtxc07vMKYTra5L1EHXeGB/N0XjOkLiee+QUqzP9fuEdW1KNgp0KYTxT4d2bmRSlEWgg02rgYFFYx5K2lJ+ZQn1f2onYHF8/zwepu3A6HsS12EqnSF/+UEgSZgBtv/ZZ59uH5mSOJfmeOXROZTyh8H1sldF2V2dvTsspXEZ2thzE9tAjvqOQFcq4kraHmI1a2YDvxuEum6FZHs1MxfxYycPxlAAbXindmaRKg/fO4n gNpSeMen kcX5RiY9/l5l6Iht4p1c7g/Bsuaff6Z1lgj4VFNN2uSBa4kgr2hqtE5TGra9oH7fvUhyD45PSNy/FBbGLZ/gxvtqhdqTKVCp8sou51hQbGRz89MrVR/7WgvYj75i4Zl86qiPFJ5WbU39gRIuyStUJoEYF2iNMu4LG9kVK8MVKxUMsZ8F1k75zLLI0ytqoQaeymWohXabdjzoOTWm+sDXbXHkOJx7+Mq7kBLlpCK5jDWQ82MFFV1IDm4RKfWbX80hneZquiJjxxtxpuxDywPUh5CBUB2H2LPlzTCveq7W4gZTh+sSgo0F/Z/r12jJ8wJMJhDE0XdOigXDECAczrDKhtUZKXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/25 15:45, Johannes Weiner wrote: > Vlastimil points out that commit a211c6550efc ("mm: page_alloc: > defrag_mode kswapd/kcompactd watermarks") switched kswapd from > zone_watermark_ok_safe() to the standard, percpu-cached version of > reading free pages, thus dropping the watermark safety precautions for > systems with high CPU counts (e.g. >212 cpus on 64G). Restore them. > > Since zone_watermark_ok_safe() is no longer the right interface, and > this was the last caller of the function anyway, open-code the > zone_page_state_snapshot() conditional and delete the function. > > Reported-by: Vlastimil Babka > Fixes: a211c6550efc ("mm: page_alloc: defrag_mode kswapd/kcompactd watermarks") > Signed-off-by: Johannes Weiner Reviewed-by: Vlastimil Babka