From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B50E5CD1292 for ; Thu, 4 Apr 2024 20:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EFDB6B0095; Thu, 4 Apr 2024 16:13:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A05E6B0098; Thu, 4 Apr 2024 16:13:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F3176B009A; Thu, 4 Apr 2024 16:13:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F41276B0095 for ; Thu, 4 Apr 2024 16:13:28 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 828B5A172A for ; Thu, 4 Apr 2024 20:13:28 +0000 (UTC) X-FDA: 81972949296.30.678FE9E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 49777C0006 for ; Thu, 4 Apr 2024 20:13:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BetBk5VD; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712261606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AJ3/vr7xLOVNzYAk+Yc0+zfPAy8gihCrfrD2eSX4L38=; b=zj6vsNPN5Zs0g4TDxJ4dEv2Vm5r3UefQzYJMlfczvVwEuRyk1EYYZC9H9SEf35LeKe+wh2 4CQutgLhbiOHJ4xiV8Z6/8jgOGOpyf0mcXvHe3IJ62RSDiwvCBhsCl5hzwL2TZ0TlOgnqZ hDMmIN1f/VOEpwXEVMPMjee5HBZWqrA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BetBk5VD; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712261606; a=rsa-sha256; cv=none; b=DC1x0O3Vnkx7H192xG2jbU0SxUISQzrf635zo+t68vRhinqNZDIw00g2LeMuat7RG9ToJa h/P/VE/Mx1cUdhulWiRj0xZF83eNucy0GpBXIGp7XVbCVC8b9pWhpmTk9rAxS0OBABw7qy iNroP2BGhcoZWpD1uT/6sEq6/dP7h98= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712261605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AJ3/vr7xLOVNzYAk+Yc0+zfPAy8gihCrfrD2eSX4L38=; b=BetBk5VDjcqOc/9+UPkvfOf3/KLm8S1w1aSbvYrQo5JbEtDyavO0rrdtZ+z2pf7ZyLhV0q CQ4X0g+cOu8lBpCdw42kzvnJvdJ4gNky7lyf7pvAhznJg9HTJN74eH7j9ody7e4doFSHei TpKEPuqQv0fhF4SpUjdmlCgbNtdLFsI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-X-KMACigMy26kCiee5GPGw-1; Thu, 04 Apr 2024 16:13:24 -0400 X-MC-Unique: X-KMACigMy26kCiee5GPGw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33eca6f6e4bso679953f8f.0 for ; Thu, 04 Apr 2024 13:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712261603; x=1712866403; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AJ3/vr7xLOVNzYAk+Yc0+zfPAy8gihCrfrD2eSX4L38=; b=aB1ng+Nt3IFd/o1ht3bQ2UJOfOERelOu199Qrk75IW2PaXRmfL4QmwSg90sLcQpjE5 0rLMPdd9IujDkP0vQa5ABedUzporCpBe++h1VPxqT2qDVl1dlkbMX9cZWJqgByH86J4j QLeOgjI9uj37dAILdaRDzl8/EtDBy4grBCCsKvH9SOgu885dgo/6GRpTmomRw4voQdUI 18bIFCYHa9oYaLdNEOoB2QeVq05wneJQ9EEo0vCfzbaMNgm8L2/EOjfRyvRbest6ve7T Dgb0RTxejRrgQGw3bUg8b4iunt4JfRL4f8xpqtdeNnjfbeyZKujaXN//wWjByjAFJ8y0 TvXQ== X-Forwarded-Encrypted: i=1; AJvYcCUl1i7a/zruD99Q5KxuYrgUj6w5YyAXGaGm0aRhJx5AuDdFTx/hWfGQ428mjNPJjlG4Iyc0o5wPqKFAZVHZEEIOgiw= X-Gm-Message-State: AOJu0YzqaDXXGTnJR3vsaoCgMKCiCT4YVJoSJPwHsemBZNx9LPX9qBDo Aoo5w5UfM0HIO7KrrW70Vujfx4xMXPlZ/fTGQJXwv8bnG2BogLfJhdWIgdm/aZN0A9WJbrBlrAx P4AiQXv+V6y8b9AaPPmQcGVQ6cfH69p50k8cQhU28RO8XieDt X-Received: by 2002:adf:a44c:0:b0:343:2e0d:ec4a with SMTP id e12-20020adfa44c000000b003432e0dec4amr433041wra.10.1712261603286; Thu, 04 Apr 2024 13:13:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQ7F+AcpdSTILOHkiXf6HXQjke4Nt06UxDtUvq5HEHQDA220pqiyLX8yXMTs7wuZotDWq0oA== X-Received: by 2002:adf:a44c:0:b0:343:2e0d:ec4a with SMTP id e12-20020adfa44c000000b003432e0dec4amr433028wra.10.1712261602844; Thu, 04 Apr 2024 13:13:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:de00:7030:120f:d1c9:4c3c? (p200300cbc743de007030120fd1c94c3c.dip0.t-ipconnect.de. [2003:cb:c743:de00:7030:120f:d1c9:4c3c]) by smtp.gmail.com with ESMTPSA id r4-20020a5d6944000000b00343b09729easm193492wrw.69.2024.04.04.13.13.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 13:13:22 -0700 (PDT) Message-ID: Date: Thu, 4 Apr 2024 22:13:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid To: Frank van der Linden , linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Roman Gushchin References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240404162515.527802-2-fvdl@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49777C0006 X-Rspam-User: X-Stat-Signature: iuodip33ibiwjosckqmudq16enkpzkk6 X-Rspamd-Server: rspam01 X-HE-Tag: 1712261606-227072 X-HE-Meta: U2FsdGVkX18pYxTIaMNiv2aCpb11UYxi9R8TphN8a7bqoHlmqH1TWvDXGEuJcQu7HBuFWWeSIYv8cBG1ZtuhvvC5fIOnUYo8T8Qv8HXlYl2nElVZbWHxU7II/yvSvf7aC21hlOXcybbKgvQHa1L8bFLy35Zchh1FoNJ+WTUBzDHMQDxTDd4wij6+PyMqiL1EA3z18YqL36nAM1Yy2w0NGJ/OTBv5nIjXrzoWv9hJh9N7IPMYzFyZkD2uwdNUbiOwh4Bm+TfgtH3AM8smiAO8rucWnwcYfRdoU7i5Aauk8gGucZqYzun/oJHHJtmtL9ygqb+aRBpCu+Gqy+c6KvWFwOqHCnvsA77Y4vs+uuRyqCe2Ws7jtqWCstTEw4suL+uGl7HqXk7I8ymd0mLF0fctf/d3kGEHxejVbkjfkghH17Thg/aInk4ATmnm31JBPw5E1jA0VmjD+4eh/Tn72sxmc4l4DrwSeXrJDOIBOwVkr9hc/4k4/0hQqHfqLGQzbo6AYmVWc5D7YFvc9jzBApeQTPRoZ9ZApHr57dDbvOnsYaUxMaqM5pxppxNAnAQ6Is+ObB+P8ZvLbLbM4fEIVOQ50rPQq34qwEHRHJcYY6QtjHdg8IgWRJ9fO3DDwBU5mrcfVm2W1lJWikaVAIuV+zSOG4mmp1koCW2ram1gT0oeZYYOibRLGEZcH+PlQ+e1WtyZfzSdg2CRGJ77Uu8hKV51vE7MINJ4DQVeXaAJlj8XNrSbAs6L9/xX/UPdNmiZxde6LJbEQiIe+csd398cu8lGOKa8RgZrLF4TVAZW1KbTIcoPrN2u9vBh4jUqufIMo4X8RNGxGabnL5Vd617QOvftyHPSZzKuFk08qRfRZRfomYBuopJX47v+Q5diNGJQv+NqmfFJotZ9eOgyVV8TKYiVkSHO2k1ub2wdPILD+tTVQI4Xi06BgLp5nMyzJt+xn6NclNFgHJtE2+CW1CkCwJ3 odwEyMNi 5jG4JREsiW79Ucm8lio/n/+G7/pG1PnBbNPSjQL+NZHw6SxY0Fq33hhWPWuDuZWeinUaIn0/UgTKwio+Gg6cEAufEHrlXDq5M0/GPjk7OOIs/2SuybNyuLVF62aaG/D+ogw32Iq3o9G3axqp/TuEZVPeUU9Na/lBpH802WF5TgWO/wl0Yt8t7jqKK8y88+pw4HZtJuvbBKpvNZ2Si2Eev9pmyUsmA3LF3qB8VW/GijV4YjF4br2bbgQ+p5W4XpeG7MKkeqypwACzrtzXoeY5u0YZf7Vtb2xbs7EB8GBTE9LXNF4F662nQSy6Z80Sq7hrZBBUC3Ohkwdz1e5/fBDij3BOa3RThci+eQG1fPropyaU5xnCf582eNm4gKFpGdfxd4XxqudYrLQhh4By8b5j2fGJIHubrnxqMzD7v84HFUY+gNV6zMGNck4SAlVElvUw+0w1oN6lDUpiflcYUK2fHjtR+mJQoWSb3/in0nqynfqy01b0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.04.24 18:25, Frank van der Linden wrote: > The hugetlb_cma code passes 0 in the order_per_bit argument to > cma_declare_contiguous_nid (the alignment, computed using the > page order, is correctly passed in). > > This causes a bit in the cma allocation bitmap to always represent > a 4k page, making the bitmaps potentially very large, and slower. > > So, correctly pass in the order instead. > > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") It might be subopimal, but do we call it a "BUG" that needs "fixing". I know, controversial :) > --- > mm/hugetlb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 23ef240ba48a..6dc62d8b2a3a 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7873,9 +7873,9 @@ void __init hugetlb_cma_reserve(int order) > * huge page demotion. > */ > res = cma_declare_contiguous_nid(0, size, 0, > - PAGE_SIZE << HUGETLB_PAGE_ORDER, > - 0, false, name, > - &hugetlb_cma[nid], nid); > + PAGE_SIZE << HUGETLB_PAGE_ORDER, > + HUGETLB_PAGE_ORDER, false, name, > + &hugetlb_cma[nid], nid); > if (res) { > pr_warn("hugetlb_cma: reservation failed: err %d, node %d", > res, nid); ... I'm afraid this is not completely correct. For example, on arm64, HUGETLB_PAGE_ORDER is essentially PMD_ORDER. ... but we do support smaller hugetlb sizes than that (cont-pte hugetlb size is 64 KiB, not 2 MiB -- PMD -- on a 4k kernel) -- Cheers, David / dhildenb