From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81A7C001DE for ; Fri, 28 Jul 2023 20:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F23A88D0001; Fri, 28 Jul 2023 16:33:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAC6B6B0074; Fri, 28 Jul 2023 16:33:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25048D0001; Fri, 28 Jul 2023 16:33:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF8E66B0071 for ; Fri, 28 Jul 2023 16:33:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7E5311C959F for ; Fri, 28 Jul 2023 20:33:54 +0000 (UTC) X-FDA: 81062171988.20.55BA3A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 425B9C0013 for ; Fri, 28 Jul 2023 20:33:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RoWAQJwV; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690576432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NPoM804CxQXNyaqYOi76F9KayN7Vk1JGyDtsJtbRViY=; b=hglIIytHaaPQ5qHYhNfBKO51UlBYDP5MW6p+f0ExcNhDfKxa3Tvx6S2+JdFx/n07MHt8DL T3B8CxqgV1jSydWZ4hpQTwGgYIhoBMTQYM7h6Pqd9BNZqHeAlwis/18hc8N4LWopIqn2Ea /sls5nfwOnb2aKQYUzwo6k3EouDj5Ds= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RoWAQJwV; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690576432; a=rsa-sha256; cv=none; b=BVOtANbQW0O4Qj6nOrWi3aYLa48XnEQa2AwH3OkCIHHNPzKZSMHlb0rbwAioc6gHBzi3/n bh55LR+o9OrhKvDpDO71Of5cIamodbQ9/sOoANZ7g1zqOYrfAhfPfzoP1KavYrSmA97HJf dy0ijeB34bVL2ssU8kayo6N8GqJO96s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690576431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NPoM804CxQXNyaqYOi76F9KayN7Vk1JGyDtsJtbRViY=; b=RoWAQJwVAujyY7wHiFUyXT5zYdn3Sf3Kitq2icaGpYhn0h1NsmFZOp4VwHORhduLBTrE3q YuXScg9kxVHcZ4u7TajT5REIxsnO28Jo71YfJQZQ02Z3GBJ96zi2QK5ZLgQIaiV8lef1Q0 Bzw1YM2RqLutwLuK2UsKGnYxvgvx1KY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436--pVt93BHOkyT0sOhcO4eGA-1; Fri, 28 Jul 2023 16:33:50 -0400 X-MC-Unique: -pVt93BHOkyT0sOhcO4eGA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fbffd088a9so14944165e9.1 for ; Fri, 28 Jul 2023 13:33:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690576429; x=1691181229; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NPoM804CxQXNyaqYOi76F9KayN7Vk1JGyDtsJtbRViY=; b=GkEw0ZprETcV1gaYEXHtBxdUHgXYYo8FMGN3BcpU+591LGCKHjvaiJy5Mjikj8jlEd 9NSVKjvatDSyAepsClQ/E6z0QUUucA8v9vo4MafuNn8vfzBxhHcq+Z7LoRK7zM0VfnvR ZPqsO7H9bTpiXMgvffL5as7pgO0riXxEZCdva4EhCPd9AlTpYywVVsOVoZlxpMlCEOMA HqHWTOoqSXobAmu+XWuVIPoChlf89lsJQ3L9pFedP93HnXYIzdtDNCTEYI5geCUABrc1 U2Qp4B08txM8kzspRMxBk2ak9QVDSzyOS59k4LxkMuSFntipS9gJAVzpbo1FzDs95TTG zfOA== X-Gm-Message-State: ABy/qLbqL87zGKDptpnth8h0Z/UDLZqJvosurXHb4sHELL2T99QTmjCQ W8KeIUMklAsyQXREOSvENGyGAflWp+8zzXgktqByNXKYGGXTtO253VE3+xlqnhqKbiGxge3n17+ 6xsoeuI27Jnk= X-Received: by 2002:a05:600c:210b:b0:3fb:fb88:974b with SMTP id u11-20020a05600c210b00b003fbfb88974bmr2633203wml.6.1690576429286; Fri, 28 Jul 2023 13:33:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlE0EWcwQHpVt4+4O+ITavcaEd7PJtizFZdLzot0OrKUsQ+DOTY++M7GZKjU+qSoarDGlXFOaA== X-Received: by 2002:a05:600c:210b:b0:3fb:fb88:974b with SMTP id u11-20020a05600c210b00b003fbfb88974bmr2633190wml.6.1690576428946; Fri, 28 Jul 2023 13:33:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id v25-20020a05600c215900b003fc02a410d0sm7630531wml.48.2023.07.28.13.33.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 13:33:48 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 22:33:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 0/4] smaps / mm/gup: fix gup_can_follow_protnone fallout To: Linus Torvalds , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard References: <20230727212845.135673-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 425B9C0013 X-Rspam-User: X-Stat-Signature: wip9m9fe9j8apjxikctisb1yakgx7bgh X-Rspamd-Server: rspam01 X-HE-Tag: 1690576432-551631 X-HE-Meta: U2FsdGVkX1+XISeEwIEzcQQbuQS7v4OwA57LnGrH9lGJBUNWjQNjqW3f3Jd8NSDsUOXhc6Nlc5sXONRcbAPwxIPqSINVQn9OXqzPJnvABMgIwrQcGTecgpiIGoJYiVThitx48PETt0GYZEQnBts7LPFuQWej8ksvbhoEZgswqHZ1WyE9PSdnWPi5bSmCJnGTO6aKuWABv9iycM5pPS8us3t5CfojTe8ZMVwGwO4zL+3GNAHpxxlVlGIKonFNFi2I/Nj31qiurpeVq/bqvydCiIfyVo3xuC59cC63vgrz2qIrY282uO8VDdchDGRoEtGrXGEIUdQ+CFmTQxOX3nRAsEIfRHRMkL0HI+o+HMNk2GwbfNRLo0tbKXqVghcZudwVLwgkjEXf3bsZkSzBwNtdoS6iRLAFc1qTF3dB7R7jOpciOVxR3p2atVQDvzBwOsPwQ/8v7+OJGHjlY0I593v35dFwLU1a58LhsBQh7g/NnHY+66KaxwUrWMjN8XiYQxgHY7OfVmetpWjQXVdKFxGUWAzI7qeiqURf8rkpkhSpUwP8FQDO6EhZiR6EJusiODv9pvUL3QmQvB1cVFahVLWfvGQ6Q4imY2aaUFjU4AQ+ULhkYPRcrB05zRezCoaEp8Utek/luuJau4GoIzZRj5ghp7wTww9XKPFKG7wVZN5/sTX1ExvRUDoRlhjxXwoznceflzBkIMV55TDiubexck2iqy9EJFSvGibjQdL1tE8mi6RMaecvTFaRs3bHkWoPcy6iP1xvlid/ZWoFecVgmLdx3q/Qf0CHxGp1kMIGoh/vraTPN+lzKg1OQVHwINY67zEXZ6RsbAuMo3Unvy/uumtG/smPtP90m3nPlm5m5E4jnC0Fd7pNZIayD+ZpsPXqRgacNrq+LxJndpRJEpHPvubuLyqDGpVBsItwPRPJtPolFqukzPN/eBAS9oYzOBjcjtgNS83zc1a7REOu8PiPuul bEmBbFH6 JferUwctJ+Ou4JWoQJWd97iqyuSFbTcZiedEeR779zs+UkG9GZpV3jsIP1iiJOOkQes45ZxLP2VZani1JevL8ogNWVY7goOqLFqX4poqeX5s90Fxf4+2gCtcAZS9HB3fAszm2gEDKwaWbmJBbGfh+5nYvfSM/PzMUMVqqVO8gHZ8BLyfHD1ctopz5ud2XDr1x77mPiUA4uX10/O75bXU8tP9PEHKBQdoyJ4V+v0uDf1+5g2d0wjpE9vBwXXjVBYYpFBdNR9rFSGYxH+2mgmGFC48OM11u0NPPrkatfKvEBr6Oxsrsm1pV6cL2K+ES9FJntg2KGWIg9XDMDFUYQkfcsf9eF0UpEbZy0m230daufp2t13fIZbgutedO96dMN1n7xhEO6KXyK3OpX3eSROf+dWDHr4vsRLn1phuQLtTju0oSV+bJHfEhQiEICoHFYrgUmhYmmQblVYSvSmU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 22:23, Linus Torvalds wrote: > On Fri, 28 Jul 2023 at 12:39, Peter Xu wrote: >> >> But then does it means that any gup-only user will have numa balancing >> completely disabled? > > Why would we ever care about a GUP-only user? > > Who knows where the actual access is coming from? It might be some > device that is on a different node entirely. > > And even if the access is local from the CPU, it > > (a) might have happened after we moved somewhere else > > (b) who cares about the extra possible NUMA overhead when we just > wasted *thousands* of cycles on GUP? > > So NUMA balancing really doesn't seem to make sense for GUP anyway as > far as I can see. I do agree regarding many GUP users. But at least for KVM (and probably some others, but most probably KVM is the most important GUP user) it does make sense and we have to find a way to keep that working. At least, removing it creates significantly more harm than having it, guaranteed :) So would you rather favor a FOLL_NUMA that has to be passed from the outside by selected callers or a FOLL_NUMA that is set on the GUP path unconditionally (but left clear for follow_page())? -- Cheers, David / dhildenb