From: Yang Yingliang <yangyingliang@huawei.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
<akpm@linux-foundation.org>, <ljs@kernel.org>,
<Liam.Howlett@oracle.com>, <vbabka@kernel.org>, <rppt@kernel.org>,
<surenb@google.com>, <mhocko@suse.com>, <liushixin2@huawei.com>,
<hucool.lihua@huawei.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Yangyingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH -next] mm: vmstat: make refresh interval take effect immediately
Date: Thu, 2 Apr 2026 10:13:26 +0800 [thread overview]
Message-ID: <e72e2b72-d408-8af1-9316-2f3ddcaacaf3@huawei.com> (raw)
In-Reply-To: <f65f3910-f444-40bf-9d15-42a8b6215a56@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On 2026/3/26 18:09, David Hildenbrand (Arm) wrote:
> On 3/26/26 08:55, Yang Yingliang wrote:
>> The refresh workqueue is re-queued after last timer is triggered, so when
>> the refresh interval is set, it doesn't take effect immediately.
>>
>> It leads a problem like this: if current interval is 8640000s (100 days),
>> and we want changing it to 1s, the new interval can't take effect until
>> 100 days later.
> Well, yes. But, the default is set to HZ. If you set the default to
> 100days you are probably doing something very wrong in the first place?
It's a fuzzy test.
>
> What's the use case that warrants the complexity? Even when set to, say,
> 30s, waiting 30s is not that bad.
>
> Would we maybe just want to set an upper limit to which we clamp? That
> would be a lot simpler.
Is this too strict ? If someone want to set 1min or more, but it's
limited. Some existing
scripts function may be broken.
>
[-- Attachment #2: Type: text/html, Size: 2910 bytes --]
prev parent reply other threads:[~2026-04-02 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 7:55 Yang Yingliang
2026-03-26 10:09 ` David Hildenbrand (Arm)
2026-04-02 2:13 ` Yang Yingliang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72e2b72-d408-8af1-9316-2f3ddcaacaf3@huawei.com \
--to=yangyingliang@huawei.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hucool.lihua@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox