From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17613E77188 for ; Mon, 13 Jan 2025 03:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D306B0093; Sun, 12 Jan 2025 22:30:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BD1C6B0095; Sun, 12 Jan 2025 22:30:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8848D6B0096; Sun, 12 Jan 2025 22:30:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6806E6B0093 for ; Sun, 12 Jan 2025 22:30:40 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1CC9DC1AA5 for ; Mon, 13 Jan 2025 03:30:40 +0000 (UTC) X-FDA: 83001001440.02.FAC3554 Received: from va-1-100.ptr.blmpb.com (va-1-100.ptr.blmpb.com [209.127.230.100]) by imf29.hostedemail.com (Postfix) with ESMTP id B04A8120005 for ; Mon, 13 Jan 2025 03:30:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=2212171451 header.b=puL7BQQl; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhuxiaohui.400@bytedance.com designates 209.127.230.100 as permitted sender) smtp.mailfrom=zhuxiaohui.400@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736739038; a=rsa-sha256; cv=none; b=Vld3RdNaGtvsii35+WEZEQ/kDDz1m+Xp0vWqD2BR6SsaOpoVwjSE7z++jzvCd2/k/8TFwV qnGVzqWZeitQz4BW9FnLp0RV+gvB2rC96l0P7GrgMxanBoEgFGsjyj2Il9TvJjZrrD6FdU TlCMTXpGxqcgeWdekGNgggu5VoE9qY8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=2212171451 header.b=puL7BQQl; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhuxiaohui.400@bytedance.com designates 209.127.230.100 as permitted sender) smtp.mailfrom=zhuxiaohui.400@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736739038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ybogo5xzG1fgCTV7Hj/lu//TPwnOLZ8cZLkoFIxDNto=; b=QCUGNm50jZSYbunT10i0ixCZtVUKD4EXgggxi2djmHyYa9awfWVlpcinyMtugdK63aPuBS QKF8NeJei+nhHuYEUPEb7Lgr7KNiWNwgtgNZGyZ02nuqyxj1KqwXe+3X/jWbAOdMepeZLN dr4Zt2hTOr1hJZ59SSyu7zW3LEPF7GQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1736739032; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=Ybogo5xzG1fgCTV7Hj/lu//TPwnOLZ8cZLkoFIxDNto=; b=puL7BQQlWYsjtDmaeQWy09SGA4Aepm9tzGi7b3h4OcAiIJ+bRosyUBqbmUoXoUN0dnLUgn jTG9h8TV35rXkqFKptFTQbmWF2qa+nkOJhWrabTWd7c3uJSgVtwz+gkHJqvufUka+rUIkd mHzhNGTRE+Rto63BDegdQymdPNAO3NWIeYQQ29Xm9/E+hfiyd+kDE2zqTBHUgM8VEMw7Op Ts9/YP00Gpg5fDkNErJtFEY9RgLIbKcO8EEEGpOBRP0kcwCwuNJyun+dgAemKswb4eFuV2 CowHHvc4mcqrkIcwceREjSlg1C+OxRmNXDWS8hReaIgVDo/ljUtM/YmjGKJbgw== References: <20250113030702.58502-1-zhuxiaohui.400@bytedance.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Message-Id: Subject: Re: [External] Re: [PATCH] hugetlbfs: check dir in trace_hugetlbfs_alloc_inode Mime-Version: 1.0 From: =?utf-8?q?=E6=9C=B1=E6=99=93=E8=BE=89?= X-Lms-Return-Path: Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Jan 2025 11:30:29 +0800 To: "Hongbo Li" Cc: "zhuxiaohui" , , , , , , X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B04A8120005 X-Stat-Signature: hkno4mjy9nofffgr11g88ompx9q3qhfj X-HE-Tag: 1736739037-328901 X-HE-Meta: U2FsdGVkX19WzU63CgAo5lbJUYXXE+0KJk+VAtzRih9d+tHDh+2UQKb9mvnnR9+QaRNL2Chxb9y8flYqmVa187Gk0c7WCOtISunnwG4BI5dq2WcYya24gQafMm0+MLJim3leyZyj8fOYevUJGuhy5xy3fopWsBlqnL33adgm3JwBm3GgR/AZg+Tj2Ue0GTvkq6O86XdViTecnTmj8mk5eFQtye1M8XRKSAW4P92Uii5x+FgnEc6jefiiZXB75nurN0jZ7LMa/tJMvUhvIKw1tFh9J9yw0hK0PCFx5IXBhRQFm2nUiT4+vI0PigV2JDLI3vM3WNdOpZ4A+yUSZqpfwvUNN0/gF+yoUPV90Qi/e3jyvajtepnjo/J/jYblGrhGoDgJj9udeSjE4ZV5uwN/bPmzOqoGtEBcZj58kwxeLSQy3ktOoDsJn8x8bZLli+P/ysTwlate4Os6XnDZjrVKfMmyNnMs9IcNwrUKCCopAhDWN5zkmKcjgIwVWvQKtaEoB1hyQ6vFaBaICcNoq+eNzVUGD5MYPr0TErhXYj5HUMCV8tbWnX7zdM1HqHiarbRsH3xtyuVCVT8FB0kM3U5VMB0G/0pW9u0td3SDNG/ckX5ElG4+xzFNWUqIw5E+WH8blaIQ35pH58VXKDUmpohpmh8CnZawNxyv+TIsbQRWgwqCQBtigYAXOnLTHURR7cVU77vkRXk1YLmpyP1vArZ7CSnVh9lNxk7C3af1hmLA/ejHw5A8Dxmi4qHhc6tkJHO9AQb4tjFfLG2cZHCDl9QV1JutgrZQ0IkDLp26ZN39NS/Y5p0uWXVAXOLzl2vbQWuvpN98yRrXogPMZ2c2EzqlssbW4nc3s6YfY04FiPU1c8nXMs09da5dA7DDCwW9uo6M+ZWQ7nAUVr/oaNi6WH9f/W4I6dTFB/9/weTl60K3OJhlueSnsa79uqC9J53A5oDQ/Rnl4YXqTbR8odGT/qx J7VeC25/ LlPTGNEJWkDCfwfql/oyvEhGkFr0933X+0Bg/eRinvG7oh+SAQoskibeSAtikkI2VTMTei3XIVsbY59P0SR6ZiYzQTxvyLE+IIlr1244xArPjdMXzbZOOPGFXMdopicYjv3pCN9iQOkixltaZ16tWheyUUwSRSQYaojhHdhw7cp2kyqyBGA46pnbSncq4H8v3FmrH7UeLt2lwioxxUO0/Rswrda++aJ8XMebtyrF1AYtiJPqAuKammSKV8jd4JjO+8iZvgwKQ5KYiRHPipGmqwSmMMyTPpd2bB3GWW4m8oMZlWqgZeZLjimAs0dAdDuGhfx3FAQqCnKI2WZKJCJPhlmVeQ4KtRCuIc41xiB+RpL9JzALWznSX/uKUtLQJBnivypGLMHtPB4EERUx/CyyYnh8/ed7Ke6uCjthxqcm53bfEFTuOXCsa5Fk+FElmy5cOzjp28WMW9Ms+BqaCQ9QaIGq5h+8cZI7LF/d39Yct0f6e224= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000087, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Got it, thanks > From: "Hongbo Li" > Date:=C2=A0 Mon, Jan 13, 2025, 11:29 > Subject:=C2=A0 [External] Re: [PATCH] hugetlbfs: check dir in trace_huget= lbfs_alloc_inode > To: "zhuxiaohui", , , , , , > Cc: "Xiaohui Zhu" > On 2025/1/13 11:07, zhuxiaohui wrote: > > From: Xiaohui Zhu > >=C2=A0 > > Anonymous huge page has no corresponding directory inode, > > which cause a null pointer crash when access dir with the stack > >=C2=A0 > > =C2=A0 =C2=A0trace_hugetlbfs_alloc_inode > > =C2=A0 =C2=A0hugetlbfs_get_inode > > =C2=A0 =C2=A0hugetlb_file_setup > > =C2=A0 =C2=A0ksys_mmap_pgoff > >=C2=A0 > > Signed-off-by: Xiaohui Zhu > > --- > > =C2=A0 include/trace/events/hugetlbfs.h | 4 +++- > > =C2=A0 1 file changed, 3 insertions(+), 1 deletion(-) > >=C2=A0 > > diff --git a/include/trace/events/hugetlbfs.h b/include/trace/events/hu= getlbfs.h > > index 8331c904a9ba..5daa52053edc 100644 > > --- a/include/trace/events/hugetlbfs.h > > +++ b/include/trace/events/hugetlbfs.h > > @@ -23,7 +23,9 @@ TRACE_EVENT(hugetlbfs_alloc_inode, > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 TP_fast_assign( > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __entry-= >dev =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D inode->i_sb= ->s_dev; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __entry-= >ino =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D inode->i_in= o; > > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0__entry->dir = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D dir->i_ino; > > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0__entry->dir = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D 0; > > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (dir) > > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0__entry->dir =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D dir->i_ino; > It has been fixed in [1] by Muchun. > Thanks, > Hongbo >=C2=A0 > [1]=C2=A0 > https://lore.kernel.org/lkml/20250106033118.4640-1-songmuchun@bytedance.c= om/T/ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __entry-= >mode =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D mode; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ), > > >=C2=A0