From: 朱晓辉 <zhuxiaohui.400@bytedance.com>
To: "Hongbo Li" <lihongbo22@huawei.com>
Cc: "zhuxiaohui" <zhuxiaohui400@gmail.com>, <muchun.song@linux.dev>,
<rostedt@goodmis.org>, <mhiramat@kernel.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [External] Re: [PATCH] hugetlbfs: check dir in trace_hugetlbfs_alloc_inode
Date: Mon, 13 Jan 2025 11:30:29 +0800 [thread overview]
Message-ID: <e7232f59a3e6ab536c5bda8b4e74820d54649b7e.1b61be8b.e5fb.4fe7.8016.bcbdf32ff1ea@bytedance.com> (raw)
In-Reply-To: <b5c16ffd-d70f-48b1-b026-79dc5ff4ffaf@huawei.com>
Got it, thanks
> From: "Hongbo Li"<lihongbo22@huawei.com>
> Date: Mon, Jan 13, 2025, 11:29
> Subject: [External] Re: [PATCH] hugetlbfs: check dir in trace_hugetlbfs_alloc_inode
> To: "zhuxiaohui"<zhuxiaohui400@gmail.com>, <muchun.song@linux.dev>, <rostedt@goodmis.org>, <mhiramat@kernel.org>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <linux-trace-kernel@vger.kernel.org>
> Cc: "Xiaohui Zhu"<zhuxiaohui.400@bytedance.com>
> On 2025/1/13 11:07, zhuxiaohui wrote:
> > From: Xiaohui Zhu <zhuxiaohui.400@bytedance.com>
> >
> > Anonymous huge page has no corresponding directory inode,
> > which cause a null pointer crash when access dir with the stack
> >
> > trace_hugetlbfs_alloc_inode
> > hugetlbfs_get_inode
> > hugetlb_file_setup
> > ksys_mmap_pgoff
> >
> > Signed-off-by: Xiaohui Zhu <zhuxiaohui.400@bytedance.com>
> > ---
> > include/trace/events/hugetlbfs.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/hugetlbfs.h b/include/trace/events/hugetlbfs.h
> > index 8331c904a9ba..5daa52053edc 100644
> > --- a/include/trace/events/hugetlbfs.h
> > +++ b/include/trace/events/hugetlbfs.h
> > @@ -23,7 +23,9 @@ TRACE_EVENT(hugetlbfs_alloc_inode,
> > TP_fast_assign(
> > __entry->dev = inode->i_sb->s_dev;
> > __entry->ino = inode->i_ino;
> > - __entry->dir = dir->i_ino;
> > + __entry->dir = 0;
> > + if (dir)
> > + __entry->dir = dir->i_ino;
> It has been fixed in [1] by Muchun.
> Thanks,
> Hongbo
>
> [1]
> https://lore.kernel.org/lkml/20250106033118.4640-1-songmuchun@bytedance.com/T/
> > __entry->mode = mode;
> > ),
> >
>
prev parent reply other threads:[~2025-01-13 3:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 3:07 zhuxiaohui
2025-01-13 3:29 ` Hongbo Li
2025-01-13 3:30 ` 朱晓辉 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7232f59a3e6ab536c5bda8b4e74820d54649b7e.1b61be8b.e5fb.4fe7.8016.bcbdf32ff1ea@bytedance.com \
--to=zhuxiaohui.400@bytedance.com \
--cc=lihongbo22@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=muchun.song@linux.dev \
--cc=rostedt@goodmis.org \
--cc=zhuxiaohui400@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox