From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C432CF31B4 for ; Wed, 2 Oct 2024 11:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BEF344018C; Wed, 2 Oct 2024 07:24:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96E4E44018A; Wed, 2 Oct 2024 07:24:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 836C744018C; Wed, 2 Oct 2024 07:24:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DFEC44018A for ; Wed, 2 Oct 2024 07:24:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E2A9580B0C for ; Wed, 2 Oct 2024 11:24:30 +0000 (UTC) X-FDA: 82628429100.05.23C6F16 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf02.hostedemail.com (Postfix) with ESMTP id E8ED780018 for ; Wed, 2 Oct 2024 11:24:28 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Pz50QgiB; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727868229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FcLNlXBmYa+OUDtH1YmpqBo5nbDJcEl/hRVnSXUYy2U=; b=TbElfM982s9IxUJv4TjFocXbfL5OFZHovKjmqwXEMo6ew1QbBNXlVGLBgIVkktQVzwDJRv 23P3fS2r0ew5zzNiZ2ILH1k+tETLo5hlyrSw4JDW+8ZtWQj3EmuH+IIM0ga+kEZbZzAQEk OcWH6ckU/N1RMYMQ6130bLd6EaYeWEY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Pz50QgiB; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727868229; a=rsa-sha256; cv=none; b=x88BlYsQbPeSpmx1HVLTlBjj1BTfw9+54BKEwPtoiiZMdMQRozkbdPhFCzQqhxJP5Ug7qg UFPoj8zMmXIvYp64kvQwSwViD3R4801PBe4P4LU0R/CpqGwuIyQdYhHI4EKbsP8Gcs84OM +tUmS5+iKzXhW/DApRzDuzQ4FTM3lUU= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42cb7a2e4d6so59099765e9.0 for ; Wed, 02 Oct 2024 04:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727868267; x=1728473067; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FcLNlXBmYa+OUDtH1YmpqBo5nbDJcEl/hRVnSXUYy2U=; b=Pz50QgiBi6yL4K7FIlaZULeqlKsqDPUPaCEg4rBafsOXuPdOJWAuhzjDk2AesG8bge 0TDA5JH8XZ/9V3zh4v/brL9mwy6rKfpXSGbPhC1t7Lzqfq+OebgalDf3nf2h/MxVZ0ki U6wMIHsInfeIQICcvW17B+fYWzEWWbk1Th0JN7IixI+b3Bl5OolNZW4qmh8LJbunzJ8Z Z0X6mZDOSqlG9BYBucM8KWXccZvuxqrSC/J8UzwhIaDJaFiaz/1nivOimitLpZEESpFT BLF+WIIj2dENtNl6DGKTtMfNe3nBV7eMmDgXwRYwukCW8EJcWqAucRxdL7w1MoDO5S9S r+9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727868267; x=1728473067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FcLNlXBmYa+OUDtH1YmpqBo5nbDJcEl/hRVnSXUYy2U=; b=VDymWO6+GW++21B5pjchWk9Hxz3NmVxTW5LczGwN6qi2K23KAJcYtYl4DhsW5cCpZF 6qb1/lv9S4xdV2e+V1rl1ckdATwnUNBCsoU/dCfI+WHzPZXJEz8rxM5qxo9nDKjBn351 D2P7BdHMbRSnHMWyGJwlkekkbrgYDBih51v+BbyM8SlXK2c4mTrlvDJ5IipS0KelcBXH rIUFikML1470fXtP4GXgdWgOc74xE5CRB+EPPUO6R4bbFs26uhNxuxXva8JHAibsDMo2 7aQ849/UpW/AGalV5qbUXgZzBFUlHD8hEEINwOX7mDKOHgM71IAWJn0wWn3XQOFshNWl uouQ== X-Forwarded-Encrypted: i=1; AJvYcCXGoHI3ZgecWWsBDE/ftkuEEWZQAZEb2Qsw/dek5wzYcVe7orSIPVHSsX6NFc+j9gL2ELo57WdHyA==@kvack.org X-Gm-Message-State: AOJu0YwtPITFxzs0l/PhVXTE9ihQ5M3FKME4EzRCTOkqH+z67Gv1441u 2hyBh4PZqyv/XVhU6o9pKA4qXdeTDJdHI+iX+dFGhSYee5jzILolA2xLFOFtTmQ= X-Google-Smtp-Source: AGHT+IE+unZYeyT7IcoUfkc76BvB+aQnEO6Ki9Tzer3ZMIoT2Nu535PN1YVVYnDvG7jGhoeYb/pDtw== X-Received: by 2002:a05:600c:4f86:b0:42c:b80e:5e50 with SMTP id 5b1f17b1804b1-42f777633f9mr20596915e9.0.1727868267302; Wed, 02 Oct 2024 04:24:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f79d8d409sm16277245e9.1.2024.10.02.04.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 04:24:24 -0700 (PDT) Date: Wed, 2 Oct 2024 14:24:20 +0300 From: Dan Carpenter To: Naresh Kamboju , Kairui Song Cc: open list , lkft-triage@lists.linaro.org, Linux Regressions , linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell Subject: Re: next-20241001: WARNING: at mm/list_lru.c:77 list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="y+7EcPOXsnI0Fodd" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: r81fucupegj4zeteg5k8tr1y6xh4ik4g X-Rspamd-Queue-Id: E8ED780018 X-Rspamd-Server: rspam11 X-HE-Tag: 1727868268-844381 X-HE-Meta: U2FsdGVkX19OCZfq1D51MjIoUq8LbkBswCYseM2/3DCITBeg9T8M+7bYonn3UOpLLJ6TF6SqVI70XRd5htY/+AfuXuC9wr0XjdeZMClUllsMmhExtRTPMyt22wPf8cdL2zlWInQQvUR/eSvMMqJFZ+Y6Px5wgOPj8Ani6WNAL9klc8oZGJEanvolpSIbRgVpal7xUfN1GW1MZY3k2R8cw8CEZzq7lVgEEUNSgMhjr2TA39nH/JasKDCxJfWXFzd6Dh+Vw2Pb+G0hfW3LUbIKccNgOMR5q4asmoYY3p4FiJRj7Zej+iVibip55D7g0Nf2NuhmMmiC29EkWQHXQsoO0wk5q1pB5Volpk31qrGZOl3mBJ2qnJpXlPT3Gyjg2ViXCXyFJm338hOXynUHzUSRNlBxJIxseW2H6Q/F/t9ZpiApJcxW0MTey6RdbN2vBKdj7jfDgtEo7i04Sc1jGUHWI/h3X0JrnDF3jZPlNc6gKKe6KY9yoVWAtGhOfBl2wgPtJReVTGF4EFjd3QJFWIH1DX7Wqe5JbXF2ak56QY3AP0LEZtGGNbPw4nOpE9pV82Ar/LrellacmlI6gRmp4Qw+XMBGwPvy2Jw/6HQxD8I3w8GEiQHsEYP5NPR3MRvkoBkDxvlYkiz/meFHzqLjspWUet5DSoaBY0ObBqO+FYmOArrTx8QvAG3AzQ67oiejFqFFMPDoz5FdQHH48mccXoiQkgRmRJriAah16nXuZChtOuvEMUIFgILXev2bgSvRpQbz/cZBWqrpkTXrJjqiZJ3GnupT/4Ly4bhERzAutmcQkI4PuezsE55mQLiVHOuj9SHTmnoyFwsSmVglbXCbryBRw3lsYu7KCUceELGHXTm38Iyp9AGPid4+A3ZevxY53omTk0wZQ571ePzlx2z9/3ObnLw+u31AHtvoNPkrtBZkXEyKwfoMQfvfLiHt3JQ1PsvJiLFQLMYjdrObKyiB1cL DKMPbBv3 XzANtAJVF4JGN1Wt5YHJaFu6NIWOzaXGs4rGMVYs41vFsloZtkfiXfLYnZrOgMxJFl1FjYjtK1JIEsbUz/rxxb5Z+kHzZIOFBJXekSWE2zQBHzjEn3z9ct2bN0HsG7L53aoOAF7fLQG69CNZwHOBALZoQ1WMWWAn1o9F87nYQ7RmLBjz1ds+Idw9+UMeHW/t3NOznAJnmIZ8+L5vVITzHNfecukUMsxOaZFmZzrMpHWqqOknZ6Ce+RI/7PmWVw8oxYjKt66p21UU88+CwSSK5avvCqP6V+H+x0/kpFiK40dCn+nC8bvarcV1PAHPsSL4qrCVvhux83YmnnifeFi+9Vz0OjyCrFddCkd38AgcVgyE7XiK0pcrhgReAE9+Wjv1AWz0hcwwwaxw046ebFPc/52Vxv4YHoJSo5hNyWu7gj/3XlvxeYOSM/mKHr0jfblR++UzOPbTEWwXYkBWII47wjHxc0xmnVyP8BC3XiYGDLb+gF1LkRavnQOHgITNK1e7SH1Kp0rgl/BfMbON5NYUsw7Uildi+eVG6bMH7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --y+7EcPOXsnI0Fodd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Let's add Kairui Song to the CC list. One simple thing is that we should add a READ_ONCE() to the comparison. Naresh, could you test the attached diff? I don't know that it will fix it but it's worth checking the easy stuff first. regards, dan carpenter On Wed, Oct 02, 2024 at 04:40:36PM +0530, Naresh Kamboju wrote: > The following kernel warnings have been occurring on arm64 DUT and qemu-arm64 > running Linux next-20240930, next-20241001 and next-20241002 while > booting the kernel. > > This is an intermittent warning noticed on arm64 > - Juno-r2 > - Dragonboard-410c > - Qemu-arm64 > > First seen on next-20240930 > > Good: next-20240927 > BAD: next-20240930..next-20241002 > > Since this is an intermittent problem hard to bisect. > > Reported-by: Linux Kernel Functional Testing > > Warning log: > ---------- > <4>[ 26.293906] ------------[ cut here ]------------ > <4>[ 26.295948] WARNING: CPU: 1 PID: 1 at mm/list_lru.c:77 > list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) > <4>[ 26.299608] Modules linked in: fuse drm backlight ip_tables x_tables > <4>[ 26.308212] CPU: 1 UID: 0 PID: 1 Comm: systemd Not tainted > 6.12.0-rc1-next-20241001 #1 > <4>[ 26.310552] Hardware name: linux,dummy-virt (DT) > <4>[ 26.313304] pstate: 23400009 (nzCv daif +PAN -UAO +TCO +DIT > -SSBS BTYPE=--) > <4>[ 26.315519] pc : list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) > <4>[ 26.316457] lr : list_lru_del (mm/list_lru.c:76 mm/list_lru.c:200) > <4>[ 26.317603] sp : ffff80008002b950 > <4>[ 26.319015] x29: ffff80008002b950 x28: fff00000c0540240 x27: > 0000000000000000 > <4>[ 26.321155] x26: fff00000c2dce690 x25: 8000000000000000 x24: > 0000000000000000 > <4>[ 26.322653] x23: fff00000c0c4e900 x22: fff00000c12f4478 x21: > fff00000c12f4458 > <4>[ 26.324697] x20: fff00000c1b14800 x19: fff00000c0542088 x18: > 0000000000000000 > <4>[ 26.326121] x17: 0000000000000000 x16: 0000000000000000 x15: > 0000000000000000 > <4>[ 26.327590] x14: 0000000000000000 x13: fff00000c146b940 x12: > 0000000000000005 > <4>[ 26.329087] x11: 0000000000000000 x10: 0000000000000402 x9 : > 0000000000000003 > <4>[ 26.330650] x8 : ffffffffffffffff x7 : 0000000023d53570 x6 : > 0000000023d53570 > <4>[ 26.332484] x5 : 00000000000f000c x4 : ffffc1ffc3032e20 x3 : > fff00000c2f70800 > <4>[ 26.334759] x2 : 0000000000000000 x1 : 0000000000000000 x0 : > 0000000000000001 > <4>[ 26.338095] Call trace: > <4>[ 26.339907] list_lru_del (mm/list_lru.c:212 mm/list_lru.c:200) > <4>[ 26.340990] list_lru_del_obj (mm/list_lru.c:221) > <4>[ 26.341972] d_lru_del (fs/dcache.c:463) > <4>[ 26.342794] to_shrink_list (fs/dcache.c:477 fs/dcache.c:887) > <4>[ 26.343615] select_collect (fs/dcache.c:0) > <4>[ 26.344524] d_walk (fs/dcache.c:1278) > <4>[ 26.345384] shrink_dcache_parent (include/linux/list.h:373 fs/dcache.c:1511) > <4>[ 26.346512] d_invalidate (fs/dcache.c:1617) > <4>[ 26.347451] proc_invalidate_siblings_dcache (fs/proc/inode.c:143) > <4>[ 26.348744] proc_flush_pid (fs/proc/base.c:3480) > <4>[ 26.349747] release_task (kernel/exit.c:281) > <4>[ 26.350810] wait_consider_task (kernel/exit.c:1253 kernel/exit.c:1477) > <4>[ 26.352093] __do_wait (kernel/exit.c:1617 kernel/exit.c:1651) > <4>[ 26.353151] do_wait (kernel/exit.c:1693) > <4>[ 26.353958] __arm64_sys_waitid (kernel/exit.c:1775 > kernel/exit.c:1788 kernel/exit.c:1783 kernel/exit.c:1783) > <4>[ 26.359772] invoke_syscall (arch/arm64/kernel/syscall.c:50) > <4>[ 26.360706] el0_svc_common (include/linux/thread_info.h:127 > arch/arm64/kernel/syscall.c:140) > <4>[ 26.361477] do_el0_svc (arch/arm64/kernel/syscall.c:152) > <4>[ 26.362218] el0_svc (arch/arm64/kernel/entry-common.c:165 > arch/arm64/kernel/entry-common.c:178 > arch/arm64/kernel/entry-common.c:713) > <4>[ 26.363014] el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:765) > <4>[ 26.364138] el0t_64_sync (arch/arm64/kernel/entry.S:598) > <4>[ 26.365321] ---[ end trace 0000000000000000 ]--- > > boot Log links, > -------- > - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20241001/testrun/25235075/suite/log-parser-boot/test/check-kernel-exception-warning-cpu-pid-at-mmlist_lruc-list_lru_del/log > - https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/tests/2mp2m5m4PnjJgdix32h7pIGe63Y/logs?format=html > > Test results history: > ---------- > - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20241002/testrun/25242215/suite/log-parser-boot/test/check-kernel-exception-warning-cpu-pid-at-mmlist_lruc-list_lru_del/history/ > > metadata: > ---- > git describe: next-20241001 > git repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next > git sha: 77df9e4bb2224d8ffbddec04c333a9d7965dad6c > kernel config: > - https://storage.tuxsuite.com/public/linaro/lkft/builds/2mp2jhmSKhlF6c0x1SBsJFyBbTq/config > build url: https://storage.tuxsuite.com/public/linaro/lkft/builds/2mp2jhmSKhlF6c0x1SBsJFyBbTq/ > toolchain: clang-19 and gcc-13 > > Steps to reproduce: > --------- > - https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/tests/2mp2m5m4PnjJgdix32h7pIGe63Y/reproducer > - https://tuxapi.tuxsuite.com/v1/groups/linaro/projects/lkft/tests/2mp2m5m4PnjJgdix32h7pIGe63Y/tux_plan > > -- > Linaro LKFT > https://lkft.linaro.org --y+7EcPOXsnI0Fodd Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff diff --git a/mm/list_lru.c b/mm/list_lru.c index 79c2d21504a2..a9a8b02e056a 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -74,7 +74,7 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, else spin_lock(&l->lock); if (likely(READ_ONCE(l->nr_items) != LONG_MIN)) { - WARN_ON(l->nr_items < 0); + WARN_ON(READ_ONCE(l->nr_items) < 0); rcu_read_unlock(); return l; } --y+7EcPOXsnI0Fodd--