From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A064C77B72 for ; Sat, 15 Apr 2023 00:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD698900008; Fri, 14 Apr 2023 20:27:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B86F2900002; Fri, 14 Apr 2023 20:27:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A74E5900008; Fri, 14 Apr 2023 20:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C1F2900002 for ; Fri, 14 Apr 2023 20:27:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50B75A03E7 for ; Sat, 15 Apr 2023 00:27:38 +0000 (UTC) X-FDA: 80681736996.11.BEE6458 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf23.hostedemail.com (Postfix) with ESMTP id BA53014000F for ; Sat, 15 Apr 2023 00:27:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681518456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MQX/NFa0vuBqensH0VMNth+S72t6TIFu+0q1mZ4kLjc=; b=FapKACbvGO+u2zXliQaabQj8DOphizrZPyy32EU9sBdpG9tDJ85VPmgSoyUcWRViS1UdIz Y9gskFdHZE5AicWSE3IzKvnfwiKfpOQy4nS2zNiyoQAMbvrINtqljCAmIsgR80nGCUgF+s s6MKcKC0Nsmhxyfoglsn3T4GjD39dqs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681518456; a=rsa-sha256; cv=none; b=i3pG4qIK3eajAugDPTIAHymsKiN8Hw3zWFMETUX+WZD5JLrNDprzsbPEVe4OTjMxUCq+W3 PBqXoT4wAuuujk2VN0hh+3QImdM3VB4SBzkYcjpKY2iQpB0pMtzXGv8hsrlhOAuYy5rnwk 1JJ7e5tH+zfOgJodpstXvkSMWub5vQs= Received: from fsav412.sakura.ne.jp (fsav412.sakura.ne.jp [133.242.250.111]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 33F0Q4r1034541; Sat, 15 Apr 2023 09:26:04 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav412.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav412.sakura.ne.jp); Sat, 15 Apr 2023 09:26:04 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav412.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 33F0Pqw2034458 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Sat, 15 Apr 2023 09:26:03 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Sat, 15 Apr 2023 09:25:51 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5a4cf1ebf1c6cdfabbf2f5209facb0180dd20006.1681508038.git.lstoakes@gmail.com> From: Tetsuo Handa In-Reply-To: <5a4cf1ebf1c6cdfabbf2f5209facb0180dd20006.1681508038.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: od3tqhks6yk3kmf4939efgaprmg1bdg7 X-Rspamd-Queue-Id: BA53014000F X-HE-Tag: 1681518455-41391 X-HE-Meta: U2FsdGVkX19Q62PeNpMCwqSLwBEK+5uFrGZIHGPoahzcj+GW0c0V0c66fiQrR4rjLJCfYQlGjjqQ5osaWi+cH46itmv6/fLIhOBUw4c7w1oz8vsRHtI7TJrcvPKGwEIyiTgS6ezYweyYmpczd9sb61UC4KgaGwlO1I6DvzeFBDafHUQcvpY3piWIACHbpa6n7jougKRwZpP2eegPsqIgf4hTtGAT9MZ01sQW+9IjvMndYkLr1af0Sq5VjVhaWDEOdVJGXPz1GG4e2LdiKC2lwB/+bSbo9gx1Op3IuJGxJV/R6M7E6MsYoxJQoCxv/aiNtlm5HIa0uivT3EFYHpRJwWZWXIH6bNgYv57bPK2+m1hGiQXqt4V5E1H3EF4dR8L412cLmvVYI+r0gzzRth9wPi9vMnTTcZhlEB8jh1j98OEGb4nkMLNoKaOxlp0ZmCvHnkO6DEnmH6Nul1RHbW5s3WkFzhQIHGNxHYw80CX+7YkzcAjurQtLTllJlMgF+YGB8170gRuF09WVRPu1ELuLRwCGq7yn3y2YnOadB/f6qboQxmuVYReDMVac9FF5nkVUvbqnK8M1iIhINkAZL/jFFd6AXI+CMcx0Hk2A82+/v0kD7kmZ6O4HfNmQS8VI/8TzUa/yNILIZ0iG2xQ+i7vrIE+IXnkvHUFypeijw4h/30LsN2Nqe+yW+ABasbaF7D7q4jmjBxJiVMXBArn47a4PYTrcFHF7oZWPWHtRtzfmgsjD4GHEg9q9s3MUayf1NriAkc2Helt8p5T6R38Oww2m67krCDEFZ66HwL4bNJcuv16wLA0t06so28nEnmETyxPb4EBEWYXqT3o5hTb2J/gvcj5PLCe0uGzCUD8MwQy0V8QwIbC3TD4CFymicFlR/wkOgN21mMWKFLiFGfjmfShS0L1dX3lvk4j4SmrFfb3x6KjzkoKoF+fE30Xr+ePgmRjoASEhDFwIPIMDi/y0FEz p3+QZHdf E6CQt6gBBm0NVnKgOAtAQIXOymg5rUP/146jYRdZKCDbDGiS6e1FHxuCdiZtgPA49XFGpv9sQIoV2G3hjQZrDtqGMWCe1r9TwA/IzpIAvGg8aEOpqHYbzFgfGtb83zqAzf/rZzoG5U28/hTMa1jtLbKDwNd+PqXi+xenMCQPXEMTVUeJ0JdcUeR6i3gUjf1giqIqTkDSOr1k9lce13TGTwX23+9mtJuuIQRCkZKKmM72xMUPXpPoc9P6ZfJ0YlNn3g4P/zqtOqH45a+yYAOsd/rvx0b57/pWJZnhEc4i76nxXKq4VomqaHW4VVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/04/15 8:27, Lorenzo Stoakes wrote: > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index f5bcb0dc6267..74d8d4007dec 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -437,8 +437,9 @@ static int __access_remote_tags(struct mm_struct *mm, unsigned long addr, > struct page *page = NULL; > > ret = get_user_pages_remote(mm, addr, 1, gup_flags, &page, > - &vma, NULL); > - if (ret <= 0) > + NULL); > + vma = vma_lookup(mm, addr); > + if (ret <= 0 || !vma) > break; This conversion looks wrong. When get_user_pages_remote(&page) returned > 0, put_page(page) is needed even if vma_lookup() returned NULL, isn't it?