From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13262C77B71 for ; Sat, 15 Apr 2023 08:11:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CD866B0072; Sat, 15 Apr 2023 04:11:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77E0D6B0075; Sat, 15 Apr 2023 04:11:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645C66B0078; Sat, 15 Apr 2023 04:11:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 55DB56B0072 for ; Sat, 15 Apr 2023 04:11:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01062120184 for ; Sat, 15 Apr 2023 08:11:25 +0000 (UTC) X-FDA: 80682905772.27.0C14CB2 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 132531C000E for ; Sat, 15 Apr 2023 08:11:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=quL1RzOY; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681546284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S22VGJ0XRDXPgrrj923zdow2tJJ05sGU7B7/V2tOQBg=; b=CgbOGqosGFlusgCJJ8UVJUwhBeTPITOyyVDGHO5+i+PuEaKblDm1Gm8oycGZ1ln9HN/eja hPEiScfP+Qj3VoLbygzdZvy47kaxIVKg4RWfBPSepHPe5TOwq6GrIoaYj2dwestrr8KNh1 vlGQaaTvs7fL9ZfXBv3pcQixYcdC6lY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=quL1RzOY; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681546284; a=rsa-sha256; cv=none; b=xXl2U3D3t3eLVyE/3t8WZaRpVYHBPwLp2YMV0w4A7u0XOCSob+cTEsQTT02RU7xmT4LhbK tpw5iV5pAX30PGArd8jQfZXs12edDimdx/uNV16RLx9GJD4dld6CUmnsL7C6f37pfdHATA pTDpks54xBPFZxxK56DPZ/B/FgwfR2g= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-2efae164cacso274287f8f.0 for ; Sat, 15 Apr 2023 01:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681546282; x=1684138282; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S22VGJ0XRDXPgrrj923zdow2tJJ05sGU7B7/V2tOQBg=; b=quL1RzOYTYd3ZlRj1et56cpDCoNofX4HxgFTt3/WOt0D+jF3i1YiF7oHmiEcfv6J+r f4VflBM5rK1rhvRjz2sUYimHnzLgK25ZMox99kXvJgv3ICevBuOT+Sp2ktP9wzUTXCUR KqQQaJB12U/QKq8iExb3Yq3e3p6hBTtJFAbwi/z03DNGW49cliXilt7Vg9/3UhtvQRJ3 VrWC1V4K+egqoqSn9XYBk/HL0sTfVba+CVPW/F7IL1Yx4qR1mdVETHChAyDGImGmEZLn VTSMFF+BeS7Ah6OoUS0kWVxwIWLjRrA2ruBxWrUkipgcQ5vtJKVL33ojE6RA94BpFhFH qK3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681546282; x=1684138282; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S22VGJ0XRDXPgrrj923zdow2tJJ05sGU7B7/V2tOQBg=; b=DpcixgiXynzV59yxSdyOjION3LpqIaJncsP5cnZf/OGKOkp4nFQHtcA6CobrofS0g3 jY0GsnBvxt5PdfFjE6DvtCVY9P+qJD9FPOD9hJ0yV0roy6fGQ0pRNLsaiZyYJgj+3j54 wWeRQu69UqaunQs4IrIPePCpN0ZkXjn8jQ1Dlm/tgpNSQXfJNTyxvbfwrJ2AH/D/UNPN eUOogmvIAJSX13ZK7Yo02aPImiO72Xfbk5y3U7tnQG/oTx0jP8Ii1cTV/mmwYqSu073r UNbKwvrqm0jzcP6TUmAxNrY8yLy2mSRhvi7hJ5bngI7TbQmSmL1/FhrhQ+NG4MHZ9yUa m1tQ== X-Gm-Message-State: AAQBX9c7hmPkVNJKwDsgMtOOJrOorA4nEvjjKOfwQg9533xQrufJ5IVV ZjDQ2qx/Wlaq61Pr7l4804Y= X-Google-Smtp-Source: AKy350ZFUOV3lb/N3pwovfqQKqxVveAM/jucyDTRW7rG76eyJpc8VgDXj2V71JE5in0yCsfw4yn+hA== X-Received: by 2002:adf:e38d:0:b0:2f5:953a:4f59 with SMTP id e13-20020adfe38d000000b002f5953a4f59mr1353918wrm.5.1681546282383; Sat, 15 Apr 2023 01:11:22 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id i4-20020a5d55c4000000b002f74578f494sm2834402wrw.41.2023.04.15.01.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 01:11:21 -0700 (PDT) Date: Sat, 15 Apr 2023 09:11:20 +0100 From: Lorenzo Stoakes To: Tetsuo Handa Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Message-ID: References: <5a4cf1ebf1c6cdfabbf2f5209facb0180dd20006.1681508038.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 132531C000E X-Rspam-User: X-Stat-Signature: 3ogknwitr6mhk9x8p1gardaond1dg9at X-HE-Tag: 1681546283-100105 X-HE-Meta: U2FsdGVkX1+fgHsA2thgWHb7Jo/Nh8C+xTW1gcOmshLN3OKSpMd1mCevrvsNuM4HqyW5Xb3mpZaH+FA5SD6lQDT60NYF1g1Aiy5OG9bd050tXToqZsFSsT8I1mLBWr3R5ir9CN6bDs5qB6dsiVeCL15oI8A3/q6kCVVejKO0P8qdJdGun2WRY6AYXdH55p2yCdHCGnXJB+G9fYoahpkFlRPVwHA0b/xag5aUBIEWcxNU3xSbdwCv2LSeEsF9y01KO5sO0ebSPRIrOlzdPiyZajOliLnI/hcW4QSGzwAnuOQmzx/nec5Wp1yjrnv5d6F8Vg8wIMkUSON+vKYs+XmWfXuD3z75XmEo3RkIhDNNqMfGbd+CymsQm8IqjdIfGhZZkO66ANMxFqKWTzhlUMwwoTwnuFfoIozg4vmHR/yK2PAzizjtD+gx7YYoT7rcJ+3YbkiYSi2ChWJVddoL9DUdnY98CyWQ3BNGEpqHpkaE2Z9xtZs+I+BPpmz7KabSGW3k7F7EafIzbcJefwdfU7L7GrhaF4i5rwMMnkP6XLjyiMmMJnaq6k2zveK8wamCXWfFmdyyzktUfSrii7f2lQbBBH3i/8UuOjhNEbFEiPi/Xg9sJcA6I4yvNhHgu6oqYqa5uODc7yWCsPEfxc5fE8P/yGiwkKPiJupOtRjkv/UXmggkfNwVUxaYa6adhoHQevf769ZEEd4MWENykWE50KWNxrIr0DGs2Oem/Dz6pTuVk6GIlkVZ4sq0StzqLSsnT67JIuD5G97SsGVKWtz27bGWxosXD9ACZw67PY7hDq/fhp/P3G3mle5QZqqFfhV0T/r5+ysAqPjtq9QDBZgOhVGF9wVJ9f0F7X/0RZA/tGaP71Mar/kfD7KCuK13T7Q+mO0WxntwgnF5hmz4eGo1e2p/ZFZSQFl6cRI97te4Epa8uXoMUaqNkBpQMAPUoiUBpGmOOH22vkODXWb97aNLyMW 2aN6r6FP jtngIL8iin+qOyxH5BPYQCRdRXv2DaHydwFMFbMOuWtaquPaMBj3qtlAcxSMQfwubXq2R0e0sFjnGPH2W81Rcow/I2QPrMqXvrvmV2oIyvQwuOXYBe381fPbwHaT57RQoLaco5/QuiprIEGIUBi9r9LgtGucPv9EpfKA9/EjfthVhnKpZO1SyVet2pkmE06MoUP/KT7ROmYezsTH6FkgFTRyXCazrR2sL5xbRC5DXwO8Q1jdSDWqBiwrwrXfBj7ZRennIju2tr1Bn3Ymrx3gO6LxRyamvQj2k6wZyXW3zlHHz/4E1MqSFrvcFFWFPDyDiri+KfvWkMdA37xeNgcMYQoIqYJ8QfrEI42IrwTWfT5F2gBCDbRrFCYJPh1D6APYDcbGBvYnBuTA4PMsvIZfXN3UrpTBqwUhQv00djqUw+1/NrTMXDQVFTd4i1FEJFd4xfZnGu+kxwM6tWX0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 15, 2023 at 09:25:51AM +0900, Tetsuo Handa wrote: > On 2023/04/15 8:27, Lorenzo Stoakes wrote: > > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > > index f5bcb0dc6267..74d8d4007dec 100644 > > --- a/arch/arm64/kernel/mte.c > > +++ b/arch/arm64/kernel/mte.c > > @@ -437,8 +437,9 @@ static int __access_remote_tags(struct mm_struct *mm, unsigned long addr, > > struct page *page = NULL; > > > > ret = get_user_pages_remote(mm, addr, 1, gup_flags, &page, > > - &vma, NULL); > > - if (ret <= 0) > > + NULL); > > + vma = vma_lookup(mm, addr); > > + if (ret <= 0 || !vma) > > break; > > This conversion looks wrong. When get_user_pages_remote(&page) returned > 0, > put_page(page) is needed even if vma_lookup() returned NULL, isn't it? > You're right, though actually it's not possible for ret > 0 and vma != NULL because the GUP code requires the VMA to exist for it to have returned > 0. I was trying to be too cute here I think, actually we only want to be doing that lookup if the GUP succeeded in any case. Let me respin with a fix for this.