From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFED0CAC582 for ; Fri, 12 Sep 2025 08:24:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E5978E000F; Fri, 12 Sep 2025 04:24:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BE758E0001; Fri, 12 Sep 2025 04:24:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AC1B8E000F; Fri, 12 Sep 2025 04:24:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EBB908E0001 for ; Fri, 12 Sep 2025 04:24:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 85CE8C0733 for ; Fri, 12 Sep 2025 08:24:29 +0000 (UTC) X-FDA: 83879911458.12.C3BF521 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 34E7DA000D for ; Fri, 12 Sep 2025 08:24:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FdTfIQ1+; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757665467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OERP3s+HsoQqm9aRx8/J4R+MRYy1jJD/+709XoPt+H0=; b=2xP0CEZjnwkUXzi0jjRrqPUZLqumrzxRJZiZoWbaLuKtnizIktp2WD7luhKXEFVHWuuJoC weHw9QlQxNMIJ79g7aKgdvINyFFLvosd82gV8Yi1OVJp6BOzGlIGUqTjXzOL9heDHB0DyW sfqQQjqb8sqVVVEvDLjqhl0VpjaR1+I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757665467; a=rsa-sha256; cv=none; b=T7aJS/g0vA9KuuhDSqdum6JEoG1rct+g+KA2pLikHbFY2BydgoOPNQqwJrZXmDTmoj0Tm0 6hpvG7lrdcdLdA1G1jfJlxuGQbysvXsv2OEm5LEmz0BINAmdiY0BpQ6Vqr2nHVymei2CAY aSlmPfLX5jchAnVuguN/RkOt3LQF50A= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FdTfIQ1+; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757665466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OERP3s+HsoQqm9aRx8/J4R+MRYy1jJD/+709XoPt+H0=; b=FdTfIQ1+6Ob3H1Yl3yDg7XaVeI79mGg+jJHva5GZzRYqJq21vfTNv/6dSrn0nGIvQdNEJE eg6dOqAS2SI/y+3hYjDfQjrnE8NWwkRUooK8C5JYtP1BG3JBm43dhCbjytPzUipeEaBbYx 9zqWlBzoCsXYFVcp2Nv/ZPg7SgNV2gU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-EDjx4837P2qdcNOSwNwtDQ-1; Fri, 12 Sep 2025 04:24:25 -0400 X-MC-Unique: EDjx4837P2qdcNOSwNwtDQ-1 X-Mimecast-MFC-AGG-ID: EDjx4837P2qdcNOSwNwtDQ_1757665464 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3e751508f3aso1135875f8f.0 for ; Fri, 12 Sep 2025 01:24:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757665464; x=1758270264; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OERP3s+HsoQqm9aRx8/J4R+MRYy1jJD/+709XoPt+H0=; b=UpbvZFttLBsfAvq4KQ7q0V0TzSex3dfS8Z4QbZPstAoM9dA071PbNGcqLGM5JkTQMz geB0SAwSh7f2jEHR7ooNq9LGW4/U4solnKycHw7Oe/i/n/oKAnaiEMUIyCDspozKyo0l JYCZ4b9S145pEFSl03u9Rt7PxMhrIHfOEZthohuWgVLNwayCEL7B3vCARyRsYVD3uOlq JUS2gQUMGvv9LhvFnXr+/5BiZVu8spTpuR481wDzrmQRhmFIm3VJjGBkmuXU7WnOEPxL lZgxDaeMXUy7k7lLVrVcPkMrgMse2lUByndncd0jWcUHDt/28CEcjooLk2eVOE0YZrQ3 9qtg== X-Forwarded-Encrypted: i=1; AJvYcCWZyCqR6okJAGPN6avVVFBXl6GVWCFvCyhOqZ1fxpewUHD7olIg7HARP8SS5z7mStv6nyF6PQOpUA==@kvack.org X-Gm-Message-State: AOJu0Yw2d1MyLntYsxb2O4RXXe5SUSlIjmooJy/ZS43E3xktZWB5U7Fq 1XeBLYE/ggnoFouElTR2cBWIYqcrERx5iQg0PUMgz9vdjCbQRVCEfaMZF3qsgFsoYzThVCFFdV1 /cPHb+AiRhwHldjaEJn/stbj0KcxWN782oK1SfOPh28ULSm8QulDv X-Gm-Gg: ASbGncuOgPKT32I9i8om0ikGcoWAD+DnCIxgOhWgdPLL9We68WpTPf1mWtie2Oghmbf DRvz7oCyaE9wirmp/F2fnR6oBm2eBzeN9H1E8KX0tvqlQYZDXZlNXoDSq/ngd+IcAxPwVOdf9Eo H3mxFscSWKe+HWHcu4Ds9MF1booehDYaaXCiWKF2u3QqoaR3IplvXvg4yra+Qa08y+x0QTG3FQ5 9/Davu0/6/2Sbi3+kO/Syg94cNC4GuFD8abIiynl1sKWuZ8uS+du82YhldG8ftNPKbdgW7vf/t4 PYeKn7x7rLqwULcWb+opVDkgmQcAsS8l1OneKZBpErNmMtzn5aFrB/egim6Xa7rb6ulSuaGVlmk ovCutONurwd5Lg0okSMh0Nipfqd2MRtlhinO7cav2LR6+dQZlWGR8SKNpZuuNIeumuSU= X-Received: by 2002:a05:6000:2f86:b0:3e7:621f:3c with SMTP id ffacd0b85a97d-3e765782ef0mr1756152f8f.2.1757665464235; Fri, 12 Sep 2025 01:24:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1YaEccAO71A8DCQ7XHaGqymyxjjI77x/k2QkuVBPeOIbCNkG9xCJ6OZqQ1xCk1Xdximme1g== X-Received: by 2002:a05:6000:2f86:b0:3e7:621f:3c with SMTP id ffacd0b85a97d-3e765782ef0mr1755940f8f.2.1757665459770; Fri, 12 Sep 2025 01:24:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7607cd0a7sm5526467f8f.39.2025.09.12.01.24.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 01:24:19 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 10:24:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: vmscan: remove folio_test_private() check in pageout() To: Baolin Wang , akpm@linux-foundation.org, hannes@cmpxchg.org Cc: mhocko@kernel.org, zhengqi.arch@bytedance.com, shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com, hughd@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: t_nNPqepjZbK4G9TDYVs9lTT8M5ZK1RSe3omudieIj0_1757665464 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 34E7DA000D X-Stat-Signature: rpbaqsudgd5z7ab3647hzgc3bazyunh5 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1757665467-438573 X-HE-Meta: U2FsdGVkX1+iIMvygUSN+E53OX+t/BIoBZ9ntmj0P7aY5hR1rYkE3N8DZS1/76/TX767xmnLs/aqnCUs02WKPpvpVJCJQ2mDcWhSgd+Tx4soMvCSAJnf0YSg4TxtB5BTY1E0KyvnfnWYehRdw+kEh5STsOOjS6a+LupyGbMjO7ScKpB28ylemT3eR/WZPE3k/jeC6ZVZXkryGkbiCPUuPAyO53h2qR5ElUAd9dHGh01oisVifOGBMsGZlZ0XjTcGo/YRu6WT9vBG2i+sirNwXit65kNLZICIwd1Ed2Stz8gEXyVv+emMGv+kR83ONHFN/XBqekJfWPglragKoELb4fuby1idnaK9apN9fK1AVK4f+i2x0A7657E4H9TaGxA8ocZbg+QzPRm/Iw1oXJVDc/+44cESAccD92pdg/O2FxvnlGPkAAK8V7Hxy+qJfXjECXa/5tb7ecmSNy+Rhpac93B9w3qtyTu4dRlv88jFpDpppUpdaoV6tgdzj+gwh3kJv/7agZi7t/Wi6rcB9Hk+s4pFEW1varQ5CSzS5tAQaQfK2pQztpyeyZQ58yvkxtVE3zKhJgwUogUjcISTD9Rz/JcGhaDk0QoIvGropDv5n50obx086lwCJ6HWyI3sDXP9Aqh4I5u4xfpBmHBKDMYWF8Cmb+n071X0tGf9oE0z3E2XtYKJG7p5E2LBR7BNpVUDgqHA1GKhXomCjsaBK7iYBxnDhTrBwSroWYTmiirlmt7WNEVGBwQKDUXjG46IZprCo1MeVJ/mBewpCq4/4SEQwM7+9SdILRNFjFIR+htr14oEiqBWqV1oWN5/CKL/btppBSXMAFkegp4N18UZ/8yVLSJR7liWXHeLmNryVFjnpMOMEF3+A6hXodnzkS6x60DHFvRkeUpWVJbRftVM3ZVyXe5/bO0hg9pBIYyxhSAAo12yeANrzu4eHDkj0iV2MwVhkIvbD9atMI774bnMeOQ +w8g2ljl 8QWZkFQkyoiztAG3zU6nqbBNvHdwDaQJBMerOF3BuyFQBADj0a6ltkG9E0mGEk1GkdzAHmn7+Tl0+5oRNJM9GQ7e5MA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.09.25 05:45, Baolin Wang wrote: > Currently, we no longer attempt to write back filesystem folios in pageout(), > and only tmpfs/shmem folios and anonymous swapcache folios can be written back. Can you point me at the code where that is fenced off? I can spot a folio_is_file_lru() check before we call it, but the description tells me that there are indeed ways we could still pass that check for file-lru folios if we are kswapd. > Moreover, tmpfs/shmem and swapcache folios do not use the PG_private flag, > which means no fs-private private data is used. Therefore, we can remove the > redundant folio_test_private() checks and related buffer_head release logic. If that's indeed the case, do we still need the folio_test_private() check in is_page_cache_freeable()? > > Signed-off-by: Baolin Wang > --- > mm/vmscan.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f1fc36729ddd..8056fccb9cc4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -697,22 +697,8 @@ static pageout_t pageout(struct folio *folio, struct address_space *mapping, > * swap_backing_dev_info is bust: it doesn't reflect the > * congestion state of the swapdevs. Easy to fix, if needed. > */ > - if (!is_page_cache_freeable(folio)) > + if (!is_page_cache_freeable(folio) || !mapping) > return PAGE_KEEP; > - if (!mapping) { > - /* > - * Some data journaling orphaned folios can have > - * folio->mapping == NULL while being dirty with clean buffers. > - */ > - if (folio_test_private(folio)) { > - if (try_to_free_buffers(folio)) { > - folio_clear_dirty(folio); > - pr_info("%s: orphaned folio\n", __func__); > - return PAGE_CLEAN; > - } > - } > - return PAGE_KEEP; > - } > > if (!shmem_mapping(mapping) && !folio_test_anon(folio)) > return PAGE_ACTIVATE; -- Cheers David / dhildenb