From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2869D0C5EB for ; Fri, 25 Oct 2024 08:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ECCC6B008A; Fri, 25 Oct 2024 04:51:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59C836B008C; Fri, 25 Oct 2024 04:51:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 416116B0092; Fri, 25 Oct 2024 04:51:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 24DAB6B008A for ; Fri, 25 Oct 2024 04:51:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C09B516061F for ; Fri, 25 Oct 2024 08:51:05 +0000 (UTC) X-FDA: 82711505100.25.98D3523 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id E135514000D for ; Fri, 25 Oct 2024 08:51:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DVTxLZms; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xTD8GKJk; spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729846207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qTyzXLVp3BlWDh2fR5XXty9ho7+IDu3/NQFZ3sCjmbw=; b=rlQIdeR3p9lFL4QMz+4MrDHi+R3dE+490h2uKL3w7ONLJn9WGRp3GqlCOFL8ZDUhWtbk6X rU/eQectGsRTUUshEN2hSwBqa9UF9va7j67OEZYlvI3+2R6t/Mvi2jUASjqEWZqMSbcxRQ XUkLiF2s7C/Ngyae3lXlFeTCemv3iHc= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DVTxLZms; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xTD8GKJk; spf=pass (imf26.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729846207; a=rsa-sha256; cv=pass; b=ICMvgu2468L6B2CbyRLwJamLO2gKOZQOA+S+ucgFvpxAbNdI2skJmhO4IM8JWAzMsohTwZ aEQGvF62h7VbHLDYjni1cjJdjKKlNtw2TyusE0MK8qDvZ1ojGlr1u66riCWRqxyyVhg7Pk D7/eR34Ql+McMqozuqlYzO44rRYNhaM= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P8BaRC014268; Fri, 25 Oct 2024 08:51:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=qTyzXLVp3BlWDh2fR5 XXty9ho7+IDu3/NQFZ3sCjmbw=; b=DVTxLZmsUvkKvtEUmvHISRliDdF9F6EWfe P5/Q8t8bnWakRV2E6ET18/uTRPF3f7mJhV25KX8hUdOlBpx+u5hbR+YE3SA8TNfm 4PtPLXaAVTTk9s6cCHLYmEjkyQIr3vjrj0OwTMCXkZ1JZUHugNPyyCbZHhCSrKxA DDhV1KdiOXLGqGcBbRjvrf/J0B4CZQiSMhCZO9jN7Cg0iF3MPvy0+aLy3RBz7xoA BQ2uISiizyNc6vjlCZzZAHptYibKMbzCVMrQq2PEYfnP75sae/O3SwPaQavDdDLR H6u8SiUekgVUTucy68efPOJffcdtYY/3ElUcPqp1L6kDULXCH7Ww== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c55emcvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:51:20 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P70nTI025346; Fri, 25 Oct 2024 08:51:19 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2044.outbound.protection.outlook.com [104.47.55.44]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emhc1vbp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:51:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NpFGfo6S7xyDPVLBb8k0RrBgRb144162G+YnL89UTTvAqja+alF/3ewG+8UNo/e+YehzeADMmneOeGH3h/qEG/BrDU4/4BXKl5ALErtOgZ0CxAeX1Sjblwk+xa8Wv1+DL/1msTF/dqyBvOrsg1U6sU9Bo6gQxZnWbTA/R07AysGQQN+wgckJxtHkfcvKZE3T+koliRm8NOZfU4u/uFmF3mLxOKSg81mnAQ+4IjUC5VRcGfEZAUmIO1pGo1yn76JPWKzQSuhC5qWtaZ9r4Oq2HOh7p9BKOpCnoYSlmj0x2xW3XIJfxKm8Mk4dFWXD9YIgXxflHsbgidcmzSH3MbGrtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTyzXLVp3BlWDh2fR5XXty9ho7+IDu3/NQFZ3sCjmbw=; b=WnIhZjEmHI1z5jQqzQta2OYPVG2GnnVjRfJp8xjaznOdhDHXtHRWYEhlLKdc2ye+jQOi+DhyKH7SSlxIi4pOYjuNTLRzpMyDvumRCD6AI97c7a+DGdQAz4t548GTfK3TGsA55msMOYxDKTAgBzOQHau+igIztaD0ej1MuBAPoRrDq8DCLTrmHErtzbm+kMFkJ11uhgYsdk9qaDX8QDOAzZUKVim9Vv473LfN/ghvZS2mpQKIoRoU/TekBgEa74UC0Xpb/Yh1FCd6kCPuQQzG579UjvjJrzxD8BqbNU59zYhAk5p7oz1ZurnBBW/DPUF8SajVTdVoJQ4I2lB1ZjK+QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTyzXLVp3BlWDh2fR5XXty9ho7+IDu3/NQFZ3sCjmbw=; b=xTD8GKJkXRJnqCjUd96DHq9ERwEmxwY7+Qh3NslXtHA+RvvLM2f2r1KjAwrNxTjklVQe6bkwjDJ2EL6n5n9ajQGKoXZyIYKFjaxgP6ctPjUk7YYiodNoB3d9rOVTTiBBeyDncfcq0/SgeAYUOhhh9gqWUcic5DRehcaVIA9rIFc= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CH2PR10MB4214.namprd10.prod.outlook.com (2603:10b6:610:a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.23; Fri, 25 Oct 2024 08:51:17 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 08:51:16 +0000 Date: Fri, 25 Oct 2024 09:51:12 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> <20241025084919.m7etchfw4riavxmj@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025084919.m7etchfw4riavxmj@master> X-ClientProxiedBy: LNXP123CA0016.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::28) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CH2PR10MB4214:EE_ X-MS-Office365-Filtering-Correlation-Id: 166f8b08-14ac-4c8a-756a-08dcf4d22fe7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aTkg6RYMAx2PzGrdKE7o+XEB3BENDg6IrQdfpAEq9lrQUGwzH61mDwq3diBE?= =?us-ascii?Q?3ZErc3U/i7hwVCLZpeOxVaTtmvIhnk0s7KfO9HtYimv8w1/sGEkuEu8pkH7s?= =?us-ascii?Q?3WsdHn9tZdbcKGmWJZhW02eBZQ3nDUDNT5zysBkrQJAonVNGQKC+HtSFFqS2?= =?us-ascii?Q?tW35WxPdT5Qof0RHfnBq8KG1V/JszSbvZSJXZTAT4f/0N5EVq8aQpTmoO2Z2?= =?us-ascii?Q?axCvjYisSd6qvf8weZTT/8vzlRcFMr5Qln6dGOIeDyIjsge3i54C7oCyEiaZ?= =?us-ascii?Q?oXKXxR79G/EQS9LCs/uWLXAIFoXysEEUyW/I7pB/qKFC4mKRbkgi9d+i+Ei/?= =?us-ascii?Q?CHCx792maKXFvG4RnabPLQOi13Kr3C3Vet+wprTEWp4nvbs4mlZ7F3BBctRD?= =?us-ascii?Q?FzPQ2ahsgJlAeZ1U1srdPrDpf0pQgj39/Db8h04eHjyAnqCgNUiNhGbqAg+r?= =?us-ascii?Q?/ABk2DNA6NpoKqtJdvNpa5TA3j9kKRkplWX0oBL7v+Ek/jYtuuZxX06BKRvM?= =?us-ascii?Q?uOBV3yoFyFFpIsiOvUr3wcZFKk9eK/9mNhTBmp2yyzQtfTbfKGZwcBJ5b5qc?= =?us-ascii?Q?CiXffsMPbINZ0n3aFaSUfYQusNFuA7k/m8D1zG1rq8UEay0TQY92aBrxVr5W?= =?us-ascii?Q?a57D3sirflp68cR04TgxXM1wwOkcmIa0YRinGGlItqZAx+TuzX+ELB5sVRfl?= =?us-ascii?Q?dmSYEKDiyLEc/i0oLEZe7MBDAWGOiS+tvnsdgs2x9HEDYe/6KiEpW3wi3Jrs?= =?us-ascii?Q?l6HHbCn9U9XdI7G+P7wJq3Z//aQp83q3g4L1VK2Tyzo/k9nxX/FG62I1tza0?= =?us-ascii?Q?3V20dzPrATi9KdV8K7/NrhCwKrhmGh0sRieaUGmDnrltUfQzM7VacB0ywBuA?= =?us-ascii?Q?LSzaPmX3dlC+Og4PGIk993x/U4hGtgmEm5F4+trsLDS062thROcu021IOGLj?= =?us-ascii?Q?DDiW9uGjWtHKGcdnC/hfTw50Ppy20G3+dgXdgTFaNesJxU+P2ros7dxN2jg1?= =?us-ascii?Q?Z41ily/qB/qTDqiOI0FR9xFeE4/YsP64VdnUYzmxJS+YtsDj71jyDLz/uwMw?= =?us-ascii?Q?FLF7uets2padKb8gTS6+SH1qVldwPdBysvURtLBpL1ad2lYkZDTZH/IApicX?= =?us-ascii?Q?M+Z/0o0pWic3Zyx1YqlyYqrW6/RZZtlR6YOlCfBov9ELJREYZ3KU4c/ZGXlw?= =?us-ascii?Q?7uIg4ObpWbyGe9QcUfyHAcLnaV01YSzmQ7QomUGClRQYQPYcPVz7jtreKN6h?= =?us-ascii?Q?xaM+1yEX2ITM3z8Zu6lrfR+YOBLyVlXhl1iJZoeB7EIBHC/2AGXsPeoQsdDY?= =?us-ascii?Q?yl+3pW08SjpQgcn5uCURct6l?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zutumDKXuFQWutYQamwfHidVPCLVruM+hGc7HfZY3N/QnpSmfwGrr26cqHpr?= =?us-ascii?Q?/e4C1N3cdHxGWGW2HsG6jRhMJK2/MJUGh1lGFaNlLs1XuDqn3BADWJYPB2l1?= =?us-ascii?Q?JAQZVZGl8LpQINLWpm+CL2ZqS+9DXA1UMGerVz/3XXc8tEWXCixxaUUDizZK?= =?us-ascii?Q?MiRPB4rx+haTVL+ppDkR30Li4bdI7FziYACzVwXpMEpkZm0MGgwfehHaL1zz?= =?us-ascii?Q?s0QQAO54fA/FAZHn4iyErqjTiy2bqwjl0sIWekUG+NmQdwQ9Q209k1j2oBLv?= =?us-ascii?Q?gM0G5e9tOl2s7OTvV6cBVPhNnDCbDitoW3Fxn0RDYUyH5T7axAAnN9XXrs0V?= =?us-ascii?Q?bhd5abKNACQQOmH37reHkmhoFus1YLq72cc3cVFjesYjsEw+XC0WWAw2KJdf?= =?us-ascii?Q?L9FRxICGEsg3HFFsigqstcF9FGJE7ag9bJe6utEfzxINJHlTEyt7aERV6sfC?= =?us-ascii?Q?6iUbv9vnLEEz7F1eVocsZGGeb4Y/qsjTvtjjMnvqEh/bi03MjzKBQ4BORyTh?= =?us-ascii?Q?L1PyDOunMRyb1/Lmbkr0Iikpt0fC1iVvScSeOuxn52Xz1jB6Q7q5CdkYtYaE?= =?us-ascii?Q?Hzf9++pled15jAcYQHuR02cxT9+yqj0MmEt1kOG+wYQuRTxhPuw81pVgBBFP?= =?us-ascii?Q?cvveLpo1jFsCWE+yA77sFSW2cU5j16c9O+kR1Lc5k0xHre0pCK7+g9khJc53?= =?us-ascii?Q?TwcGbNUNAPGhxhzMxGaM51hvqh9TiARLsNwydJgnI6tft311KvnfVcGaNXHD?= =?us-ascii?Q?Fy4sN/LDO1Jip7cxXbmcwnQsZxxiffUw27YhQ+byUR1yYjlYL1+IsC1IUSbe?= =?us-ascii?Q?rhcsJmbZxZHm8v1/OfxW7TnQVQzBlfntgjVJY0LDa8JmGGOYYoEPVx0WXuzc?= =?us-ascii?Q?/En88Dn4R6dLnJGxuSnAwoUyaPCbhQYIYtgIZp1M+LMI6tigrbJLoo/FvB1F?= =?us-ascii?Q?K/0PV3wIwSyxCfdTw/yUQvxb4+9J8p5YqUWTO4fEQEPpCvo2HiR+8DSCjvtA?= =?us-ascii?Q?4AvjcOekvD1Js5l6BI/V4ow0g612r/N2kanUkfNy22wWNJ66escWoYX1NEls?= =?us-ascii?Q?iCoOYAdtxOuTrzfL5G3dulfLBiIn2qpg+5i2YW/KdSL0AKmoU6WqPFdW3iTD?= =?us-ascii?Q?1g5TjUR+3ErmLHfz3li1WS8SIiz4UjMOemIy7AViD6IJUkhLgljAhHYBllDM?= =?us-ascii?Q?QrmmMXhbl1pdDRlPMIR4X50DrJGwbkhbLmDiVa3RJpu/BjidD9oDGDJ6+rV1?= =?us-ascii?Q?Ewz3Se9FbniPhI2r1LGklmjc9ETwC2+G+K0BayNyIRMyndKH4HEFHE6HevQa?= =?us-ascii?Q?1h8tMb/NkX8LgR7CfltvT+qCyBP/WDPFef0WNg8SshnFrNtVrCvkvl7KYSQ/?= =?us-ascii?Q?IJffPUEocdOB8K3hef5UsRnegj18dQKnPzHkimFNLTUHzsQyFrYgarg/hRiR?= =?us-ascii?Q?2Ah577+6T5LYg4S2f27vfDY8ccNWzWzTgdbL58IYT3zlsGUB0Rt//j4bRv9Z?= =?us-ascii?Q?+YRaP4YTq1pqrWKVyR7iKdepmgDhcr26TAP7yYRIRcEi04yVP+VfF40oe/aa?= =?us-ascii?Q?5trBG1CjE+oOZeijeITqwueP/unSS8L4YvyPHjJ1OhR3+vEaKPKXV14QaRah?= =?us-ascii?Q?UIWzYTsKEF9QJPZaHfsAGVu/Xo6msJkvgrdhTcuh5fd3MLaL305S+8/s2QIE?= =?us-ascii?Q?bPdBYg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VCPi8tfIl22/RZb9gRFjGBWCwjRtUFoSwhbQwX6cKoK5m4nwkQuqYY+LrXMQ5DHc//hmKrKd5rQwMF3bu1Vq18ip0wMj93KENPQGC4bK98VJOEVrQRPk9cgVjKvHh9Yo9vpW9j22ceZBv5FSaEUR7pZz8s5Z31wt1Yet5dtveA4uJEdmbjjs3fISYaBC5mv7PTvWgY+322lfg782mPpWj6hWf1yAvleYlTUWMJBaVkihYrsLH+y2xJ43GuNLLyBwcKB4CF+Bwd/QyOUunChFOdtrMtwoO86tm2GRSWMStNyP1dsI4306gXRfEt44h6hK7IxIyf29BJ4b1+sZ02QQ8Oe0b42bAH4oGM79wZ4tOJKWtlVYsJW0CLsEoevKzPHeSZ/14R4HjLXpx4GVUONOZyucB4vjLb1s6KEvgZXP4vdOuludqmF2KdeRI0zmZ5BUVUTiarXFXg0O/sjGa0/pLXoUclTFliHUEwsnzChrCJmSvPm74j+qYExOU26cwv2FoM9pjFAjHhjAqR5ucuOzVaUwcXppaM+QQQwuwzsketYQiZ6e3h1uxvW1ze5oT8o5Hmw8cJQQmlE9s9AfpTl3wkxiy4+KgGC8B94RXnCpalo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 166f8b08-14ac-4c8a-756a-08dcf4d22fe7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 08:51:16.4523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fQghETRalrVCfU5/5EnCJ2r4yrjLf6ySBjFkrOBMURjbdE1m83TAhxKS77p2EJfIXAZoZG19upNSJSG+QTRjDWgI9QIk0eWvyt70FIP5Z60= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4214 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=702 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250067 X-Proofpoint-ORIG-GUID: O-tFxtNSsmVSt6idTZK7naNrwID_v0mP X-Proofpoint-GUID: O-tFxtNSsmVSt6idTZK7naNrwID_v0mP X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E135514000D X-Stat-Signature: yyw6i71aptpqxx5twbapi6zaeaxas6yu X-HE-Tag: 1729846269-938119 X-HE-Meta: U2FsdGVkX1/hs07ANVVhsVJOteK6UlgFuTUC8s1YRgUeOJWxhLX9n1DgoSDwT1lgKVfjZk6dzDrARgwKY5Qo9bRH2TsgCoPppwOACJv/w4/bLBzXamwwq8GfzfQi6fZ3aQ5hEblKqE3QmmFDnbirMnfwLdCswQbPaEXTNI7YrMBw26VIbI8TO1ngPEorpS4Fz9Q67TFZCn0Ve2rPyXoBXaqAZMPbjvy1YrGk2Ec2UcYndIu6wd27jINDBu6Kd6jZYIAmhE1jD6U0g/MVV/GyeCiZ43BVx441cpXxKelQp7/L7gwEEAadD1Tq3BgjL0l1ozxv4ylVabPf5hdNW5Iwo1oRVCUPR7uU0hrpkDI1Ava0MkaWhlLNCGdFS12Tb25HPlSYoCSemPKJpssza15nJviRKQnqE/3nacr7fmim9nyip3HsgZMurr9PEZDKdlDjCjYpfoeeDi9TD9E+TWQP/s+NBsXBD0RGIy/vGXJjCpLWoQnfVWcpvz/7mcQyIMT2Rl3hLkXN2qzUBK9kNIeT4bsYV/RNzTkb9ZCg/51bOlAD0zdxT501uFOe2DTJq/eXg1MElouWb74xUvlvFRiGOEaQ2ttI2guFf/SDkjEpQcqPFCFJQH2pfwb6Ql3AtX5KBMFZfYdtvfLJMYXHlVCb+igX0YqmJV1Zs7gNivlz3Fm1ynZmrYSRkoy24fanjSQYT2j/YSggUPl7gLwDCS3FZwGk4cjSTrhc7IKd/dXh5MZr9sLznYGzk84GIIS5ZfavQRvYHXIoCUR6NiYo6bYx1DqG3dZynD8x3jeAYS7UOO5al3+8qTAWqSp2yTOHk0SHhF6FkMHHYKdLR/I0znt1glCVHFk+olTG5WG1ZbTIhW7AI7T+3LOHpT9YYVE1xSR7GYo6kXVNnPWnq5tSMU64pu3xxedjdT3+ojdcu6xkg7WLUTExTTApAbX00oypeVvFOmjU3JUipK6vvloc1pz nYyDkilx zbJrgLbJX8bypMPgfbF7AUMLJVNIyhA+7LYc6R2SEU5n776g6lctYnURAaMil08k96slG9llxQkGv8i/tVyj4V9qHrBJm4dO2FcIqRFUB1jpOrMEh04TljpSX5ndmAYcEYyi/71Q59uoS5/zXZB+H+mBb8wPSYVjZDKzTGPJQAbVDyAhfAWFrI89lvfrvVFfY9N+5b0Lhd4pPWG9NbgjPmHREAiuGt4wtrd5MvBfQoXu8wPCeJ0iylHtWFnjlhdeD1kV+jIfnBU2uqr+Ff7FtDdYBWb0PSwfHg5pjEpYiExc2+JORQUWPr4Q3WzPw/Mj8ZZZUXjyd2hIow3xxLeYtUWmtipgtkPtqq7WA4kNkhyvWq1U4b7A+tEaFEickgcKYCFltZhPefsDDw0TRJrCi4xjSWMrehdDeN7ppGWjuFJeaKnO6VQHs7WGQ4OgVyELC2w5OENsGeEMYBZ7arLZay8GPp4hJJH343/NoTlVOEH1Sw7d+aJ8jUb9S0NCzIJtrshVcnugIdsyUFszD8nKL0vRkGxcPwG6Y5AJ1xx1kI3PgGk+JVcvE0RCeww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 08:49:19AM +0000, Wei Yang wrote: > On Fri, Oct 25, 2024 at 09:40:25AM +0100, Lorenzo Stoakes wrote: > >On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: > > > >> > >> But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. > >> > >> Lets say just_expand is true and can_merge_left is true. Now we will adjust > >> vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't > >> restore vmg->vma/start/pgoff, since just_expand is true. > >> > >> Is this what you expect? > > > >Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't > >realise :) > > > >Actually at this point, I don't think we need a follow up patch, sorry. > > > >As I think perhaps I will make this change as part of an existing series > >where I am reworking mmap_region(), since this is the only place where it > >matters, and it would make everything a hell of a lot clearer. > > > >Thanks for pointing this out, it's very useful (and an embarrassing > >oversight on my part...!), but I think it'd be better reworked this way. > > > >Thanks! > > Ok, for now I would just remove these two lines with the change log you > suggested. NO! Sorry I've not been clear - don't send any series. I am going to make a change that eliminates the need for your change (sorry, but in discussing this I've realised that's the best way forward). > > -- > Wei Yang > Help you, Help me >