From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC20E77180 for ; Mon, 9 Dec 2024 17:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DFEF8D0094; Mon, 9 Dec 2024 12:45:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FBD8D0058; Mon, 9 Dec 2024 12:45:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E23E8D0094; Mon, 9 Dec 2024 12:45:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EED878D0058 for ; Mon, 9 Dec 2024 12:45:50 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 47D00120A3E for ; Mon, 9 Dec 2024 17:45:34 +0000 (UTC) X-FDA: 82876147116.30.BEF9A15 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 0304640016 for ; Mon, 9 Dec 2024 17:45:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qsTx9I99; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/NfjeUoj"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qsTx9I99; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/NfjeUoj"; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733766317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ffQyTylVsABougM0qBCW2Zl0eo5LTrT3Qj+mN59l+aY=; b=BkQmt9TlC9YxfncLQoUpALQHnsqKZfPA4oDdVOxJzzLOGXonYipFA+kHm/sOqEPYzaI9FR E/fJ8mcg3ZTC5VYMVfp/fyR6BFrsU409j9ntbvihLgolbX/jBESH5Vz55huRb9TCpD5jH/ vhyuBEoNMvbhGcV/7IazEPOSzu3TgNE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qsTx9I99; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/NfjeUoj"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qsTx9I99; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/NfjeUoj"; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733766317; a=rsa-sha256; cv=none; b=75yI/tf2AVW+r0WhegFoW9Oq6yBYfMGyqIPvmd6io8Dm1Zcy1wUd4N3pRH+XwvIuZbtBwk sMhUAOuSNQLRGx1sdRnbCkwcVN3HelPRQvIWK2PoKbxhGWkVGwXNS85nPwr+eJlgmMpkwS mnJkEW5mg6b7kM0VYsLbJDyHBH3tZs4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 91FC8210F8; Mon, 9 Dec 2024 17:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733766329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ffQyTylVsABougM0qBCW2Zl0eo5LTrT3Qj+mN59l+aY=; b=qsTx9I991hPtbT7ARjVRmjhnuhy6Eciu3k5d6cOunOULE3vmYOaqC9LMp2o7B51lVvoTfN X/m+JINEnSUBN9337z8Cp1UOR9f4XlKMjtGT4e1lCUDoFxaPcizM46O3w4DJ2Ly71Lk3I8 lEhbdNG8BGFFKIez+KLovDmDjcgFXwM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733766329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ffQyTylVsABougM0qBCW2Zl0eo5LTrT3Qj+mN59l+aY=; b=/NfjeUojDiS0rqTjBtgA+i4gpJLF0GCP50r5f2GyyzJaJKFZl/CcOJ6UYvHvBkT6chCOS7 wTLDi6pI0UC+VaAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733766329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ffQyTylVsABougM0qBCW2Zl0eo5LTrT3Qj+mN59l+aY=; b=qsTx9I991hPtbT7ARjVRmjhnuhy6Eciu3k5d6cOunOULE3vmYOaqC9LMp2o7B51lVvoTfN X/m+JINEnSUBN9337z8Cp1UOR9f4XlKMjtGT4e1lCUDoFxaPcizM46O3w4DJ2Ly71Lk3I8 lEhbdNG8BGFFKIez+KLovDmDjcgFXwM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733766329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ffQyTylVsABougM0qBCW2Zl0eo5LTrT3Qj+mN59l+aY=; b=/NfjeUojDiS0rqTjBtgA+i4gpJLF0GCP50r5f2GyyzJaJKFZl/CcOJ6UYvHvBkT6chCOS7 wTLDi6pI0UC+VaAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6F860138D2; Mon, 9 Dec 2024 17:45:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mEE4GbksV2dSPwAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 17:45:29 +0000 Message-ID: Date: Mon, 9 Dec 2024 18:45:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v1 1/2] mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc_contig*() Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Zi Yan References: <20241205090508.2095225-1-david@redhat.com> <20241205090508.2095225-2-david@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241205090508.2095225-2-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam05 X-Stat-Signature: 1mzdzkkej8fejzue9zn7uhde7bx1fpx4 X-Rspamd-Queue-Id: 0304640016 X-Rspam-User: X-HE-Tag: 1733766309-751299 X-HE-Meta: U2FsdGVkX18cXvGXcaERZi66vV8/ycMvF0ikptalFPspxIHscQ4pdyx2OTlZ61/OROHR+GDfpu9kU69jak/90nuk6ZhiviK9e0b35FuyL0SQq9sraeTUC2sha4DD6Mw4pJv17TvOsbnDKHvYnhTMgOdeBIEOpmMYhj3Kv6My3ojkH3GVRsK//lk+EaQge9PueEx7Jze3swejXw4TMYbRWYM+U4CGkiiJMQNMoiMUzGQmMDntidARBv820WpMA3IGFmBrkjil5os7dxbqx8Q5gEx33JBOb/rQlePkdF8nrJHvY/OeDaCUV0dLZzLU7GPjGtB5HDOaGxdrb9zBa01d9rOkPY2ITNNZiUokxgeKCLSdcs+0hESgmoetyW3HYK0XL417pcL1DY3l6FPsGP4kO26hmpbl3uVLNDzn1eV/TT+hrIr7RoXWrszMwh6Yi+Ngpwz2XiVJzJKs9E9fQTO68Mj2cZ8gRjW9r5+aYt2x2FeolKWLNqEkbJ1UWSXkO/ngrWmAWiDJwwfMrn8pvMuaT0WlZIYnWG85tJ5d6rlYmo6uEr0Itb6Km6n5bDNfHGj7NUtRpeTb9oRA9tTG3a7scTjHxCWEBHJckVJ+DNw4tXC7laiPwB6rzvlq29e2gzbwlBhWBn1MX4XY4FqgJszc5sXlLjQ7YdypB2C0NDmT2mYs9QIofYQHd4W22A/weyfEwEKpu28WQhHZLpNKjuNFO8gyRAXxk464tCEQKoKGTDDE3bmutchv5Vr2Hxmv3ox0ACNl0ZhJXVP5XeUiyXzrnQLAdAiJFmZEE47Y+fIzAa/ObjfkIHXSEVgnxrJYX9r+sCwuiBIpKeaeMHfCNWw3stINyTVg1nLfKqdEpgiY56QBF2RQf6k8VtqsEJC1apCH4Nwi/fhRf2UVFJuwpklrwt3NsPydKMD5DAaa5rPFJoTFKOARcVFtQSH5ZQKbzH9NI5KfXPMgJClIkzOngM7 GWzZUBFW 5nIejWgmxH1+crheLWbVrbUf25/ztMhqTac1g2ihgSK/d3X1LhZMfVH3yrL5XVVoITmP67ep/LQheMRLYeneKWePAfI9Qc0obx+6s8qDZ0amTSvNW31510d9zplMcQQksB6+Nhko9zRZbfd7mvoum/mZ1p+Sat3hBtqumjpqcgh1MsJZIWZ2MQI+iTqsKhpBD1vvEIER3KP4Ew5GYq/qn6HVZ2pGahhE6Sof+l/nDpONeLE1Iz1wEA9dfg2qQLBwdYqQxxN82//uKitRyKnhedKpCqbx94mrSOu4OYNDDkM9fIsmrMxyogYKVw8pVGVa4y+PRC7DQ+LOW+IUSVxvEzD/tr/DOBQp9uh7Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/5/24 10:05, David Hildenbrand wrote: > We'll migrate pages allocated by other contexts; respecting the cpuset of > the alloc_contig*() caller when allocating a migration target does not > make sense. > > Drop the __GFP_HARDWALL. > > Note that in an ideal world, migration code could figure out the cpuset > of the original context and take that into consideration. > > Suggested-by: Vlastimil Babka > Signed-off-by: David Hildenbrand Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 48a291c485df..acadfcf654fd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6410,11 +6410,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask) > * page range. Migratable pages are movable, __GFP_MOVABLE is implied > * for them. > * > - * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, > - * keep doing that to not degrade callers. > + * Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that > + * to not degrade callers. > */ > *gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) | > - __GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL; > + __GFP_MOVABLE | __GFP_RETRY_MAYFAIL; > return 0; > } >