linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: anthony.yznaga@oracle.com, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, ljs@kernel.org,
	Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, jannh@google.com,
	pfalcato@suse.de, Jason@zx2c4.com, shuah@kernel.org
Subject: Re: [PATCH 1/2] mm: fix mmap errno value when MAP_DROPPABLE is not supported
Date: Tue, 14 Apr 2026 10:14:57 +0200	[thread overview]
Message-ID: <e6cceead-04d1-401a-84f1-e5f2310e53e0@kernel.org> (raw)
In-Reply-To: <43370425-00b0-4853-bc82-63064eae2b8e@oracle.com>

On 4/14/26 02:43, anthony.yznaga@oracle.com wrote:
> 
> On 4/2/26 4:13 PM, anthony.yznaga@oracle.com wrote:
>>
>> On 4/2/26 12:17 AM, David Hildenbrand (Arm) wrote:
>>>
>>> Acked-by: David Hildenbrand (Arm) <david@kernel.org>
>>>
>>>
>>> But
>>>
>>> ~/git/linux/mm$ git grep ENOTSUPP
>>> hugetlb_vmemmap.c:                      ret = -ENOTSUPP;
>>> mmap.c:                         return -ENOTSUPP;
>>>
>>>
>>> Should we fix up the other one as well?
>>>
>> I'm looking into this. It's returned for the case where vmemmap
>> mappings cannot be split/freed because they are self-hosted due to
>> memory hotplug. Many callers end up ignoring the error, but there may
>> be a way for it to be propagated to userspace as the errno for a
>> failed write to a sysfs file. 
> 
> To follow up on this, the ENOTSUPP returned by vmemmap_pmd_entry is not
> propagated to user space.  It is used internally to ensure
> HPG_vmemmap_optimized is cleared for a hugetlb folio when HVO cannot be
> applied due to the vmemmap memory being self-hosted.

Thanks for checking, it indeed propagates a bit but never seems to leave
the file. It would probably still be better to just clean that one up as
well.

-- 
Cheers,

David


  reply	other threads:[~2026-04-14  8:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  0:34 [PATCH 0/2] fix MAP_DROPPABLE not supported errno Anthony Yznaga
2026-04-02  0:34 ` [PATCH 1/2] mm: fix mmap errno value when MAP_DROPPABLE is not supported Anthony Yznaga
2026-04-02  0:44   ` Andrew Morton
2026-04-02  7:17     ` David Hildenbrand (Arm)
2026-04-02 23:13       ` anthony.yznaga
2026-04-14  0:43         ` anthony.yznaga
2026-04-14  8:14           ` David Hildenbrand (Arm) [this message]
2026-04-02  0:34 ` [PATCH 2/2] selftests/mm: verify droppable mappings cannot be locked Anthony Yznaga
2026-04-02  7:28   ` David Hildenbrand (Arm)
2026-04-02 23:16     ` anthony.yznaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6cceead-04d1-401a-84f1-e5f2310e53e0@kernel.org \
    --to=david@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=anthony.yznaga@oracle.com \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pfalcato@suse.de \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox