From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B64C7EE23 for ; Mon, 12 Jun 2023 07:42:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 721AC6B0072; Mon, 12 Jun 2023 03:42:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A97B6B0074; Mon, 12 Jun 2023 03:42:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571598E0002; Mon, 12 Jun 2023 03:42:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 443526B0072 for ; Mon, 12 Jun 2023 03:42:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 085871A013E for ; Mon, 12 Jun 2023 07:42:31 +0000 (UTC) X-FDA: 80893303302.18.0266CCC Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 161B740006 for ; Mon, 12 Jun 2023 07:42:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HmFlYt84; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686555749; a=rsa-sha256; cv=none; b=TOLroxTpx3NK94pmJlPB87OMRwQLsTBQRJxeT8v5vC6r3FS5aOt+O9lG8BAfbN/V5W2MzL xCaWZttAaAJ/aEq3006YjqsyRuWqhBWYaAigAPRMRuRYe0NhKs+tvQ4fpZE0XF7STuZZex xXerEHU88/4JGaiLPE/D8UCRwJTjl68= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HmFlYt84; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686555749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UwP1Zk3pMrqMV1LSHhphIL1e3hF9KkYI2eCu8NTX2wg=; b=C10vk/8Xgb/hpjtdVUs88QzQfqTRWoJf6b14Rw8On5y1kHCopdqN4sf7modzK+EzLnea4o mQuJYM2tmBQoBs5z/R9f1nXWRiGIExPjl6GdKADfz67/wBT3P8djLUHPzAit95D6ZMWmBb fniQY4UhcE3a/3mm3HXis8Y2PHAVlSY= Received: from [192.168.10.55] (unknown [119.152.150.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8C41066056AA; Mon, 12 Jun 2023 08:42:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686555747; bh=jaXgQtw+3VAkdUzI7Dmasonlno9daKl/YokJZ/nQOdQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HmFlYt84rHySyKYTzkAvoEwDVJBcltGzygCAaH8aQEDBATyrzU8pKiWTrNTkmrM6i v4n4y/kp58PSf+LFZYxjlS+3RXrrNQk8i5uk8Ez+Bu6Z+IeT0N3eMKmwPyN62Z7G8w TT/4VK4c4bN0mMA1XyCMJ+LAmIzC0fnjy7uJh/KXJEyj5mVX8aGl2gi4NK/DTrjgka EeXPV1Vxdai9pAhvFnHTJNOD2Hw2BQ0zIiM7rBxj6vgAyT6PbPmod/w3O7RWH7bD9e 5Fs1kRQPcMATzpCHT4LZqIHdAh2yRf6VwrdtlcYOqgjbEoNXGccK2Tb1fmqnc7TUe0 X1P18g1Tsz/2w== Message-ID: Date: Mon, 12 Jun 2023 12:42:21 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , Shuah Khan , linux-kernel@vger.kernel.org, Peter Xu , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/1] selftests: mm: uufd-unit-tests: remove a format warning in printf Content-Language: en-US To: Mirsad Goran Todorovac References: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> <109d9c47-9c0e-e8ca-2bc1-cb741bc45a1b@collabora.com> <138905be-3963-cd67-c217-7aa561372293@alu.unizg.hr> From: Muhammad Usama Anjum In-Reply-To: <138905be-3963-cd67-c217-7aa561372293@alu.unizg.hr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 161B740006 X-Stat-Signature: f8bqw13h4yb3fb4t18tkrhgsy6xdk3ny X-Rspam-User: X-HE-Tag: 1686555748-105289 X-HE-Meta: U2FsdGVkX1/NhqBTUidw9Z1thZHWAVS9ighNrzK3P1pNhV3wHs1uG294CMMdnWB4276Au321SI5RrFLSaYm5I9c3ND8E44QdT5FXC0AyO31ZhzSpOFGnUspHREqGDtgfoPPwVAxgNDhfI6LTZ+CjsIqFDpl6Xk8GcMu0IpHooNRfK8qwo31m3e9+2OPH1CV2JrSfjz/8Vt2JsUFEvZZ15YSDHb4eTBiBEtAqNi84FxBWYSiImLJtyxk3Nb2nWh60op31AcvaKPQwYAqfFWP0YWtIVFw6o/fDpfgk0/U4nP6OVTsSfPKQant2iiQ0sPrcixwwrlSnb0q4Av0YJvfaVRzc6pAhrTCIluRm173iBirmYGkpfhhVns34nkIlgR9nV2qF7oOJeszNrHr0f7xFzsjJgTzKbaCDbqC2fU4ALBIFlmvi9qnkJynyGqx6MZPXCqHVYOnTE//7VGC0tuCdnCD4CBXVVFy88TjYZ+l+ZGqtf+f8lPe70E3XcBkUPyx+dFK7dtkHwK8uqDXNwgXgKjO3N9eAJ5jqeOBRPErmRP5dzHxIQrByTtuiHNN3mhdvFfOcPolNAbWatzM33N5T27Tsqo08FnLfEfmBMf20STLb0Xq045UMCNRC8KBses1AntOQ2mfn2qZ/+TbMqX4qWX2SyP4CFp3yNjGSgdUiM9k1V8p7Towy9n6D+WovgEsoDjzF3lcWxZDnt+1jEMJzpm+3l6/5YmvhasBYvyuDyweN3ZZp0d4D68sKpBJltEx30KWQYukeowEfkn6zVBn/LS4Ytv5gB724voJ2M8sNGJ3l9F8uSAf7EKM8VWHpuamiXbu8YoGK5esKRuE5M4wg7GBu7dgn04wbMKJ9ukh2grq3mP0J907qJhwS5e0VBFRIuCP1ijp3f2ltV2z6jmzCFB2aNnu7YAX8mPUEjyLbZHx8K56T9Q5GbVX1XDqKeHuGwDuv6uGVBEPcEwZv+ic hwrQN9jx IY9nhON2MzNbGXgmxlpZC7nbgEwvjz1FcDGxglEvfNK45aMsbDxvlLTZs7MFQH2bm0HrxZhkL0OAmZkulGAv7WA3+jejW1bcxBDe5lyRKSfi35gLDg6spHyHr1UOSTpbcTCW7eeXVyl+U8pNwZbvWr9MJimeLFBhJC5s6xdCbzXJdD1tseTNi86b9x9EmK00xGGaXeoof23wYBb8KBB1jXj/nnh/WdDOALafa0gimazd0yZ1OGohDIOEBH25/e3xa0m+8OjDPA3W5mjg9O0hkKln5JieDo+ro+Kwh1ZGGd82AAWlQgeDyNc6HBmGulE3znptp14zUVqYG5oU7Iapyxb0soQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/12/23 5:11 AM, Mirsad Goran Todorovac wrote: > Apologies Muhammad then, didn't follow that branch. No problem. > > Regards, > Mirsad > > On 6/11/23 14:30, Muhammad Usama Anjum wrote: >> The fix has already been picked up by Andew in mm unstable: >> >> https://lore.kernel.org/all/20230607023727.0E011C433D2@smtp.kernel.org >> >> On 6/11/23 4:50 AM, Mirsad Todorovac wrote: >>> GCC 11.3.0 issued warnings about macros and types of arguments [edited]: >>> >>> gcc -Wall -I ../tools/testing/selftests/../../.. \ >>>     -I ../tools/testing/selftests/../../../tools/include/uapi \ >>>     -isystem ../usr/include -no-pie uffd-unit-tests.c vm_util.c \ >>>     uffd-common.c -lrt -lpthread -o \ >>>     ../tools/testing/selftests/mm/uffd-unit-tests >>> uffd-unit-tests.c: In function ‘main’: >>> uffd-unit-tests.c:1198:41: warning: format not a string literal and no \ >>>     format arguments [-Wformat-security] >>>   1198 |                         uffd_test_start(test_name); >>>        |                                         ^~~~~~~~~ >>> uffd-unit-tests.c:100:24: note: in definition of macro ‘uffd_test_start’ >>>    100 |                 printf(__VA_ARGS__);            \ >>>        |                        ^~~~~~~~~~~ >>> uffd-unit-tests.c:1205:33: warning: format not a string literal and no \ >>>     format arguments [-Wformat-security] >>>   1205 |                                 uffd_test_skip(errmsg); >>>        |                                 ^~~~~~~~~~~~~~ >>> >>> The macros are defined as: >>> >>>   #define  uffd_test_start(...)  do {             \ >>>                  printf("Testing ");             \ >>>                  printf(__VA_ARGS__);            \ >>>                  printf("... ");                 \ >>>                  fflush(stdout);                 \ >>>          } while (0) >>> >>>   #define  uffd_test_skip(...)  do {              \ >>>                  printf("skipped [reason: ");    \ >>>                  printf(__VA_ARGS__);            \ >>>                  printf("]\n");                  \ >>>                  ksft_inc_xskip_cnt();           \ >>>          } while (0) >>> >>> Minor workaround, adding "%s" first argument to macro expansion calls seems >>> to be the easiest way to eliminate the warnings. >>> >>> Cc: Peter Xu >>> Cc: linux-mm@kvack.org >>> Cc: linux-kselftest@vger.kernel.org >>> Fixes: 43759d44dc34 ("selftests/mm: add uffdio register ioctls test") >>> Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") >>> Signed-off-by: Mirsad Todorovac >>> --- >>>   tools/testing/selftests/mm/uffd-unit-tests.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c >>> b/tools/testing/selftests/mm/uffd-unit-tests.c >>> index 269c86768a02..d356dd271c84 100644 >>> --- a/tools/testing/selftests/mm/uffd-unit-tests.c >>> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c >>> @@ -1195,14 +1195,14 @@ int main(int argc, char *argv[]) >>>               snprintf(test_name, sizeof(test_name), >>>                    "%s on %s", test->name, mem_type->name); >>>   -            uffd_test_start(test_name); >>> +            uffd_test_start("%s", test_name); >>>               if (!uffd_feature_supported(test)) { >>>                   uffd_test_skip("feature missing"); >>>                   continue; >>>               } >>>               if (uffd_setup_environment(&args, test, mem_type, >>>                              &errmsg)) { >>> -                uffd_test_skip(errmsg); >>> +                uffd_test_skip("%s", errmsg); >>>                   continue; >>>               } >>>               test->uffd_fn(&args); >> -- BR, Muhammad Usama Anjum