From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB0FC48BF6 for ; Thu, 7 Mar 2024 10:54:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE58B6B0151; Thu, 7 Mar 2024 05:54:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B95956B0153; Thu, 7 Mar 2024 05:54:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10C56B0154; Thu, 7 Mar 2024 05:54:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9392B6B0151 for ; Thu, 7 Mar 2024 05:54:53 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5B2301C1389 for ; Thu, 7 Mar 2024 10:54:53 +0000 (UTC) X-FDA: 81869935266.08.E2171C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 3632F140005 for ; Thu, 7 Mar 2024 10:54:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zs833gql; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709808891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1lm40ubOvwgI2hgIyDEcLOPBW7VS7s9xjq9/yDTV9OI=; b=WImxAXtmRJzPWHRDLZKfUBpCtvQ3A8T1KrtEj3bap8WTHZ0enXYwzlokCKk0O9YwLSIblR JPGgOXW0g4bvhjmW/SQ+7ObHmh59giL1V8nwY4O8WhQmGQfah3LT13QeseppXDuWdmNmcR M/HDbkUR0iXVyzzO6F5ZkCBhG6xtaFo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zs833gql; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709808891; a=rsa-sha256; cv=none; b=bZhrvuOGf9lwlKgP68EWmPWyYK9kvPZJWrTlI8QHpmrnYqHoHcGzTib3QQvOhBJAs01xc4 OXLGy47nO9R8hiyaYUj8l08F8G0LGV1840CX09w8k1y7d/AIixI77zAiLPEelRxdt1ihRS 6CcmsNB2j5XWHaEjboK8l6PypPBNjRE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709808890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1lm40ubOvwgI2hgIyDEcLOPBW7VS7s9xjq9/yDTV9OI=; b=Zs833gqly5eOJ56/NgD4Bkt1+tW7Nv9e324reiJldu2mYjRO7AV7gU2ZvhJud1+2FSFrAU ArOIMRIpz8t5Mnd9Neiyeku7P/Emg410j1TYoG+X8xAnKHo1gVJDSj9HEM8PsL0oX/ZeIH OepUfFEPNB0hmfe/Ui82vxPHmeawaBY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-w0XQJ46fM7mI-4s8kXV_ag-1; Thu, 07 Mar 2024 05:54:46 -0500 X-MC-Unique: w0XQJ46fM7mI-4s8kXV_ag-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33d1d766f83so296817f8f.3 for ; Thu, 07 Mar 2024 02:54:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709808885; x=1710413685; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1lm40ubOvwgI2hgIyDEcLOPBW7VS7s9xjq9/yDTV9OI=; b=WUSx89o31Z1uvflaQHyLdNiAhVxrCil3T4vLm5+2aioVLm04wiB2op8vDnVZJLTh6y jnARXTBWrku42SmrxuOmJ/zhhIScyIKHbvotcM+4hYI/nJyiC9urSUcI4RCkeGxhG/PB FaT9ImeWx5o6Mf4RVt31/yA/eTzWgaHIb/3YXis4HxQv0t3RuXTmhVbj7B7bVh/MilPr zYRObV2isgRCUSOdVB8BfYpGzPgVePn63B0Y1K1ELp2xFsV8MO9E7+6qDZdQPae0mFXF wls0PzvYeXQLLSp1oFiJAAhCavBBBb92yA/OmNT2hBUyuOmWhd9sYTSTmMqkgcpx5rK5 vqvQ== X-Forwarded-Encrypted: i=1; AJvYcCVsBbS4ubJHtd4q9Wj5VGQpVM66JqS4JCVP5WwCaP3uF/8AccfgJWoaLoHHugATb9AKfIAfDWAWGMkVDBAZSosqaMM= X-Gm-Message-State: AOJu0Yy9BYI5q3QK6v2exCygBdkjLU2Oy1XsuLLndbNXF10gwzMTEgJe qEseBOIosvVhNVWeAfauW5cVKSCtAnCPgT1vVB1KrNkgRJ0VmecxzGz1paDbkI7vhuCgATlwy1w DvBfIppiCKUk03GG5FUxXQ+fY+GiF62ljCieEN4hiJfr0mG7o X-Received: by 2002:a5d:668f:0:b0:33d:c2cb:c18d with SMTP id l15-20020a5d668f000000b0033dc2cbc18dmr13644064wru.32.1709808885279; Thu, 07 Mar 2024 02:54:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVZMxpeN+N8KFTKDEHC8lEnvsJwBOUQK1xUZW6/X6QiyTCGbUX38oFLEXScnUOtYsL53UJUA== X-Received: by 2002:a5d:668f:0:b0:33d:c2cb:c18d with SMTP id l15-20020a5d668f000000b0033dc2cbc18dmr13644039wru.32.1709808884839; Thu, 07 Mar 2024 02:54:44 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:6400:4867:4ed0:9726:a0c9? (p200300cbc74d640048674ed09726a0c9.dip0.t-ipconnect.de. [2003:cb:c74d:6400:4867:4ed0:9726:a0c9]) by smtp.gmail.com with ESMTPSA id r12-20020adff10c000000b0033de2f2a88dsm20096450wro.103.2024.03.07.02.54.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 02:54:44 -0800 (PST) Message-ID: Date: Thu, 7 Mar 2024 11:54:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free From: David Hildenbrand To: Ryan Roberts , Barry Song <21cnbao@gmail.com> Cc: Lance Yang , Vishal Moola , akpm@linux-foundation.org, zokeefe@google.com, shy828301@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240307061425.21013-1-ioworker0@gmail.com> <03458c20-5544-411b-9b8d-b4600a9b802f@arm.com> <501c9f77-1459-467a-8619-78e86b46d300@arm.com> <8f84c7d6-982a-4933-a7a7-3f640df64991@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8f84c7d6-982a-4933-a7a7-3f640df64991@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3632F140005 X-Stat-Signature: 77injujkxeorgftus86tgoonq6rdn1c5 X-Rspam-User: X-HE-Tag: 1709808890-635463 X-HE-Meta: U2FsdGVkX1/d46CU8UjJW7yfDXv6JmQ0XaprKZCDbBgGTGvCK0FXekrYhW9LOvtOoQ4VC/vjBU5qmDi6L4rOzog8zJJdmQDOJnCt4mQCqpeFZcz8eIwwVRLR0RFfk1YTxpN5NlDJq+9wYgYQbt1JTGDZz5WtZQjos5gJ/R+b49Seg/PdCVXsxNRQVbft9X/F4dgzi2NXHkOFQvIQtG0O4B51wWK4hHAt1W3NxgFTY63VyxSC6dMpZ4FG6yjXLjrVJjW9pig7zrHsWVHJy9CGCPKIqCVm+T2Jw6ZB5m8yns+2BuP2rr6pqE3Mt7UmvSHOa0vKFWXtPHc7N7VFQvRAunbSqTdFgUEwbb3k6S/MBJ4r+GKDk7p482h3i434JtXah+gZWaqqiXoQyq76ZDrJNsdTHKrSdQ9PrM0dfocmFFHP5MRkZC9fTAOJkuM14lpK4fd1SPwt5krCqzHSCZyR6ux83xKslpSQS9w7Tg1ApXn6DidO4h4nntoATfm1/Q4Twg6aIoyt7/nLLl1S88qJT0t+tpKV7/sbuldYttzQxutHTO1hzX21oZcaXYjKTyxvmgg9OmC8wUvwMIn57xbqw2cDUV517hk7DQfAi2JRwJhWcNWEoy0w+vn0PRKOFcznXTiq2qdo141rMIuq69AFUTlzFqt5pP0wZEDzz0nWEWZ6xGR1z/2SEytXaZvqz4wMKXQGwkzz0CpCp0FDMd5Bb1qWQr2J6WNAuGBvwm6y+zwapdiS2QVIkajPjHn76iPf+ltEoPWNN0A2Q3WuJL4HebIoPcpyvNJsy89cdiyMzaZnria1HdxEnN68BTkitWDjwrp5XWIKJM1BZtRhjzhE/JZyfRnfr8Q0M+fbXXPYr4LJ1frivgCwQMukRS0eRb6GOjqLxbi2/wZtr00GkhxZvFO/7/EvHsh5w3nMcSnn3HegYvM1XtX+OKprnQ0zkvtvOyYuCy2yIIgPTbMyoNC 5oiVwedT w0kVYBljWstiwT9mtiDAbVwwOPbSJiSrr+S8V1LKzKPxYWGcY3HRxNQ89kZ3fBN2kLhGMTHGVs6xUz8HhRSxVPuTQrS6E7VHm3VZPOTdKO8lTOhN3SFkv7pgzvEugq7IXtybrt0ChYRxVSpzMQsaRdw3a9EDNoER94giHbdSizc+r55MeuKM/Xj1uEnlFll6ZZy7t62S6XR+vq/zWt/N0RCmLkb90A6KwxlMdCHwat8xCyT7l7Dn/LId0i3LSLE/nhcd4rnwuY5xYMVxAa5tNiL5awKMcv7/qB7T5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.03.24 11:54, David Hildenbrand wrote: > On 07.03.24 11:50, Ryan Roberts wrote: >> On 07/03/2024 09:33, Barry Song wrote: >>> On Thu, Mar 7, 2024 at 10:07 PM Ryan Roberts wrote: >>>> >>>> On 07/03/2024 08:10, Barry Song wrote: >>>>> On Thu, Mar 7, 2024 at 9:00 PM Lance Yang wrote: >>>>>> >>>>>> Hey Barry, >>>>>> >>>>>> Thanks for taking time to review! >>>>>> >>>>>> On Thu, Mar 7, 2024 at 3:00 PM Barry Song <21cnbao@gmail.com> wrote: >>>>>>> >>>>>>> On Thu, Mar 7, 2024 at 7:15 PM Lance Yang wrote: >>>>>>>> >>>>>> [...] >>>>>>>> +static inline bool can_mark_large_folio_lazyfree(unsigned long addr, >>>>>>>> + struct folio *folio, pte_t *start_pte) >>>>>>>> +{ >>>>>>>> + int nr_pages = folio_nr_pages(folio); >>>>>>>> + fpb_t flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>>>>>>> + >>>>>>>> + for (int i = 0; i < nr_pages; i++) >>>>>>>> + if (page_mapcount(folio_page(folio, i)) != 1) >>>>>>>> + return false; >>>>>>> >>>>>>> we have moved to folio_estimated_sharers though it is not precise, so >>>>>>> we don't do >>>>>>> this check with lots of loops and depending on the subpage's mapcount. >>>>>> >>>>>> If we don't check the subpage’s mapcount, and there is a cow folio associated >>>>>> with this folio and the cow folio has smaller size than this folio, >>>>>> should we still >>>>>> mark this folio as lazyfree? >>>>> >>>>> I agree, this is true. However, we've somehow accepted the fact that >>>>> folio_likely_mapped_shared >>>>> can result in false negatives or false positives to balance the >>>>> overhead. So I really don't know :-) >>>>> >>>>> Maybe David and Vishal can give some comments here. >>>>> >>>>>> >>>>>>> BTW, do we need to rebase our work against David's changes[1]? >>>>>>> [1] https://lore.kernel.org/linux-mm/20240227201548.857831-1-david@redhat.com/ >>>>>> >>>>>> Yes, we should rebase our work against David’s changes. >>>>>> >>>>>>> >>>>>>>> + >>>>>>>> + return nr_pages == folio_pte_batch(folio, addr, start_pte, >>>>>>>> + ptep_get(start_pte), nr_pages, flags, NULL); >>>>>>>> +} >>>>>>>> + >>>>>>>> static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, >>>>>>>> unsigned long end, struct mm_walk *walk) >>>>>>>> >>>>>>>> @@ -676,11 +690,45 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, >>>>>>>> */ >>>>>>>> if (folio_test_large(folio)) { >>>>>>>> int err; >>>>>>>> + unsigned long next_addr, align; >>>>>>>> >>>>>>>> - if (folio_estimated_sharers(folio) != 1) >>>>>>>> - break; >>>>>>>> - if (!folio_trylock(folio)) >>>>>>>> - break; >>>>>>>> + if (folio_estimated_sharers(folio) != 1 || >>>>>>>> + !folio_trylock(folio)) >>>>>>>> + goto skip_large_folio; >>>>>>> >>>>>>> >>>>>>> I don't think we can skip all the PTEs for nr_pages, as some of them might be >>>>>>> pointing to other folios. >>>>>>> >>>>>>> for example, for a large folio with 16PTEs, you do MADV_DONTNEED(15-16), >>>>>>> and write the memory of PTE15 and PTE16, you get page faults, thus PTE15 >>>>>>> and PTE16 will point to two different small folios. We can only skip when we >>>>>>> are sure nr_pages == folio_pte_batch() is sure. >>>>>> >>>>>> Agreed. Thanks for pointing that out. >>>>>> >>>>>>> >>>>>>>> + >>>>>>>> + align = folio_nr_pages(folio) * PAGE_SIZE; >>>>>>>> + next_addr = ALIGN_DOWN(addr + align, align); >>>>>>>> + >>>>>>>> + /* >>>>>>>> + * If we mark only the subpages as lazyfree, or >>>>>>>> + * cannot mark the entire large folio as lazyfree, >>>>>>>> + * then just split it. >>>>>>>> + */ >>>>>>>> + if (next_addr > end || next_addr - addr != align || >>>>>>>> + !can_mark_large_folio_lazyfree(addr, folio, pte)) >>>>>>>> + goto split_large_folio; >>>>>>>> + >>>>>>>> + /* >>>>>>>> + * Avoid unnecessary folio splitting if the large >>>>>>>> + * folio is entirely within the given range. >>>>>>>> + */ >>>>>>>> + folio_clear_dirty(folio); >>>>>>>> + folio_unlock(folio); >>>>>>>> + for (; addr != next_addr; pte++, addr += PAGE_SIZE) { >>>>>>>> + ptent = ptep_get(pte); >>>>>>>> + if (pte_young(ptent) || pte_dirty(ptent)) { >>>>>>>> + ptent = ptep_get_and_clear_full( >>>>>>>> + mm, addr, pte, tlb->fullmm); >>>>>>>> + ptent = pte_mkold(ptent); >>>>>>>> + ptent = pte_mkclean(ptent); >>>>>>>> + set_pte_at(mm, addr, pte, ptent); >>>>>>>> + tlb_remove_tlb_entry(tlb, pte, addr); >>>>>>>> + } >>>>>>> >>>>>>> Can we do this in batches? for a CONT-PTE mapped large folio, you are unfolding >>>>>>> and folding again. It seems quite expensive. >>>> >>>> I'm not convinced we should be doing this in batches. We want the initial >>>> folio_pte_batch() to be as loose as possible regarding permissions so that we >>>> reduce our chances of splitting folios to the min. (e.g. ignore SW bits like >>>> soft dirty, etc). I think it might be possible that some PTEs are RO and other >>>> RW too (e.g. due to cow - although with the current cow impl, probably not. But >>>> its fragile to assume that). Anyway, if we do an initial batch that ignores all >>> >>> You are correct. I believe this scenario could indeed occur. For instance, >>> if process A forks process B and then unmaps itself, leaving B as the >>> sole process owning the large folio. The current wp_page_reuse() function >>> will reuse PTE one by one while the specific subpage is written. >> >> Hmm - I thought it would only reuse if the total mapcount for the folio was 1. >> And since it is a large folio with each page mapped once in proc B, I thought >> every subpage write would cause a copy except the last one? I haven't looked at >> the code for a while. But I had it in my head that this is an area we need to >> improve for mTHP. > > wp_page_reuse() will currently reuse a PTE part of a large folio only if > a single PTE remains mapped (refcount == 0). ^ == 1 -- Cheers, David / dhildenb