From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D73C36018 for ; Tue, 1 Apr 2025 08:02:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B430280002; Tue, 1 Apr 2025 04:02:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8656C280001; Tue, 1 Apr 2025 04:02:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69B46280002; Tue, 1 Apr 2025 04:02:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DADCF280001 for ; Tue, 1 Apr 2025 04:02:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 68E94BAFB5 for ; Tue, 1 Apr 2025 08:02:51 +0000 (UTC) X-FDA: 83284733742.25.9F5C07E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 04BE52000E for ; Tue, 1 Apr 2025 08:02:48 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c7Dck8L4; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743494569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dYJet0YnCiCvticcD26OadOMCZ+YzdfY2OI1EE1PSWw=; b=x5tXM1sIyngq8M+IDFbGwsEK66SQhoDDnyCWPLnYBf58TXfthV81fw13wXOmVQlvo0zAdB E1eNgHHWZHETJQaXGlEg0XN8Kn7JpYNH6FSV5cIX71dN6vHNqRMQtq2AoTVAoRju49y31U OFPOQEiRzITAwg+pieYfNDQscQj9J34= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c7Dck8L4; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743494569; a=rsa-sha256; cv=none; b=iKlnJAzvV7mEBBw4uyjQf50yVfsiF+vLvcZgg70ZvQyommcJJQoKhElMpmLVFkyPUuxMUL 5aFStzlITCe/Z8VJpCy/z61F+38mieWqVfOXi7GgR/NY+qf3Vpsl6hvOL/fAtjm+lz+h2w bs3UfiEMbYOmX1WFqynXVtVWMClli7w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743494568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dYJet0YnCiCvticcD26OadOMCZ+YzdfY2OI1EE1PSWw=; b=c7Dck8L47BrXZyONlBQFL+of3rQtJhQHEgeGz350h3cUNUAhcfvXxO0KcINEA8hhX27SUD 22qnha033dE4QpqhatLhH0j1iv6h399jqPIZPKHrjB2IVVslYCeNI56nudY3MBazf8QKrC WLoYzRtWDZ0cuj9MLdUkZGCXfxGJ0+U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-2HD8P0arNSK2u64MGXcwoA-1; Tue, 01 Apr 2025 04:02:47 -0400 X-MC-Unique: 2HD8P0arNSK2u64MGXcwoA-1 X-Mimecast-MFC-AGG-ID: 2HD8P0arNSK2u64MGXcwoA_1743494566 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf3168b87so28964385e9.2 for ; Tue, 01 Apr 2025 01:02:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743494566; x=1744099366; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dYJet0YnCiCvticcD26OadOMCZ+YzdfY2OI1EE1PSWw=; b=raA8Wg5t4IEu2sIvAb/e08v8pNM2dtG8bPEEKtL5gIjvtMAMCAg9UNQtGYHFpoi6zc a1Fn+3tcjJTWo4o0vhegIiUhTfYQQcFYq3K8kSt6fbz+9i8qkmTX875awr+WuSFF1DpW m+IiHOCfIU0JpXKO5s09NR01DutWQXmxBNLrtCWUHYyb/4y6DDLpL+KOVDuvCXq6HmxH gnusIyOQ7zbrR68y/F7g+DGQat3smHstmmaApOvrWijMUdhTkF+n4Tv/YbiiJ/ifEUKT fqo2DpwIaq9OvCLKv8KKY0fSB1M8l/nDNZkSkt6xgINWCfpsmdz7X4Uw5ytvKU//YE9O C5kw== X-Gm-Message-State: AOJu0YwM+BBwDky3HitImnikA0nmLyWF8ln0SII5zLJOSOMJsmapgdBw MrE2NhrsWdZA5JYNIpQubGi3IFHdQASy0+9UyNLSNlpSaWNBscsiA0dAsrDiDOCY17mFQgosZx8 b2tamPc0+TbLFvhLIgOFAU6ogC8O6xXzfr+8SNj1va8e99ABf X-Gm-Gg: ASbGnctKunfviVqwzR6h33PAeDW5XAa1YBzYIN6H2xt/xpr9V+qt5tx0mr2dcNglWTp 9bRkCf6jaJ/u2eR1CUEYkizL1ncyfEQsNo5oseZwkoh5frS4PWm1rCaOsnuH+tOHjuKTdRqEEyd Z5rF61C4XswVQZMYAyBmrbvpWqzCOFOAJb7hkZwKozx7kNKqBS6RTyVFzLmiblJ0BNC1ngesbW2 jPUmPiWK5D1ModG4fMTjAkWpgCk0hPm4BUy8kualAXg3u4zOySxxW35cLaCAf69MkAUrzx0bX4d W9mUcSqqhy3C/zd0DfK2RCEw71IALtLtlKqQU346AW4aOXwtWVPvtNUqRkQ0g5fiMp81q57rOUm r53QuCvJfwsVevI6jMZnQKXB1VvxXecZ1CDyUEHdO X-Received: by 2002:a5d:588e:0:b0:391:3157:7717 with SMTP id ffacd0b85a97d-39c23650ed0mr1400943f8f.34.1743494565899; Tue, 01 Apr 2025 01:02:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPu4/9Cw6SxcDwHFmIdroOnVqxkjyJnUFCKmUTC8ChrQesrsO0NER18JD61s9630ANEn3Lxw== X-Received: by 2002:a5d:588e:0:b0:391:3157:7717 with SMTP id ffacd0b85a97d-39c23650ed0mr1400898f8f.34.1743494565471; Tue, 01 Apr 2025 01:02:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b66d0dbsm13543063f8f.58.2025.04.01.01.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 01:02:44 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 10:02:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm/gup: check if both GUP_GET and GUP_PIN are set in __get_user_pages() earlier To: Baoquan He , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-3-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250331081327.256412-3-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5VeKHPuLXYiWnLTkQm982aQqGUTkEnQvmJceRjtX5Qg_1743494566 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 04BE52000E X-Stat-Signature: tf559u9syt8frhy94nr6gut8bysrtq3m X-HE-Tag: 1743494568-310408 X-HE-Meta: U2FsdGVkX1+Vq4vTvlTIlWkVbYpVo60Js1P23NtRB/OGtYSi93c/pPc4viG0S0EjnQQBlqyYa3VYj+vjBsrWWZfxTLzJgTgAFN53oRXueH5OF3H8rCUMiGTurOZZuO85LrCs2j2ZhKX3VLS0KPzle4T6NPMdB2RsLNjU2UXGSXpRDVKRwQWYi6/au2OqwSTi9h5psPWAtTqmPb/40PuLyaauKMNBHWOIDso/+q9H9MlW1jM04fXvs8X9x3xlRmwLm3vdNcOCxfxDwWtvK4ujwu3Jd54BNeLEPy5JV6BwkTHi7T0Fx3IkI52egx8/JbVBsNSbU8+BFF9aAx9w6thJFwNxcyjzjc8Y3MtziRZnabATiDaxLlbrGkEpEkaMtGBrM2b+hX6IG833yDGzHXp4/4/QYAz1wySjsA46CFbayKYe5h9hsFb4yPHUgmnQYVc2YyrcQSeh9TC0zxf3gOmLgeOla9m/L8T/PfJDEY3Cjfjfnb3p9wApNgmSgE+Qei4U4uJYihKTfUwFzzex6cxGyGzJGJYXLZxVZ+puCcW5rimPWq4dj1DcH/am7V1Alt1KZrXQmGIZMnNuraLcV/ZkKuMiWIftpEWFB9c9em5VIuUJkS9bqyFMWIodPVLrYSAVoyg35qAbhhKWZXwA/tRFgo9BG1A+LkaIY3zX6vOGKLK43vOeKCTCBpMn7qHiUwir/TmRx5QYVKtbaB1p+VQLkf/VDMFMTk9b+cLvpkbj7s7fY8qfY7xGFzrGZjOSZaJ3zecpxfje5yuH1JEztemS7z/LjZqKBsuXgXvc8eXXU09X9N7LVoAT/G0nWmDYb5+Owcll67YkSVWrYUnQjlZppuSOmSBh3I069Us1doFoPKfZBQcCootha4RQ8Mj/CHtBs4AhGEaIRaeEqkBkCuMUCr3Nd4LWWAOl/szsstmZlW1o3wxl7vrXxHWxa995OnF5JLL8URcdAmizJmn4FyF ZYqKlcJZ 4qGwt4cFf9UkSDfwT4wqz2m2KQSpXT3SSoLDs+mml/EltbXxeR+JErltEQobnb1HXAIzBYNvQHBZ/dYKmYObr64SOi/bdtx/gcO8bfJor+EuLiw/RgwTnrvpgwpMegzs6n8dzzdx2Rje8RuUpwGEAud++YUrBGGQJTmILZnnLOrefRE1W2v+Cw0T7GgUshnPOILa4QIMVKH0Vuer/Xo8HKSY0r1ZjWrNT4UyFKNTbOIwr3SMdl5tLqLs3VsvMtZyhmr1Mc4iH8wBKC5EtHfQcb6qEBe6Smxfg9GHcsb5jUQYxMNJzhVpvJ4k2f+V2MK46iXMXm5T2aLgrRnPA16vcB8QgdT9mEdmgbyUbz4DUy9uiPzRVDcR5HMdfsvKtcF5ySCEjXgWxdqtFsNk8t8U5rh6YYpjlxDzH9h1Er+Rtc9B9E0g/D/VkBi7qKXBF6ej/UWtI2hX9pbw8DGfEZa2FeLZoQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.03.25 10:13, Baoquan He wrote: > In __get_user_pages(), it will traverse page table and take a reference > to the page the given user address corresponds to if GUP_GET or GUP_PIN > is et. However, it's not supported both GUP_GET and GUP_PIN are set. > This check should be done earlier, but not doing it till entering into > follow_page_pte() and failed. > > Here move the checking to the beginning of __get_user_pages(). > > Signed-off-by: Baoquan He > --- > v1->v2: > - Fix code bug caused by copy-and-paste error, this is reported by > lkp test robot. > > mm/gup.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 73777b1de679..f9bce14ed3cd 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -847,11 +847,6 @@ static struct page *follow_page_pte(struct vm_area_struct *vma, > pte_t *ptep, pte; > int ret; > > - /* FOLL_GET and FOLL_PIN are mutually exclusive. */ > - if (WARN_ON_ONCE((flags & (FOLL_PIN | FOLL_GET)) == > - (FOLL_PIN | FOLL_GET))) > - return ERR_PTR(-EINVAL); > - > ptep = pte_offset_map_lock(mm, pmd, address, &ptl); > if (!ptep) > return no_page_table(vma, flags, address); > @@ -1434,6 +1429,11 @@ static long __get_user_pages(struct mm_struct *mm, > > VM_BUG_ON(!!pages != !!(gup_flags & (FOLL_GET | FOLL_PIN))); > > + /* FOLL_GET and FOLL_PIN are mutually exclusive. */ > + if (WARN_ON_ONCE((gup_flags & (FOLL_PIN | FOLL_GET)) == > + (FOLL_PIN | FOLL_GET))) > + return -EINVAL; > + We already have that check in is_valid_gup_args(), that catches all external users that could possibly mess this up. So we can just convert that into a VM_WARN_ON_ONCE(), and while doing that, we should convert the VM_BUG_ON() above to a VM_WARN_ON_ONCE() as well. -- Cheers, David / dhildenb