From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5904C25B7C for ; Fri, 31 May 2024 11:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2673D6B0089; Fri, 31 May 2024 07:31:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215DC6B008A; Fri, 31 May 2024 07:31:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 107686B0093; Fri, 31 May 2024 07:31:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E58D26B008A for ; Fri, 31 May 2024 07:31:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 863F0120694 for ; Fri, 31 May 2024 11:31:57 +0000 (UTC) X-FDA: 82178476674.15.AC14E67 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id BCFD480011 for ; Fri, 31 May 2024 11:31:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717155115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yZ8XCM+k7pQ3mKy3rOoXian3tQqZWLz/2H/WZVOtlDc=; b=S8VkdI4PXcSwi65g5teTGWXpGzLL9FeFKw2BxpxeFyroyvzXBG+fryTtN/p2vo45kQBjlU kwy1SPOGNXNzZEVutJmUKOzFc+rsrCEwwyRB/yCFchhuoOzo5ZdjxMsW+Qkq0gdUPAECY4 UKvLmuO603Il8WRwDDIVq0jDlLNVEbo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717155115; a=rsa-sha256; cv=none; b=HlzOogKZRs9qg++Ncl4DWCWkDNFvRF4+1cEGyjWK3MUcOuPxEYXowyIcTaNgJxbktFbAro 6fnspp/V1ts8V49xeEUR3/jSeyFLbRFHS09/UdvpP9rjYdJyzFUBjEME2fAogJcKxfTaLI LHQS51fq4J7T9DznC/sUiwpv0c95a6w= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F089E1424; Fri, 31 May 2024 04:32:18 -0700 (PDT) Received: from [10.162.41.15] (e116581.arm.com [10.162.41.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EAE43F792; Fri, 31 May 2024 04:31:52 -0700 (PDT) Message-ID: Date: Fri, 31 May 2024 17:01:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] mm: Redundant const parameter? From: Dev Jain To: zhouchengming@bytedance.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BCFD480011 X-Stat-Signature: 9o665d98bonsijrys5pyq1qnncyx6rem X-HE-Tag: 1717155115-732272 X-HE-Meta: U2FsdGVkX187HnLviBwspU2ukBM2zifeSDgbqJwWirBpkuZw5/WVoboZ2MCbZZfPpVJygsVtfT3ALMNM0UFxvJ6Qzem8NBn2Hynp3STMkvudGiMZMEbHLn4jJFa20eXnv5LOtSV2ax1x3ArLovIF4T10IqxD3sKmtbBdK8J01/uY5d/23+C+h47fkgFN0MwN8ZUQAZ6SfkvRKdmBQ2c91ph0i9ZewpXKSnc+wg+w/e1GkvxdEUEw8pVdePukNzv5QZNghI9dea5VXiRjjP2VKVunxLgkTjmUCJo+qJNM0IbqiIDXpdWgBpD6UZpiCl7xDG+WVebXbP1UbwKW4aWpxI/STXIwvQPIWv9ahY3Fpc0o5NYQMHJ4d7kb0W5TWFubbFhGIPOknxVHfq+GL28TCaA6gTcTcQT98/5kvrZaju5v7red7D2bAwUob9kTvLWUIPFHfzU9bU60fN1ZFpm527u6eLO+Rt3Su0O5INblrZEipGw020YrD0zkqishr70rDEzf7FSPS+8nXM4TV9/DypFbTChyzjGa13v2tFgO84bJLGAx2Eq8Hb1/GsVO+VrRg/jS9q5r1M9tD0awCuJdJ37vuuDVjUTsVq5yWJngwIAX965BJWd3tZ+d7y/TfI4e9/t10SmQSFPZlvDEfCHA+hwLztR0b9oIpGo72FW7MCfsJAE05F2Y0L2pFVgELWjtJgrS/HCNn0r9CL+rXHo5GdmP6HO6k7zcEfREA5fbmEdYXCPMbZ086yk8dT4NaLlIderxlOcZlIPVe9OoIs1+49nD3a6ErIFxOWY6jfgTKoy+3kmgrBehebBVAGOpoF9RXXQRrrDN7hmRt2MSXY8n/diJhTpctXdcbGYfkgdyM728BII8N5YXEDGADiwhlJcpLE0hUlrQBIufNuxWG6a4/ylrvf7GUP17qTUKDFcGgEMJIuVz9fCYejQOwh5QSX91fiL4ftmqAFnIMWJfhPV Dbra72mW hEAJdZezOctX2MgkWutEh/Sfm985s6a62AYWfbjGmJvnrOqf8zHyw+6v1IjDZiRlfyahM1Mdn0CoKjZtqifrSQhMGlZGMLRyuhGGqfukFk2j1uzJ/ktJSuMwL1BzHeC855wJP2lgdUtD3PKfFbnoPRqXI74FHLYpmXLo+VWKlPifdq48CAnFUueiER5BrlPlvYJiC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I guess it would be better if I send this as a patch and wait for comments. On 5/31/24 16:42, Dev Jain wrote: > Hi Chengming, > > In mm/slub.c, you had defined slab_test_node_partial() to take a const > parameter. > > Is there any point of taking in a const, when you are anyways > typecasting it to > > a (struct folio *) from (const struct folio *) ? In fact, at the place > where you call > > slab_test_node_partial(), the struct slab *slab is not const. > > Please comment. > > > Thanks > > DJ > > > >