From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307C7C54F30 for ; Sun, 25 May 2025 10:24:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D3496B007B; Sun, 25 May 2025 06:24:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95D736B0083; Sun, 25 May 2025 06:24:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 824266B0085; Sun, 25 May 2025 06:24:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 628206B007B for ; Sun, 25 May 2025 06:24:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB8B71604FE for ; Sun, 25 May 2025 10:24:37 +0000 (UTC) X-FDA: 83481046194.29.6DE435A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 50CC418000C for ; Sun, 25 May 2025 10:24:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="W/KVFjDf"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748168675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CZC2aLVVRC9MSj++zrrkRN5Czmbv+GL6NoJprKEHhc8=; b=gE6m/kEdgRTmsg6W2tgv5noCdDxCLAln6y52TpNpWyPeQzPf6AHbqcGLZ1HDJPU/M+imJW ByLANhIwXlNjQZefLbp2IzO74i0UxGcqIGq8G9xdJWgoJkoKxrb47Pj/stGd0QtG13ioW+ L1urD+wZqQoyv4DsypanTwaRZCZdBLc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="W/KVFjDf"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748168675; a=rsa-sha256; cv=none; b=iM0tXI4F5oxg0+d4ufiz9EC1oukf6m/OWIeiNfvR0qoesswDFDWYjpMdTLA19nYJKZS8q3 rIKPYiZGO/69+zvyUWbZ5sR+fo/Nc4Pp9VADFpwk9bOsi+/eskB9VGM1tgTD3b2gsmUWEq W0+sHwrF4w7wNQJF79tSDBWrCifUztE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748168674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CZC2aLVVRC9MSj++zrrkRN5Czmbv+GL6NoJprKEHhc8=; b=W/KVFjDfOsEXa8izpPfUissvqincYJR/95Fhwn/hVkUua4Z1TcFurZR5R5V9BZyFRREQyV kR173r8zGI6ekAkJ3nn51o06oCR0hU1UH0EHGcUMp3hWBUip0kdq+f8nRoICPaIZ45/nEw aBKUElWm20khiGsMI/st9go0u3CJU7c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-daAXiXa4MmKhbJcIS7FtGw-1; Sun, 25 May 2025 06:24:33 -0400 X-MC-Unique: daAXiXa4MmKhbJcIS7FtGw-1 X-Mimecast-MFC-AGG-ID: daAXiXa4MmKhbJcIS7FtGw_1748168672 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d209dc2d3so7882595e9.3 for ; Sun, 25 May 2025 03:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748168672; x=1748773472; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CZC2aLVVRC9MSj++zrrkRN5Czmbv+GL6NoJprKEHhc8=; b=uvPpyeTY8I4p9mmadD+t67cRZGqniCrMYDUysubW4Z2FiYxlA0dgzm75cstWO+gHPd /ZuWAlciJGuBvVhfKbIUAgB+9tRzwDCNJAjCfFWyjEyE9EFwy/26d0STLC5O9FIXFFi4 gk+Q8LltZkYSvRfKwM63YZpu+oA6wfCbO/eFDm6qYFa7hBhkAM5AFyKy8pSh7SSlpa6E lsJsvzOIEGZGtwBrhnM+C8FY9wzDXhCg2FCatyB+o0GJTGU1zoeGb+oyP8zgxzP+Mo2v RbG3rf79aTjBkg2yIfEvEEGTblm+Fj/1/cIXejXN8Fk/l35P8jg2irB2pL83iBKNno41 RZDA== X-Forwarded-Encrypted: i=1; AJvYcCU/HAt9ALhSVHFJSMMGuNxrRyI+rm6PCXDsfmF2BGdatcGtbur+xBLzOOE5WOodmUQ+d2YvWD5LHg==@kvack.org X-Gm-Message-State: AOJu0YxxYZuN2bZaAmxcdsYf/T93PidwtdJCVsf0dTrKzgNFOdEpnkkK cwzfFsD5xc8Not3Xe0GoxHv8AprU4uf01E3DwoC1rsiq46BZoADM8pzJDBytt0rprx/Jlc6LIk3 pIY1nrR+YRVsJFmKQq+DJymOOB5Cwkw/PxNBhPj7Gf77/aYJcocZj X-Gm-Gg: ASbGnct0gujoK+5bYp9llhW8f969tviY/LpDCMpjUEc660X7Hv96NaON6ACoXkdt/5S JXRknkxXXyCvXXpbD2EwV507ZpXT5mSHwu0xP7OUbLTQa75mNsmfYi8fX/zgfABu7TfdXb6vSag 5QgkC2Z2wD7Tyo231mKW4IpSsfgJoyFWCDK9y35fYwhXO7fQqQF0N7uozGhLTf+sYmgswLW3lGW jt+o7DqJXzMjvnud17kd435Tz3kRD9f1Q/vteK3zTnzmz7VSvIaoVLJ4aY8T8cExesrhdkqAyVK 668bQ1j7+Plnu/7sBieInkH5OWPIz0aq7FCN/xXF3w== X-Received: by 2002:a5d:5846:0:b0:3a3:5cca:a56a with SMTP id ffacd0b85a97d-3a4cb46c42emr3954967f8f.32.1748168671823; Sun, 25 May 2025 03:24:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF81BtASRSIVPVFuqf47Gc5RFX+uSPO/1kvbsWNsgC3lWdOpQxwUzVB+DI/dMdwMcqIWMaYYg== X-Received: by 2002:a5d:5846:0:b0:3a3:5cca:a56a with SMTP id ffacd0b85a97d-3a4cb46c42emr3954951f8f.32.1748168671483; Sun, 25 May 2025 03:24:31 -0700 (PDT) Received: from [192.168.3.141] (p4ff1fb19.dip0.t-ipconnect.de. [79.241.251.25]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f78aeb8csm201185655e9.28.2025.05.25.03.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 May 2025 03:24:31 -0700 (PDT) Message-ID: Date: Sun, 25 May 2025 12:24:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Oleg Nesterov Cc: Pu Lehui , Lorenzo Stoakes , mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com, Andrii Nakryiko , Jiri Olsa References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <20250524164516.GA11642@redhat.com> <20250525095926.GA5391@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250525095926.GA5391@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3S6-Cct0naMPOvL3Wo2a54z-OCQRi9R2byWxmn47U2s_1748168672 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 50CC418000C X-Rspamd-Server: rspam09 X-Stat-Signature: aypjjd6x17px6jxnh93q4bgkp7pi1d8k X-HE-Tag: 1748168675-30509 X-HE-Meta: U2FsdGVkX18BvH4Dc39j4jS4YOaK0qjCaNboC54YA7fsFjUr08iUUwjA76T7XAU688tOsT2azqm4KJKloHVNvwDgFieSPoToHe1ZFvDnC4aLng3QM52VW/73+UKGsT/FGtcLBT7pEx5x9jto5jCWZRMWdxLw2gQxqrn4YOhP2xPs7O4sSQX5nElbpCSYCkiU3NcNoXZbxu/IlBWKJZgi4ttsDSQLfwMxakxmcIinOfLg7suKnSyQMig31cYGQV6ENAOQeA4F3txOAcvyJE9Ag3SNjRYjcaIqxcdvPc7nNqx6x1quH+wQEsANkuehcnNHiDL4MTBM24dpAxPi2Lln2EOKjYYZILOqHO5tDPpTJAurSP8RdJrB7VJNykcLWb/+dDFRZlNp8vuYrYAxnd7Gl5g1rTN7xtAS6E5l4qCRsDK+d53v2+Vee7X0sTaao3DRet9XPhhnV9jD4oc0DSvNH1CT/TCY7hUv7zyRxplNIRhNCZJ+Xw9bd0RH0FmV9etwzUDjIPu0ee8GdxdiZ821XmMM7el71Ww+EWroLKLomb2LCVyosvwzMqOP1aKfiIguBwUJZYnErS3W8LZxSKwIVDEZ6dFyockXOQM2MjPMsEi/1t9acMvpLO+v7Te1gThhpuFic/xjuSW8MpUMjk7k86bzUSuojlYHujlGAS9DKsI3Ko7mfCf8/NTrFPHYsYfo5KaC43JCgpSKDTU9ibDUji6Vo794UUt1a23MTOW4Tnpv6wKPjEvIu575wtE8jas4LIna3ICrr4Jm+MdCAtDTBoDZOvF1NCN1XPvtA44bWg95dIB+2aqwyyBOncbPTnrdFEM/NFcM0Y1bqqBFUf2snYhiZOf9/5tn7ZaHjRN7iH/8SpFqT3LqneOXFqRgQi+c5HogaXt0BYk4Z0HjPT0nXeL3eszPVt+HHQnDrUid2OnJEvm+QCaWfgHq1WX7sWQv8ppfmy8tUbWT8BAdCES wV2zjmNT oKqL6PX8Z0j5bFaLE7O96gMqt6JdzHTs+CuHjbFiL14aA6DeBvVqnko0AmkIbcaTkQpWbafcNaXq9fKhES1DPXxUrPYkBxsxGTz3d1pI3/z2ARCXnrqauUQVDCcKgmSM00lglAG8C9XsNE8Osnn25ZlyZNB6hZVy/pWRzJ5YFW//CBq7bE3svwW71UpTe0JZRQzwrmxrSwdufBC/q8zPs3Inw9TPmGqSK7xkl/UvjOM/xyUArbUqjVP5Fm0zZeNOMGD/qYrKlYG5rdrUwb0CcIPeI0I6Q6Jlstk/8rvixjLKnSrkgXNxc98Jvpl9SeIoqsI3mNQIyI8eef7DR07VJFc5qOq+K5pkdu3Mq93oBkAMW4NkIZzKBpZ9Ng/1CtQJrdpdsOp+kK1g74A+zIVL69aPWftCpTTwFUrV0dZqWtoGPGN0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.05.25 11:59, Oleg Nesterov wrote: > On 05/24, David Hildenbrand wrote: >> >> On 24.05.25 18:45, Oleg Nesterov wrote: >>> >>> To be honest, I can't even understand this part due to my ignorance. >>> What does "the old uprobe anon page to be orphan" actually mean? >>> How can the unnecessary uprobe_mmap() lead to an "unbalanced" >>> inc_mm_counter(MM_ANONPAGES) ? Or what else can explain the >>> "BUG: Bad rss-counter state" from check_mm() ? Or there are more problems? >> >> Essentially, we end up mapping an anonymous page (when install the uprobe) >> after preparing the new VMA, but before moving over the pages from the old >> VMA. >> >> So when we then move over the pages from the old VMA, we overwrite the PTE >> mapping an anonymous page (due to uprobe). >> >> As we simply overwrite the PTE that is mapping an anonymous page, we run >> into inconsistency later: RSS counter mismatch, memory leak, etc. > > Ah, I seem to start understand... move_ptes() doesn't even check *new_pte, > I guess it assumes pte_none(ptep_get(new_pte), right? So the old anonymous > page is simply leaked after set_pte_at(mm, new_addr, new_pte, pte)... > > Correct? Right. Ordinary page faults cannot happen concurrently, so the assumption is that there really isn't anything mapped yet. > >> We should never be installing an anonymous page (due to uprobe) into a VMA >> during mremap() before moving over the pages from the old VMA. > > OK. But do you see any reason why uprobe_mmap() should be ever called during > mremap() ? Only when growing a VMA: we might now cover a part with a uprobe, which we have take care of. not to mention munmap() ... I cannot think of something that would require it during munmap(). -- Cheers, David / dhildenb