From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DD4C6FA82 for ; Thu, 22 Sep 2022 06:36:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED6386B0071; Thu, 22 Sep 2022 02:36:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85F96B0072; Thu, 22 Sep 2022 02:36:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7451940007; Thu, 22 Sep 2022 02:36:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CAA466B0071 for ; Thu, 22 Sep 2022 02:36:22 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A38871A0B6B for ; Thu, 22 Sep 2022 06:36:22 +0000 (UTC) X-FDA: 79938762204.05.8E49B23 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf24.hostedemail.com (Postfix) with ESMTP id DBC2C180008 for ; Thu, 22 Sep 2022 06:36:20 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VQRI4-C_1663828576; Received: from 30.97.48.87(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VQRI4-C_1663828576) by smtp.aliyun-inc.com; Thu, 22 Sep 2022 14:36:17 +0800 Message-ID: Date: Thu, 22 Sep 2022 14:36:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [RFC 2/6] mm/migrate_pages: split unmap_and_move() to _unmap() and _move() To: Huang Ying , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , Zi Yan , Yang Shi , Oscar Salvador , Matthew Wilcox References: <20220921060616.73086-1-ying.huang@intel.com> <20220921060616.73086-3-ying.huang@intel.com> From: Baolin Wang In-Reply-To: <20220921060616.73086-3-ying.huang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663828582; a=rsa-sha256; cv=none; b=prjoetc80+l3DymCN8Yjiqc42pyz6UaIWsVPnAT+8efIwVUk1Yj8T4+G4fzDDWQxXefO7x B1KT/je2qpNN1Qh8KzwsSj90MEZQPedjQYRMk44hDDMjKbb3lqQj1ME+vfgkwhxYKD234V Vo6EZadyc3clsVfB9Hl9ecEJ4Jh4ZYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663828582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fl0wlTC33AcTPxdaRLLiD3R7c5cfwVsXvsNdX5241Yc=; b=PgaZjiV/FPd3HISy9p1pfXM2PhpZQgJ/90BPAhRO8MPWspQT6H8y6fngHldtIfvNc1MJf7 kgif0PDTSTckkEtPR2u4NsvsQ5HjHxo69ZIVOMp+Ca1nImlEQ5wHN5vDm+EYCiUzipGaA/ QeJGf4e/8He5qpyrkQaOJnoC/ii7Vxs= Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam06 X-Stat-Signature: o7cnz468bnjxo4p796eitkr6ps1oe6c3 X-Rspam-User: X-Rspamd-Queue-Id: DBC2C180008 X-HE-Tag: 1663828580-926697 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/21/2022 2:06 PM, Huang Ying wrote: > This is a preparation patch to batch the page unmapping and moving > for the normal pages and THP. > > In this patch, unmap_and_move() is split to migrate_page_unmap() and > migrate_page_move(). So, we can batch _unmap() and _move() in > different loops later. To pass some information between unmap and > move, the original unused newpage->mapping and newpage->private are > used. > > Signed-off-by: "Huang, Ying" > Cc: Zi Yan > Cc: Yang Shi > Cc: Baolin Wang > Cc: Oscar Salvador > Cc: Matthew Wilcox > --- Looks good to me. Reviewed-by: Baolin Wang