From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026FAC71130 for ; Tue, 8 Jul 2025 06:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 847236B037D; Tue, 8 Jul 2025 02:19:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E546B037E; Tue, 8 Jul 2025 02:19:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75AF46B037F; Tue, 8 Jul 2025 02:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 676AB6B037D for ; Tue, 8 Jul 2025 02:19:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1CD91B7D95 for ; Tue, 8 Jul 2025 06:19:31 +0000 (UTC) X-FDA: 83640095742.30.4365D20 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf23.hostedemail.com (Postfix) with ESMTP id 1A9D9140007 for ; Tue, 8 Jul 2025 06:19:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VIQBwNbX; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf23.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751955569; a=rsa-sha256; cv=none; b=j0vvcScdLuCyFmD9ztGAo2jZWp9NZN4wGLFTTqGkUqqqLiVHe6YRN+O6FBXit+DHloo0/t P7WvRPijaNUg1uWPvHFmAEHQ0/Vj5hxz8wSehxJGPnys1qRpTTyEExt2fSKdD30/TV1RSK JbqO1NJh/MNRKK/fTLeShiA+kxHWog4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=VIQBwNbX; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf23.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751955569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qIRx+HCehqqza2IJhsneJV4WjfRLShJN2Hjm8Xb7L4M=; b=XAXUSEofwLs8cfJE9V75ziw5vhNlvhUSoMykCLDAk1vpArnelKTtNpLd4pmy+yU0jUjJgk q3TT2TUFb7StJIzcB41ZMgoivA4rSUO2acRzQfVKJVDk74kuTcUYI2/t+7N8Ixne7Lsr6p 5pwztqrbccW1pwaPG4LWa5WqqJ0rL1I= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1751955565; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=qIRx+HCehqqza2IJhsneJV4WjfRLShJN2Hjm8Xb7L4M=; b=VIQBwNbXOd70Lvt3ot2u1y3gihR3QZrn+5MLAp3w7iIp76/HzC845T90vEsnIKmVhZKZU865nMAtn/+QppH7eOD7Km/2YqA8XgasTy2Iqix8W9f/W23vUqSe58PmzBLU84qINnNK27y/STV1VMawq1EXDESG4PEW+eHfMs/7xd8= Received: from 30.74.144.119(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WiLFdgJ_1751955558 cluster:ay36) by smtp.aliyun-inc.com; Tue, 08 Jul 2025 14:19:23 +0800 Message-ID: Date: Tue, 8 Jul 2025 14:19:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 04/15] khugepaged: generalize alloc_charge_folio() To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-5-npache@redhat.com> From: Baolin Wang In-Reply-To: <20250702055742.102808-5-npache@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1A9D9140007 X-Stat-Signature: xrpeqcs7rhu91dw6hmfa9js5m9doddx5 X-Rspam-User: X-HE-Tag: 1751955567-814102 X-HE-Meta: U2FsdGVkX18pqbJ3+mvuB6Pucjuo01m/hKrmU5aflAVu+CivF8etzcX5yyi53D7BnR8xPxLBsntiJE9YXz2Og2LCXq+FEPikPfAHGxwYoNWxTp8qYz8fO3QkpB+PIo0WsZK5WOo7aAqX4U25MouT93e/8GIP6JaPC7NAeze+LTrsVpmvID/p9HMiz3F1CtEGiWRasThdvSy7eq6CDrxyUmeQp2z1a9Et7M8UvN6pH2U0/ECjAuvmjboFQq7+3GoM/tIJhU9FnEhcEcUVUX0KkycOhIMcY1hRhr8lREFiqqhyAmajkiccbieGDXjbHwWYeWrnz7nm5qN5n2zHrkzTQNpa53uH7r2DXxu3SLF9zQ3QWBkVG0MbSwMxMbsh+tnilUy35b5W1uCUpAXRGIcKm0881YtWuNyXVTknAOTOAU4AE1gJriMxCyi8uCPE4D/FV8p2UHyhB1LRz69dx8piyB0UMSpmquQffWt4Yb8puO5T6CT3CapkXeQfiH7Mxn0KnxUsyH5+qojwDPMMEec2pOWUx6grkDCbCNrEyDwOwKOuxJAdHpPex8+7AM/vU7HBZAQF0gA1BT7apy0wzcDDGWfZpqnvRhurWbUP1LIbwyE1f0PCMA3A0iETI4TD+oQt5iASlIrHDlxpdiwkfCyX0rZxHG4Q6BjM3SO+VGArtwnv0wy22IsBNTRoxzkAxjFHMIFT0IPhVzhMrzsmxTyjX+m9LaOF5xSnL4ICZKG/eBZ1zlDrkLHHHzTZCl/rN7BI8yWFFjkgSdtO0NKjHwQl1IcugN3xhKoY2duH/7aGNVOYI2UNPLSkPp0wQNLyK+eqY5QVJjmTV+zqClt4a4d7UspvoBHhaU7Rf1lLd0Nb6XU5rghCspS3cUm5Z43HHGvNSyisAb9h/6SyvNgX4p0jGsIXk4SijkisC+YYnxPG1K8i0SdP1XOC6BRa3121XNHql7p44ivqtdz49ErKAyr 7lrp47O8 SVBnujLlSW044Lr8dNW44Lh7e/+uMbb5Wzs29yBj2BnWeazVEYj25hj0zsJROgZyz2bcNnhugurQ1zTOwjtCKJ7Box9SyTUiHPmZqTezh7qKgoFur6tTESaZSysf6FWmWmhn0ClOsN1cq2maVMMuyMWE2FTDRu4uOKg7/g/NtrTJp5XfU9wawbLGfbANjh53UtENj2sDueyXw5tMswLA4kPMS3pLkOdvxPfVfbaIbS4jtWRsUGBsgg3El7M1XcIybz9N/DXYtvfJXFW4NhAeOAItdsXi/BmAEO0wONyO4CfDIAt6Rvnb8+SdVjBUdM2jd2C7HNx3H75MCO07jX8sLEBxov8Lxapr7d/LmsGVt2UBvYovWf1E54Fpvqafa7N5izIUIRVLjsFUyBEsSHYLvCiu7Y0rn+9kcX1SSFpcYRc4bf/F8CWwarBZNhJ7FWJUcFdJYAQ5QbotSfQxCMJ2ZMI3/GmN7fBd8pcGyACiMvVRdkmGjW2XF7WjMERJ3qgn2UmfxND/DfzmU83XTrC0Usb9/Mhz1VvjTpsjI94k6Q36mfGo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/7/2 13:57, Nico Pache wrote: > From: Dev Jain > > Pass order to alloc_charge_folio() and update mTHP statistics. > > Reviewed-by: Baolin Wang > Co-developed-by: Nico Pache > Signed-off-by: Nico Pache > Signed-off-by: Dev Jain > --- > include/linux/huge_mm.h | 2 ++ > mm/huge_memory.c | 4 ++++ > mm/khugepaged.c | 17 +++++++++++------ > 3 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 4d5bb67dc4ec..a6ea89fdaee6 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -125,6 +125,8 @@ enum mthp_stat_item { > MTHP_STAT_ANON_FAULT_ALLOC, > MTHP_STAT_ANON_FAULT_FALLBACK, > MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, > + MTHP_STAT_COLLAPSE_ALLOC, > + MTHP_STAT_COLLAPSE_ALLOC_FAILED, > MTHP_STAT_ZSWPOUT, > MTHP_STAT_SWPIN, > MTHP_STAT_SWPIN_FALLBACK, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index ce130225a8e5..69777a35e722 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -614,6 +614,8 @@ static struct kobj_attribute _name##_attr = __ATTR_RO(_name) > DEFINE_MTHP_STAT_ATTR(anon_fault_alloc, MTHP_STAT_ANON_FAULT_ALLOC); > DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_STAT_ANON_FAULT_FALLBACK); > DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); > +DEFINE_MTHP_STAT_ATTR(collapse_alloc, MTHP_STAT_COLLAPSE_ALLOC); > +DEFINE_MTHP_STAT_ATTR(collapse_alloc_failed, MTHP_STAT_COLLAPSE_ALLOC_FAILED); > DEFINE_MTHP_STAT_ATTR(zswpout, MTHP_STAT_ZSWPOUT); > DEFINE_MTHP_STAT_ATTR(swpin, MTHP_STAT_SWPIN); > DEFINE_MTHP_STAT_ATTR(swpin_fallback, MTHP_STAT_SWPIN_FALLBACK); > @@ -679,6 +681,8 @@ static struct attribute *any_stats_attrs[] = { > #endif > &split_attr.attr, > &split_failed_attr.attr, > + &collapse_alloc_attr.attr, > + &collapse_alloc_failed_attr.attr, > NULL, > }; Sorry, I forgot to mention that you should update the 'Documentation/admin-guide/mm/transhuge.rst' file for these new statistics.