From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Nadav Amit <namit@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
kernel@openvz.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/4] Make place for common balloon code
Date: Thu, 18 Aug 2022 09:43:29 +0300 [thread overview]
Message-ID: <e692b61d-7760-48bd-b22a-9ffa9162b4f7@virtuozzo.com> (raw)
In-Reply-To: <20220818044123.q5yzdaszcxl7mcl6@riteshh-domain>
Hello,
On 18.08.22 7:41, Ritesh Harjani wrote:
> On 22/08/16 12:41PM, Alexander Atanasov wrote:
>> File already contains code that is common along balloon
>> drivers so rename it to reflect its contents.
>> mm/balloon_compaction.c -> mm/balloon_common.c
>>
>> Signed-off-by: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
>> ---
>> MAINTAINERS | 4 ++--
>> arch/powerpc/platforms/pseries/cmm.c | 2 +-
>> drivers/misc/vmw_balloon.c | 2 +-
>> drivers/virtio/virtio_balloon.c | 2 +-
>> include/linux/{balloon_compaction.h => balloon_common.h} | 2 +-
>> mm/Makefile | 2 +-
>> mm/{balloon_compaction.c => balloon_common.c} | 4 ++--
>
>> mm/migrate.c | 2 +-
>> mm/vmscan.c | 2 +-
> I think we don't need balloon headers in above two files at all.
> I don't see any references of balloon functions in them.
...
> Since I don't often look into this side of code, it's better to confirm :)
Yes, you are right. It passed a visual and compile verification.
I will remove them in the next iteration. Thanks for pointing it out :)
--
Regards,
Alexander Atanasov
next prev parent reply other threads:[~2022-08-18 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com>
2022-08-16 9:41 ` Alexander Atanasov
2022-08-16 9:49 ` Greg Kroah-Hartman
2022-08-16 11:47 ` Alexander Atanasov
2022-08-16 11:56 ` Greg Kroah-Hartman
2022-08-16 12:00 ` Michael S. Tsirkin
2022-08-18 4:41 ` Ritesh Harjani
2022-08-18 6:43 ` Alexander Atanasov [this message]
2022-08-16 9:41 ` [PATCH v2 2/4] Enable balloon drivers to report inflated memory Alexander Atanasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e692b61d-7760-48bd-b22a-9ffa9162b4f7@virtuozzo.com \
--to=alexander.atanasov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=npiggin@gmail.com \
--cc=pv-drivers@vmware.com \
--cc=ritesh.list@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox