From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DCFE77188 for ; Mon, 6 Jan 2025 06:40:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 592FC6B008A; Mon, 6 Jan 2025 01:40:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 542806B0092; Mon, 6 Jan 2025 01:40:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4317D6B0093; Mon, 6 Jan 2025 01:40:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 274126B008A for ; Mon, 6 Jan 2025 01:40:51 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CAB14A1302 for ; Mon, 6 Jan 2025 06:40:50 +0000 (UTC) X-FDA: 82976079060.24.AE959B7 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf04.hostedemail.com (Postfix) with ESMTP id EC24A40009 for ; Mon, 6 Jan 2025 06:40:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=SThCNQdB; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736145649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DFltLzutjLChajYcQ04RjwFDr7gm83e9w/SFboQ59lY=; b=nv02jngukypxtJO1RjUv2LL1eVRY//am9zJ7lCmI5yEXp1AB0e4sAEMvgFEdlZ4my3vWKW d7a407TOMYBEHJJ0lcU1kRTgqjayAGCn8l3RxIK15mtdGPq9Ayx/jwNTAU8OZxQg9vscKT RWepDDOH9EfIEDXvF2c5m8a+3+ierRg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736145649; a=rsa-sha256; cv=none; b=yyJwwSzOPBBV6YmP50p90wYQLfT+81k+3aPQJvDm2yuUXRHvjejVlfAuBPBGoQW9R+RIte 6KoZz3u5r4yiYnKJh9HwaGFY9xdmRyq4X0zHAhYbRf6e+bv1yNqH1HPgLrUZ/lk9qdKhCv LAOh+Kcfcsi9luar+tpkiBSpuO8l+QQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=SThCNQdB; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1736145645; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=DFltLzutjLChajYcQ04RjwFDr7gm83e9w/SFboQ59lY=; b=SThCNQdBqhV/q6wo7BAaVq5jKRCGxLL3RnziBoVLKlzEy/qgtUBh/a3oPvGB4BKf1FR0IX3lj/Np7u6JOtPvrfhQnr4yrzWp3OLw9hlyiyi1k3u9Uh+xb+GeWhdApke+2ZrRQFpR+g/FnHDXlh+DmaOQJVTXRCiJHmjFlJ7OTiA= Received: from 30.74.144.118(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WN01L1._1736145641 cluster:ay36) by smtp.aliyun-inc.com; Mon, 06 Jan 2025 14:40:42 +0800 Message-ID: Date: Mon, 6 Jan 2025 14:40:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: set folio swapbacked iff folios are dirty in try_to_unmap_one To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com, david@redhat.com, ryan.roberts@arm.com, zhengtangquan@oppo.com, ying.huang@intel.com, kasong@tencent.com, chrisl@kernel.org, Barry Song References: <20250106031711.82855-1-21cnbao@gmail.com> <20250106031711.82855-2-21cnbao@gmail.com> From: Baolin Wang In-Reply-To: <20250106031711.82855-2-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EC24A40009 X-Stat-Signature: c48ph8sa8xoyfeypfg94o6uyzt3djjk7 X-Rspam-User: X-HE-Tag: 1736145647-536149 X-HE-Meta: U2FsdGVkX1/HZnKu6vKtcug/WIt9808OEnrQAuhAhaY4fUjncrgaag/Tt1rLgnBk8FurCHIb2/AktCbe+VAb6R5gXhk//agYXBrtHkE2L00c72TtUWUAfleYnSu/kmQHndzsaZ9OqXX3IrXWkV0WQ0SrtTGS8D59jT4daeALAxOTVs+raQEGwT+mQDN14b/ord7aQRy3UZxbQ/Fp/aJ3erfguAfHPKw25Uiy1OVnsOjKUsj1vh7pL92EqrSGa15il9ojlo82M6vSvlJhQYCr3pMBag48NRnei7fAzSzWOXuovjosE7Ek3leROXYmzXbJDg5y4ptBnY+IGktOKW1ZZL6Tygbtd0yFQ9i+3X+E4lvY5/mWjttsc1cTm8lZPVJIJ2x+5f8if7JmyWl/bfEZttL/At81Lx0SkuozHckrznPVjQePhBP1PInBfgzNSjfEcPDKmfHwoMeXu/6J0BldNSZpHtWSHJRYd08zGJnE+yRQRttZxD4FQ/p/O9O7FzobhLmlCE5TFIfULVJVe9wN9Z0GbckeffqIjo/4iouj19qykIFLZt2QdFGpVxCt8azPI8ugY4lzIr3T6z8WFzw7FGKUCg7ua9dDOQo3/lMdeEuefT15/SwyJkJWB+fJw/h8R4Q2nCl1k/DGPGyWIg4lmUekp5Tylh95KJ3B4pM42y5/MFMtKu7Z5Q43euSHt07Fzi+lzm0CH1410kCXJ4sYwh4bG6TewaTaxehtGI4FI2H1oD2zjhp6koK/XMggb79NRN74g6ysd0uJ4pprlmIpL9QOxZixBQj9MjzXuuAc516DmwaZYHplXBELXqM9m1eRQHWlKMdzgRBvagbwI+HBU9Z61sT65elqC6USCUYdkifyzONibOk93vkjOtSBQRHJGY9OOpD/Po+X2vtR3uu82POY6IKx36AZSaJhKQRGmPvbqCdR9ycfqu/uf9VMaG4qvWAyoWaBgxEcg+5qJ+2 nchadwl9 C1FOIpyXQ3wlYIgsTFpXW87dS4L/OXcNvAXSdBK07g6mS8RSgE5p7akNT2Ol+kZTqDDOpabNd29RolyC6coJDY5WssMtiUsnw/f5FThXJGazRptgYpzV2kr1qF6raHpkFyAZ1RWIY/5uMTi/1tT0USOTUB9haguyJFjhoCu0mjR4dg9WUwewmfT8m2kZYqvKHj216ZRBfqnBiVjHtL4SuzqVYSGr10k2bbzOUs80nYmthhv1/BypmJ5zI4bZxWRQHERSKLia84Xf9K3QaLssiTjvITRfhey7NTS/k9PkgHBflq5oiEqAImVxO2+SsKIgqZvZtsKRY/W8ICtGQn4Zkw/PLBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001898, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 11:17, Barry Song wrote: > From: Barry Song > > The refcount may be temporarily or long-term increased, but this does > not change the fundamental nature of the folio already being lazy- > freed. Therefore, we only reset 'swapbacked' when we are certain the > folio is dirty and not droppable. > > Suggested-by: David Hildenbrand > Signed-off-by: Barry Song The changes look good to me. While we are at it, could you also change the __discard_anon_folio_pmd_locked() to follow the same strategy for lazy-freed PMD-sized folio?