From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F514E7717F for ; Thu, 12 Dec 2024 10:30:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 972066B0092; Thu, 12 Dec 2024 05:30:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 923A36B0093; Thu, 12 Dec 2024 05:30:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C3716B0095; Thu, 12 Dec 2024 05:30:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5DC146B0092 for ; Thu, 12 Dec 2024 05:30:41 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 09BA243835 for ; Thu, 12 Dec 2024 10:30:41 +0000 (UTC) X-FDA: 82885937484.23.C96850E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 1A53B1C0003 for ; Thu, 12 Dec 2024 10:30:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PYRMNLfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/l91I6Tm"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PYRMNLfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/l91I6Tm"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733999422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jmt8yBQ6ShXzUXwOUOUaJoeXsGES/8ZDpWR5ho4hHYo=; b=aQ8L0K11H+i/+PB3i8WYULE9+qBa6iSVYs0Vlzx6KDz6gSv2zlA+OqL3Xb4Fgbrlux7Ih1 3tu76rEXoSztrP+4A9g7+ZoCbAne1hoGkGjELaBD13caIs2lQ93RdRmJ6nvjKVdc0jgQ3X FnC5Yq4+38wOu/jZu1mhZm1kjHXJAKg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733999422; a=rsa-sha256; cv=none; b=CpmwUPXcZaH+3mCI8+MjsSjO6GK6/P0fAFwvDs8o8j6uV5uKTUrP0CablUQSvvX2DVYVdG TLGgHES9qSMi5Ww6BQDj2u3bD/O3qxvwe7u3U4M6uneRfPK7PqIiA90+pk6tTMuv+62gkr piidoM2rXSTtW+NL2rc0fFISSSLOZ1M= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PYRMNLfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/l91I6Tm"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PYRMNLfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/l91I6Tm"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BFEFD1F445; Thu, 12 Dec 2024 10:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733999436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jmt8yBQ6ShXzUXwOUOUaJoeXsGES/8ZDpWR5ho4hHYo=; b=PYRMNLfdKfscC0/bLPF1b8/Ame8L0UPHp8QYarL3jTj17qYgByrJvLZXQkHqtSsqtpa1H1 7hpfD5VNQd9rY7DoSdD+inNJijGHegOZ42rgO6+LLNRmXvDqqOI4tlPVl2hqXg9bvg19OW os8mAYjrm7+wP/y2Fyq9lIxxuWE0aWU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733999436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jmt8yBQ6ShXzUXwOUOUaJoeXsGES/8ZDpWR5ho4hHYo=; b=/l91I6TmfNc31FgmeVw/t2AcMmx8UBSqNkoYgmOUz400VQ06vYQaZzy8CHzhWuFnNeIAID uKz/F/UZOA7JeiBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733999436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jmt8yBQ6ShXzUXwOUOUaJoeXsGES/8ZDpWR5ho4hHYo=; b=PYRMNLfdKfscC0/bLPF1b8/Ame8L0UPHp8QYarL3jTj17qYgByrJvLZXQkHqtSsqtpa1H1 7hpfD5VNQd9rY7DoSdD+inNJijGHegOZ42rgO6+LLNRmXvDqqOI4tlPVl2hqXg9bvg19OW os8mAYjrm7+wP/y2Fyq9lIxxuWE0aWU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733999436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jmt8yBQ6ShXzUXwOUOUaJoeXsGES/8ZDpWR5ho4hHYo=; b=/l91I6TmfNc31FgmeVw/t2AcMmx8UBSqNkoYgmOUz400VQ06vYQaZzy8CHzhWuFnNeIAID uKz/F/UZOA7JeiBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEB4D13939; Thu, 12 Dec 2024 10:30:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rPW2KUy7WmdUIwAAD6G6ig (envelope-from ); Thu, 12 Dec 2024 10:30:36 +0000 Message-ID: Date: Thu, 12 Dec 2024 11:30:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v1 0/5] Move kvfree_rcu() into SLAB Content-Language: en-US To: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton Cc: RCU , LKML , Oleksiy Avramchenko References: <20241210164035.3391747-1-urezki@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241210164035.3391747-1-urezki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1A53B1C0003 X-Stat-Signature: ftzudatxgckqp7tt4o4z7b1d3hxsjqju X-Rspam-User: X-HE-Tag: 1733999412-483805 X-HE-Meta: U2FsdGVkX1+3A8rM79XA3YAUMqdWtfjzVTGqlIjtN3EsVR6+cYBk1wImj2zab5kXMTDclGnbfLHr+BmxJz6S0cY6KZ0ZvYCpCuNRYgnQmU8S9HSRBYfT4PxE3tLLCqx9FwOIWyclfnqkRTQji2J04d0z+tjFRXu2pq60q6pvQJfWzYxYGihummO5H9ZU2gU1vv/ziqF8lxXfrS3sJ1NWyuXgqHzuvrqtSfXjJYU+Va2kmwQdnKpvH4qix9m0mNndbOVlzSAyDpSlHDMZiqS7NWOFLj87+62te1iSNwfDbi3gR++KIFHWnuihwZPAAdSQHDjReDo0N4FeuT+MZ1MVMHLcEGXHUU0w6YurFmBqg3rqQCAYWIpK17PcCQPk3evEwvHq9ttwfUryE8k2VTT8YyojdlO59UX3ohVWAIgLIdSCtMX2DgJshZKY0z7Li7B/v1j2sO/Jbfj2/TGILZRHLkT1eXreBwc42MnoJ8v4pqy4W4ll58mnzv1ZOQ5tmTqdToApT72fU4w4oGIneR5pd1AgD0/U5LhcRI5/tO50r9FmPPl4nb3P16egX93B49GSHpEpZuN0XoEr4MYDG/oqsl9hlfV2N8K261nkHUD19FLxCsv5X8qKVVErTI19G0Lx9NT9mOfYpl7N5vFjSR5Huj9miC3QMipUcZvS0NPzrBR01qbP7eW+dQ1YkXCDWoFKHPQGArjb3mPpnyGlTSLSqBqbuKse36OUauGUpEqNlwQg0i2QKF+HJS3dQ0quPWSUWQi8Zw5Bb6PmjPlJew+LRtf5iZzPiTHdEirBXu+ZsoCLzHDjE2FxRNP8lUxHEVwQnf61WRbaoi5OsbFZSP+01RFbOq5T7AEF19wAND10iusb+fnhRqNyaqBuYa5PTLfixU3KSeH27ouN39hZhNDuV4Lfkx2uMgcuDdwkt2V1H62QwsWjGdJYv7lp+GwBaUCBVd5HD/LDnL5ZCl9LKws FYuFCoVT k/RTfbv9r3Dmeo/Qs5GYt1NDQrEy5D22cCfe4tsr7PssCouGjkbm934rlleit826I/oqkaKN6eehWbveoZLXNCTSNxHmCiHGR1kb729kX/ERjqbP7tnQJaEyWpUSANhO/vWzZkCl3MxTMg769bVXxtCy+MjdLRVOvanyQA+dGnTo6lUa+2myegf5Y1Z8DIBSBZE8wU3L+IalBW357OwZf1rDQ4LyZvFcTxYx+JIyM9Q0Q7wQEnD+m6OS/gY3sEsfdc7TzdhcteardnfOraVW1YbLR0qxa0SS1Jmy0pb5A1Kju4jIo63/x2bBT1gFE3KF265pFrxlDRvxoKmU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/10/24 17:40, Uladzislau Rezki (Sony) wrote: > Hello! Hi and thanks! > This series is based on v6.12 kernel. Could it be rebased to v6.13-rc1, which is a basis for most -next branches? Right now patch 5 doesn't apply on v6.13-rc1. Please also Cc all slab maintainers/reviewers. > It is an attempt to move the kvfree_rcu() > into MM from the kernel/rcu/ place. I split the series into a few patches so it > is easier to follow a migration process. I think this is not the best approach. The individual diffs are not easy to follow because they copy code or delete code separately, and not move it in a single commit. I get a much better overview when I diff the whole series against baseline, then git highlights pure moves and local changes nicely. Having moves recorded properly would also make it possible for "git blame -C" to show changes that were made in the old file before the move, but with copy and deletion in separate commits it doesn't work. (but note it seems it doesn't work so great even if I squash everything to one patch - were the functions reodered?) And with this approach you also need the temporary changes. What I think could work better is to do: - preparatory changes in the existing location - splitting out kvfree_rcu_init() and calling separately in start_kernel() - renaming shrinkers - adjusting the names passed to trace_rcu_...() - maybe even adding the CONFIG_TINY_RCU guards even if redundant - one big move of code between files, hopefully needing no or minimal adjustments after the preparatory steps Makes sense? Thanks, Vlastimil > As a result of this series, the main functionality is located under MM. > > Uladzislau Rezki (Sony) (5): > rcu/kvfree: Temporary reclaim over call_rcu() > mm/slab: Copy main data structures of kvfree_rcu() > mm/slab: Copy internal functions of kvfree_rcu() > mm/slab: Copy a function of kvfree_rcu() initialization > mm/slab: Move kvfree_rcu() into SLAB > > include/linux/slab.h | 1 + > init/main.c | 1 + > kernel/rcu/tree.c | 866 ------------------------------------------ > mm/slab_common.c | 875 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 877 insertions(+), 866 deletions(-) >