From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AF8C5475B for ; Fri, 1 Mar 2024 11:27:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FFE56B0089; Fri, 1 Mar 2024 06:27:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 488C06B008A; Fri, 1 Mar 2024 06:27:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC526B008C; Fri, 1 Mar 2024 06:27:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13E8E6B0089 for ; Fri, 1 Mar 2024 06:27:17 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF6AA8045B for ; Fri, 1 Mar 2024 11:27:16 +0000 (UTC) X-FDA: 81848244072.11.E605B65 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id B827280009 for ; Fri, 1 Mar 2024 11:27:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g2UIFaVj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709292434; a=rsa-sha256; cv=none; b=TbeSXX3PglXJem6O95xlaKnogDWO5rjqr7o/CD3ZzlfHb/PX+j+hAXE3Xk1OgusBHsPpra lCTb1f66mktK97hifaVEPZXm0wuGcK0xof66TX8skgcnGCWhKU3hsQv47vFBybEkreYxMD qoZRrAvnJ/CiBzKFBegGAZrkXlCRVhQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g2UIFaVj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709292434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6/FSzqHbBXtSxh8LYUqk8mf1nWsK20Y9+rd0Y1afs4k=; b=BE3+u+LhB7rJAGixuQOH3EIGwhuNcdY3QpiCW7x4qhzaR+DUyz7luO8sxfQLjSNAO8jMeX K/FdGA0TTCqJwJxSw014EIldU07iafgYFwkbY8xVX/VQpoxuYQNSDOthHbHGUC4IFIYhc6 8if4yEqGj4hoLuhxe+ZH38Ne77LHMgw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709292434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6/FSzqHbBXtSxh8LYUqk8mf1nWsK20Y9+rd0Y1afs4k=; b=g2UIFaVjvluVKTLU7nyevdEswYFWmEin9kTCXfMFbctd+tiuAeyV0ElJgE3qiA0BjsbJqY 5Nv2ahODfDSrPgvx0hVCBW3x3Zx9+POrm0eebHWOkdEJp6dmsm5oYZX3xlyNvw2RcJ5MEf vOFSe+hkFhWXFyxwcH1Aeo1bYqThr1A= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-9F2hc77CMk2IDzsNBsDA8g-1; Fri, 01 Mar 2024 06:27:12 -0500 X-MC-Unique: 9F2hc77CMk2IDzsNBsDA8g-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33deb1f7afdso931739f8f.2 for ; Fri, 01 Mar 2024 03:27:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709292431; x=1709897231; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6/FSzqHbBXtSxh8LYUqk8mf1nWsK20Y9+rd0Y1afs4k=; b=Ra3HTqATDVq+MYGD4U9S6aig2SyVVzwyuWI7HrnVOtZatAX3HPTvHDFNV3VZju9Nip mi9U8vgwz2Bcwo9jSDDlVdp9vpcmANBppySptVrD3i3aCqQCvz3k0il+qwXRuepe7W5c toua4/sIz/y/Fw2cNDRZ/CdImBIJ2dMi91Nye8fu3ahi0TYizrjvcF+j1Gzqd1pFkQxW wFUZ3WKAqduYPanDxnokksBX+lX4r2jlpWs/Iv/IhOmEvZ20vK/j2aptNK/t2/LR2znC cs55sENCrdEvUJRdkHFLPSX+Bb4/RDZILhEvvr7n677gnIDBB5IqF9rhVVslWeZaVnRp 58bQ== X-Gm-Message-State: AOJu0YzIKJtRa2BpyO8oT/h6/RNnol2zkcvFf8spo/QNd888LdOEGVjj t2VLmoQoEs86QYMRIgr8YhQui840M1OVPV52oeTL86jaTahtW8Uk5f3h3bJ7d/Gl309+3yCW0ku A+BplHxXwFYvrwSSeTZbUAHmk+pcvuQ+VYORu7GdjESYcE9+kRQOofO4G X-Received: by 2002:a5d:6da9:0:b0:33d:755c:30db with SMTP id u9-20020a5d6da9000000b0033d755c30dbmr1537434wrs.36.1709292431429; Fri, 01 Mar 2024 03:27:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtDLm0VqvQ7/QajNzABdHIgTgfQob/pCikFSlxLWUgLsRgmxrQB1kSI78IJS2UP4HQVBzHgQ== X-Received: by 2002:a5d:6da9:0:b0:33d:755c:30db with SMTP id u9-20020a5d6da9000000b0033d755c30dbmr1537415wrs.36.1709292431001; Fri, 01 Mar 2024 03:27:11 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3200:77d:8652:169f:b5f7? (p200300cbc7133200077d8652169fb5f7.dip0.t-ipconnect.de. [2003:cb:c713:3200:77d:8652:169f:b5f7]) by smtp.gmail.com with ESMTPSA id bx5-20020a5d5b05000000b0033e103eaf5bsm4120422wrb.115.2024.03.01.03.27.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 03:27:10 -0800 (PST) Message-ID: Date: Fri, 1 Mar 2024 12:27:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/8] mm: Remove cast from page_to_nid() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240227192337.757313-1-willy@infradead.org> <20240227192337.757313-9-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240227192337.757313-9-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B827280009 X-Stat-Signature: tn517eysd6dqkix1wzingq5okob1g1g6 X-HE-Tag: 1709292434-468050 X-HE-Meta: U2FsdGVkX1/ycpdlsXkQtBoNDBnM3rQBiiWiwznfp3cdH3BVBq3f6SbaOVfo1CWzz0zhPfEPOmDBa47+famjdg2iIsWFOdL67ED/Mn50iiHsnpqbboxWsmWva2mmBg2qNGz+acNplaKmYp33xRck81+zIOWsu3hOxeRAd4TzMQz6bzHji8ukDccCa7/zAqJsWOGIyLUUvsB21Rd7dWyRnqUFqnsbEDiVJz/e04hzL+/6LMrlQqtmQmbB89rcg5i492WzZH+++/afUpeBA9XsOvRCkhsI3QPi13uNvZ9YGagMMpAhUhP0azDxImGu2WbPpN/pt2j1sA3eoPprNyEnZeMYtft5C0i3G5N+jIgYnXsUKpV+TyB3C8aT8rcnYJ4YWyGoX5lbKrFj6JlAPgPFWIWkX1bhMt6KobcidMiWqOqIV0AP1c/ykaAyGSBNYHK+/wE8dlag0CTVKiEbv/TaJvhO+rA+sFWiCeoUsdz8rk5Ih1+af7SIWKGaZrVkSjbNgtUMyt6asYtr0c/Xgja5Un5603GOYXSG17IcSTDu5dBpKax0Hqt0WCHunWi59lPaq7xmOKZbjk8qEmqeL/xSDhDaFNxPXWuRO6bOs5u7Wtzt0qDeGw5/89CpJHZDDsNVKiuATgRwTZCcCfOjo8CAZFheUj62iuCi19I/ZW85jHrd3YkX6rK+0QrP9S9cQFUfJl0YBYXMqGymrTPMsUB08bJ57HfDSnDuUZQM1eBX3EEoLqnW1giuknDT4ACWRaXAm1gsXAppHSH+PpsGPh1kTBIi9wgBtA4qL3wR1YH3ar1bXSRv81AwPzhJgQi+9RpUIZaqjgf4a30xwA6Luhn831GieuVikzSll0dtkZKXVk+9as/wfpkBiOTRN4PJQpBfsKts/5eesECrcEH1k8UuyN5ESzf8vEsRKPwWcgJP1WyVTSFz+XrX7CUiUXkUNIr+6PuP8dSKnrTDasyPkar 2a6BG3Lg WmpxJ3fPlWJCRjBG1ZuU35dfMvq3LVV+a0xWs8S81/IdKHwFQEoqsu6oLHBFTI4Lr3ntmYjZXr2n2cuoA/CT17PBX0lXWah0QBv0qpOtGH6CRzKO1YuFvo5UBd0MGFPztNUBxcATVQ+YeW3C/Ot7hf//m4gYj9KVWWAe5LEFixdE7JNasO/nOVuzWNX0ZTGST3fbrf86tq1l2VpITaBZyGDaiJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote: > Now that PF_POISONED_CHECK() can take a const argument, we can drop > the cast. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c4a76520c967..21a8cfbe75aa 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1662,13 +1662,11 @@ static inline int page_zone_id(struct page *page) > } > > #ifdef NODE_NOT_IN_PAGE_FLAGS > -extern int page_to_nid(const struct page *page); > +int page_to_nid(const struct page *page); > #else > static inline int page_to_nid(const struct page *page) > { > - struct page *p = (struct page *)page; > - > - return (PF_POISONED_CHECK(p)->flags >> NODES_PGSHIFT) & NODES_MASK; > + return (PF_POISONED_CHECK(page)->flags >> NODES_PGSHIFT) & NODES_MASK; > } > #endif > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb