Re: [PATCH 8/8] mm: Remove cast from page_to_nid()

[David Hildenbrand <david@redhat.com>]

On 27.02.24 20:23, Matthew Wilcox (Oracle) wrote:
> Now that PF_POISONED_CHECK() can take a const argument, we can drop
> the cast.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   include/linux/mm.h | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index c4a76520c967..21a8cfbe75aa 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1662,13 +1662,11 @@ static inline int page_zone_id(struct page *page)
>   }
>   
>   #ifdef NODE_NOT_IN_PAGE_FLAGS
> -extern int page_to_nid(const struct page *page);
> +int page_to_nid(const struct page *page);
>   #else
>   static inline int page_to_nid(const struct page *page)
>   {
> -	struct page *p = (struct page *)page;
> -
> -	return (PF_POISONED_CHECK(p)->flags >> NODES_PGSHIFT) & NODES_MASK;
> +	return (PF_POISONED_CHECK(page)->flags >> NODES_PGSHIFT) & NODES_MASK;
>   }
>   #endif
>   

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb