From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E513DC352A1 for ; Tue, 6 Dec 2022 09:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C4378E0003; Tue, 6 Dec 2022 04:40:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 774858E0001; Tue, 6 Dec 2022 04:40:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615048E0003; Tue, 6 Dec 2022 04:40:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F81C8E0001 for ; Tue, 6 Dec 2022 04:40:17 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C1F4160D67 for ; Tue, 6 Dec 2022 09:40:17 +0000 (UTC) X-FDA: 80211385674.09.73CFC1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 8BBE2100015 for ; Tue, 6 Dec 2022 09:40:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cGPFr8qD; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670319616; a=rsa-sha256; cv=none; b=EVyUxQ7Lc76uarLyP7qo9XoVNfdjKVAK+7UXmOz3naDyMs4B3DstK7M/mmfSONbZZEYUiE YSnYraKFXAOHjzIabXzPMS2rS2w652MAJsidkHNT5etrEyI9E7PPje7+Lmqh9+r5Iw3f36 UvPD1CdFYHcgmhDxE64wr/+5UqtqHxI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cGPFr8qD; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670319616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TW5dHJarb7+FFAmmzS1Os44E3J0QfUoAGmh4ld8vUpU=; b=FxRLlqSdkuUVxtHLgDT4Y4W/W7q0aTMDzFgJWJNQJ1HTqUAz4Wjip41uB/LQTNKPaaHqQ3 qquQ/SG6BFnkadG9egkza8hYkggrThg78T/t807FUMd35jL/L3K1m8rNBSbmKkn+k+LEzA vGZMp8dPdCGM1Tc/dq0Bfv4SC2ENW1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670319616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TW5dHJarb7+FFAmmzS1Os44E3J0QfUoAGmh4ld8vUpU=; b=cGPFr8qDjY6wb5wa0C6GZbOVl26O+P+vM0gkWoBOldV96yMMZqymY2byLBMBFrq8nQ94KK lAam3Z7a7z68G8J5GsOMwhTAEivzf8hUZEpcGrpSYY8phrIgkTX5zPFLeUrDq7v9FsV+0q pYCEYQCutKA+dUuFM+tK05pb0srLHjQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-464-2neOGDcaP6q0sQTDG6mheA-1; Tue, 06 Dec 2022 04:40:14 -0500 X-MC-Unique: 2neOGDcaP6q0sQTDG6mheA-1 Received: by mail-wr1-f72.google.com with SMTP id i25-20020adfaad9000000b002426945fa63so1192192wrc.6 for ; Tue, 06 Dec 2022 01:40:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TW5dHJarb7+FFAmmzS1Os44E3J0QfUoAGmh4ld8vUpU=; b=CtkJ6IwWj7hAbdRUg07EjJyUQCcxSKsyPlNE3Ko8ykN+cu1GCkGn/4b9JVDGHD2CBr /pMYj20ThVz7nqL+KUzK5Q1sGvRuQQwWWJ7YeEcxibclaQmaGy0mSTe2vxXafGhsCJ0Z MOlrGuOmVuGkCiSqvKCJVNxwBiRjIH0hC6r4xU0Hiy9tPZLyeCvSGJ3+4ll8O4JHuVUk H8ddZczSZteuKRTy9H8iWeHq3gq683VC+YBUplslDAAbUzMqD6KR3iHF/lvyTSHf/jxz 6WKEbGJumDAG0pLHz8jzQfMarCl86QSkzr5qJDCrMHSBLPl4k1oIJI61Jr5gNER0bM0s H7ew== X-Gm-Message-State: ANoB5pmyF95HAQanOfa66qv2k/SMYSwpxsI0OKhJy+281xiSvASt81Tx hbMkl1jLsEQ1sIqFZx3nhtcVJszeH1qktiLPGTu82JbBJbWT1wpSbu+XbcCdISKaI4tsu7voogm VusOM2eXvhSI= X-Received: by 2002:a05:600c:3d98:b0:3cf:e9a4:325f with SMTP id bi24-20020a05600c3d9800b003cfe9a4325fmr61640500wmb.98.1670319613324; Tue, 06 Dec 2022 01:40:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf7MtVVtl9RFgBHMNRf56gOZudqLVuxoYvL6ZChVKkkD30HPJrmCQbk5WjN+rcIYKSw8XOV2sA== X-Received: by 2002:a05:600c:3d98:b0:3cf:e9a4:325f with SMTP id bi24-20020a05600c3d9800b003cfe9a4325fmr61640458wmb.98.1670319612945; Tue, 06 Dec 2022 01:40:12 -0800 (PST) Received: from ?IPV6:2003:cb:c705:4f00:41f1:185d:4f9f:d1c2? (p200300cbc7054f0041f1185d4f9fd1c2.dip0.t-ipconnect.de. [2003:cb:c705:4f00:41f1:185d:4f9f:d1c2]) by smtp.gmail.com with ESMTPSA id z8-20020adfdf88000000b002258235bda3sm16231837wrl.61.2022.12.06.01.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 01:40:12 -0800 (PST) Message-ID: Date: Tue, 6 Dec 2022 10:40:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 12/17] mm: remember exclusively mapped anonymous pages with PG_anon_exclusive To: Miaohe Lin , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , linux-mm@kvack.org References: <20220428083441.37290-1-david@redhat.com> <20220428083441.37290-13-david@redhat.com> <90dd6a93-4500-e0de-2bf0-bf522c311b0c@huawei.com> <3c7fd5da-b3f8-5562-45a9-f83d7dbcdd7d@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Spamd-Result: default: False [-0.14 / 9.00]; BAYES_HAM(-5.74)[99.44%]; SORBS_IRL_BL(3.00)[209.85.221.72:received]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[30]; DMARC_POLICY_ALLOW(0.00)[redhat.com,none]; DKIM_TRACE(0.00)[redhat.com:+]; R_DKIM_ALLOW(0.00)[redhat.com:s=mimecast20190719]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:170.10.133.0/24]; TO_MATCH_ENVRCPT_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; TAGGED_RCPT(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 8BBE2100015 X-Rspamd-Server: rspam01 X-Stat-Signature: 8p7tyn67cx8cqqxxsz99k6mdmss5pg8p X-HE-Tag: 1670319616-59987 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.12.22 10:37, Miaohe Lin wrote: > On 2022/12/6 16:43, David Hildenbrand wrote: >>>> >>> >>> Hi David, sorry for the late respond and a possible inconsequential question. :) >> >> Better late than never! Thanks for the review, independently at which time it happens :) >> >>> >>> >>> >>>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>>> index 7a71ed679853..5add8bbd47cd 100644 >>>> --- a/mm/hugetlb.c >>>> +++ b/mm/hugetlb.c >>>> @@ -4772,7 +4772,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, >>>>                       is_hugetlb_entry_hwpoisoned(entry))) { >>>>               swp_entry_t swp_entry = pte_to_swp_entry(entry); >>>>   -            if (is_writable_migration_entry(swp_entry) && cow) { >>>> +            if (!is_readable_migration_entry(swp_entry) && cow) { >>>>                   /* >>>>                    * COW mappings require pages in both >>>>                    * parent and child to be set to read. >>>> @@ -5172,6 +5172,8 @@ static vm_fault_t hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma, >>>>           set_huge_ptep_writable(vma, haddr, ptep); >>>>           return 0; >>>>       } >>>> +    VM_BUG_ON_PAGE(PageAnon(old_page) && PageAnonExclusive(old_page), >>>> +               old_page); >>>>         /* >>>>        * If the process that created a MAP_PRIVATE mapping is about to >>>> @@ -6169,12 +6171,17 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma, >>>>           } >>>>           if (unlikely(is_hugetlb_entry_migration(pte))) { >>>>               swp_entry_t entry = pte_to_swp_entry(pte); >>>> +            struct page *page = pfn_swap_entry_to_page(entry); >>>>   -            if (is_writable_migration_entry(entry)) { >>>> +            if (!is_readable_migration_entry(entry)) { >>> >>> In hugetlb_change_protection(), is_writable_migration_entry() is changed to !is_readable_migration_entry(), >>> but >>> >>>>                   pte_t newpte; >>>>   -                entry = make_readable_migration_entry( >>>> -                            swp_offset(entry)); >>>> +                if (PageAnon(page)) >>>> +                    entry = make_readable_exclusive_migration_entry( >>>> +                                swp_offset(entry)); >>>> +                else >>>> +                    entry = make_readable_migration_entry( >>>> +                                swp_offset(entry)); >>>>                   newpte = swp_entry_to_pte(entry); >>>>                   set_huge_swap_pte_at(mm, address, ptep, >>>>                                newpte, huge_page_size(h)); >>> >>> >>> >>>> diff --git a/mm/mprotect.c b/mm/mprotect.c >>>> index b69ce7a7b2b7..56060acdabd3 100644 >>>> --- a/mm/mprotect.c >>>> +++ b/mm/mprotect.c >>>> @@ -152,6 +152,7 @@ static unsigned long change_pte_range(struct vm_area_struct *vma, pmd_t *pmd, >>>>               pages++; >>>>           } else if (is_swap_pte(oldpte)) { >>>>               swp_entry_t entry = pte_to_swp_entry(oldpte); >>>> +            struct page *page = pfn_swap_entry_to_page(entry); >>>>               pte_t newpte; >>>>                 if (is_writable_migration_entry(entry)) { >>> >>> In change_pte_range(), is_writable_migration_entry() is not changed to !is_readable_migration_entry(). >> >> Yes, and also in change_huge_pmd(), is_writable_migration_entry() stays unchanged. >> >>> Is this done intentionally? Could you tell me why there's such a difference? I'm confused. It's very >>> kind of you if you can answer my puzzle. >> >> For change protection, the only relevant part is to convert writable -> readable or writable -> readable_exclusive. >> >> If an entry is already readable or readable_exclusive, there is nothing to do. The only issues would be when turning a readable one into a readable_exclusive one or a readable_exclusive one into a readable one. >> >> >> In hugetlb_change_protection(), the "!is_readable_migration_entry" could in fact be turned into a "is_writable_migration_entry()". Right now, it would convert writable -> readable or writable -> readable_exclusive AND readable -> readable AND readable_exclusive -> readable_exclusive, which isn't necessary but also shouldn't hurt either. > > Many thanks for your explanation. It's really helpful. :) > >> >> >> So yeah, it's not consistent but shouldn't be problematic. Do you see an issue with that? > > No, I don't see any issue with that. I just wonder whether we can change "!is_readable_migration_entry" to "is_writable_migration_entry()" to make code > more consistent and avoid possible future puzzle. Also we can further remove this harmless unnecessary migration entry conversion. But this should > be a separate cleanup patch anyway. Want to send a patch? :) Thanks! -- Thanks, David / dhildenb