From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8ACC433F5 for ; Tue, 14 Dec 2021 16:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E87016B007E; Tue, 14 Dec 2021 11:39:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E37626B0080; Tue, 14 Dec 2021 11:39:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDA656B0081; Tue, 14 Dec 2021 11:39:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay034.a.hostedemail.com [64.99.140.34]) by kanga.kvack.org (Postfix) with ESMTP id BCCF46B007E for ; Tue, 14 Dec 2021 11:39:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7CEE521B10 for ; Tue, 14 Dec 2021 16:39:35 +0000 (UTC) X-FDA: 78916960710.04.5DD13B6 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf24.hostedemail.com (Postfix) with ESMTP id 3C92C180004 for ; Tue, 14 Dec 2021 16:39:32 +0000 (UTC) Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JD3vw683Zz67N1R; Wed, 15 Dec 2021 00:38:04 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 17:39:31 +0100 Received: from [10.47.83.94] (10.47.83.94) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 16:39:31 +0000 Subject: Re: [PATCH v2 04/11] iommu/iova: Squash entry_dtor abstraction To: Robin Murphy , , CC: , , , , , References: <223ae26f3f40165008509182474483b10d421534.1639157090.git.robin.murphy@arm.com> From: John Garry Message-ID: Date: Tue, 14 Dec 2021 16:39:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <223ae26f3f40165008509182474483b10d421534.1639157090.git.robin.murphy@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.94] X-ClientProxiedBy: lhreml701-chm.china.huawei.com (10.201.108.50) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Queue-Id: 3C92C180004 X-Stat-Signature: kmrje5fdhhx51zunjgtao3dacesgi9tn X-Rspamd-Server: rspam04 X-HE-Tag: 1639499972-791553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 17:54, Robin Murphy wrote: > All flush queues are driven by iommu-dma now, so there is no need to > abstract entry_dtor or its data any more. Squash the now-canonical > implementation directly into the IOVA code to get it out of the way. > > Signed-off-by: Robin Murphy Seems pretty straightforward, so FWIW: Reviewed-by: John Garry