From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC79CC7618D for ; Tue, 21 Mar 2023 07:55:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4901B6B0075; Tue, 21 Mar 2023 03:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 440516B0078; Tue, 21 Mar 2023 03:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 307796B007B; Tue, 21 Mar 2023 03:55:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 21C8B6B0075 for ; Tue, 21 Mar 2023 03:55:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E24EFA1146 for ; Tue, 21 Mar 2023 07:55:44 +0000 (UTC) X-FDA: 80592146208.20.D0D450A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id E227E4000E for ; Tue, 21 Mar 2023 07:55:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=egdeMcqd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wDA9s17O; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679385343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9cGY12kDQSwASIHfhJiV2pRr9ipekQXRkFafDBu1XBk=; b=t06KG7HtrwVzQ2og9C21tBHktXpuf05+Wg401hr9o8DA5RigsKlgshm+vLKbIdp6C1shRK kaJ6T9YdeYc6kgseUIDEFVQvqu+xTzN1i3xF6SAkUjX+XwsdVKU5uBeTxvEZ1pW2RFW/Ik cWSAhcThFk/MCNW6Rw52EHAX8PWxbtk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=egdeMcqd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wDA9s17O; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679385343; a=rsa-sha256; cv=none; b=p6F8TeI5eUf+rEYSaCMJvBzibVTo6tTOFyYeikMkL85obn6qQ53ZY/QA39ysu5zVDWMt// IaEx0Wlf2t8v6eRubSAbepNf/J4B9V8iw0EqaqiZVqZAWChgwBVlkIu1tc3RKItR84Vwzh 90OMdXCZAelU0/8g+JbAzt40gN6H7B4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EED6A21A70; Tue, 21 Mar 2023 07:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679385339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cGY12kDQSwASIHfhJiV2pRr9ipekQXRkFafDBu1XBk=; b=egdeMcqdv25PErCesAzCg289ZaANuPs9QP53OZbgodUWtlljfv5IWJ1hr/r6URWplpp0/j NQ/PGyNDQXvcO+hxCR3tu7qSvhPa+9FpS7uObiD5RQMD24KGMQnbgCRoZlmhZE8Ea1QU01 ND3mqsU4qfp/DPOeFiYkdrtrjuCanyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679385339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cGY12kDQSwASIHfhJiV2pRr9ipekQXRkFafDBu1XBk=; b=wDA9s17OE8q24MWB2jK0ByNbJtNmEbp17cxlen43oljpli0F+NRSPrNQkLSJEfsnfMUVWc PQ8fctZ/cwcFyVAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BFE5C13440; Tue, 21 Mar 2023 07:55:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fOAKLvtiGWR2NwAAMHmgww (envelope-from ); Tue, 21 Mar 2023 07:55:39 +0000 Message-ID: Date: Tue, 21 Mar 2023 08:55:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 04/10] drm/i915: Fix MAX_ORDER usage in i915_gem_object_get_pages_internal() Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-5-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230315113133.11326-5-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: swakqajuiwt4tr4ejfmi3kidr7eb8ghr X-Rspam-User: X-Rspamd-Queue-Id: E227E4000E X-Rspamd-Server: rspam06 X-HE-Tag: 1679385342-512956 X-HE-Meta: U2FsdGVkX1/cOrR2tux3ICszWz2871EPRZkW3Eh2l+HjjQCVMdiBixlyW7DsYtyFex7Zm8cZqBnf9hSP9nr6XMYQ5V3h1xjNf9oy92v6iKkP85hkDNrgxFp0JkLSob4RI20FY2x7nejHLAoXHRK3/AGv8TjtNuAdpQkE22rZvOaqcEQa2WAWRYKqplMH7SqgEd58Xu8k56Svc0NmaJlMPv17EcTHym4nwvA59aXADBDnkpEqg6IP38+S4pQN+IfY36TIBeq7/gLHmlxDkNHXDpdThcZ+OKUYxjskBn+q3KnyXX85Re7gmr3x4EFfz0ExuJ78D0bR8tY4+w2YZkXbn5i6KBCQblAOBkwXL1NNpbFeOHWpA5n4xQ11HbxV+qEzGjmFL8Ppc93CcG6oIS3Ta4cdV+Vije9WHctqHncJqZPK01jbpcRUY/USttsGdyOb3fUGWr8a8ZevKIKtKRbZLHHAzqARtpAJbTMjYmL6c/x/6IFnQW0RlXONSms+JgoXec5KzUwoF1fKlSa8wUMLeE8PZ0YuRDvm/BwO1SCxjk0gppuLAObhAuu5lqyEBuJ84kzDzQs5wK5SvxohDIuXZmeuO4c4UKdRULXpU3QuZ42fn68WU72T/Z2vCXNQX5miIrY4rqfOGxKoFrPEeGbK5mB8Z1KllqOHFFqclhHefVVNosfmPqZfvwDNFJo3ux1pKcyL68SBBO3qWLc+uh6c8Z89AfsnbG90i66FGqBU3PwQhtHkpYXp2XFNCIrk3bzwBZKBexScKjaecFijvKY2f+L1Y8peXlpN0hNkFo5xy+PT6+H3Dkjr9eehepCYsbhw+gLcUyPWoVmzexxQnGmVOzJgwWSR4TnQTc8E4kGQN6lKOskAY9Dvx4sUj4ZEVkeKUqVUEA9FcATSiljrhXcJGNQygfSA+9YE23X35x5V8YoyncNjKromfx74lT7dX1RcWkZeRGva7fUzmJPHf5k MWT8tCEx dSOCRDgFqV2OrYCH/Rx0Ri9O98FYzV5L42roqPXaZxE8iHYs+v1aIsOhdZa0bh3kAG1XJuMhyYe6c6oEqCWfx8JqFa1IU14p6njxwyzJuri0Men/YNHqr88p65qRV258Ek3GmSm1x7QLHZ7w+mToYvJ6/LgFWcaiLeVHybDjNXHcSSK3DND5NkqwZIpR7U01PP3FTnKhcS2ZfpJ1noUfeZg8bm+3ejK2wOGDthY0pACliwVjABLluZqxo3uKK6ZKThMY6NefT7GyK1elZWdAoo4KqCoPxw3PnQZRILO5Cj6/hlg461o6NKi79rxv2l6e9Q6gd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in i915_gem_object_get_pages_internal(). > > Signed-off-by: Kirill A. Shutemov Acked-by: Vlastimil Babka > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/i915_gem_internal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_internal.c b/drivers/gpu/drm/i915/gem/i915_gem_internal.c > index 6bc26b4b06b8..eae9e9f6d3bf 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_internal.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_internal.c > @@ -36,7 +36,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj) > struct sg_table *st; > struct scatterlist *sg; > unsigned int npages; /* restricted by sg_alloc_table */ > - int max_order = MAX_ORDER; > + int max_order = MAX_ORDER - 1; > unsigned int max_segment; > gfp_t gfp; >