From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A0DCC27C6E for ; Fri, 14 Jun 2024 12:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 763646B0099; Fri, 14 Jun 2024 08:42:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2057A6B012E; Fri, 14 Jun 2024 08:42:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F44B6B00D3; Fri, 14 Jun 2024 08:42:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DD13C6B012E for ; Fri, 14 Jun 2024 08:41:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F3CB160629 for ; Fri, 14 Jun 2024 12:41:56 +0000 (UTC) X-FDA: 82229456232.24.FDBFF57 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 41F854001A for ; Fri, 14 Jun 2024 12:41:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CCkG1sXw; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718368912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVCa7RwQroi261t1F6XjVS7+W2uN0kc4IDTx0N1MMdo=; b=4j5tX+QXMHoSFkWtxsUhLo5ctQ5p+YOwNA6yNg/+QUHLsJ8G95dOXX5QQKneXDeIht/2OT 10tz1OUCbfAGK6Z1TJZn0IHo3DmF64zLkmx0BmJbZ7kah4qjf1CIoAIkmDxHpdUbUaa+tS 1eWcCd+BTzfKebpCfWrwHYsO3MjR9pA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718368912; a=rsa-sha256; cv=none; b=XX/ULFmvUfVeqQvMzdoBaIXd4dPXxd6e2oBQx2BmUCXtYZ03Fcrpu5YhluMUmVhh5KVHAu hkhIZ0T6eAGDnJHsi5d2lsoAw3SFNKDvKRUsv8hSNE6yvqd0NIhWNn+/Z2d4bfa/GssKv8 /hdoUZwIbLAq25uCaKrD2qxrzQ72YKk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CCkG1sXw; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718368913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qVCa7RwQroi261t1F6XjVS7+W2uN0kc4IDTx0N1MMdo=; b=CCkG1sXwwaJA7Oq5UJ4hQVlpQ6ZLP2WvcEkSvr0fD7ktgqT5/eWt/F3w/oKYQpFN2foLlT hVC45mNHijuiiz63WEL4qBPzyPC+00E/qHkV2OYwlUTHWOaM4JDW7NPgFpnCFjS0LoPMEF LwaqtE6otIOhNddLFsRNPEXBk6tZvxE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-kW80RvhVMo-Z0WRo-WjJTg-1; Fri, 14 Jun 2024 08:41:52 -0400 X-MC-Unique: kW80RvhVMo-Z0WRo-WjJTg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-35f10585251so1259142f8f.1 for ; Fri, 14 Jun 2024 05:41:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718368911; x=1718973711; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qVCa7RwQroi261t1F6XjVS7+W2uN0kc4IDTx0N1MMdo=; b=S82RBUE6gqD5102lu8GV/gImWrfiy4Mq16H5QAijEBMvggvw7dfg9eviYWxnXWX60H e6wt3+FEBq6nBMjxl+82ViK9063pIqoT1mI1H4o06bgI+o8DBnwPrpnOMkwU3AxqnBhn pwtMdNY69C/4++RJTRQWglrg66WxcHPVC6jiXz5jMjpJMSBcF/lSiOc5IXC5s6DgsAJQ iBKLlUS9zx8ylSaNsnst6eWkeoASh0yJzU37zW9TwnvDtcCHB6R/ThQtEmanlYxbJEVY PQaG0Bs5PVBwKJae9znPmUCn+JcCtp/ZkVAoG7r78eOxdfARm+tNtFYllxmqluKkg7hy j8AA== X-Forwarded-Encrypted: i=1; AJvYcCXK0HwKjEhNod+0zGDPNH1fLa06g3OtEbHT6vMxE3Sf6jwh588wovDBCHByAGr0lIKzZFQB5fb3hlLb3bCkBn0wPeA= X-Gm-Message-State: AOJu0Yzzl7wbUxTWIWfWvJIXIoseEmGiiRj/68sTj6UajKU0Xhutl6uD Ro4462MdY0RNO99LaT9LL1EWrLKlugYYba7EX5sL4sejwBVt5mqmsMBF1WGfOKAD8cYe3joQ5UW at+9mMuGcN5v3+WKfhJ1z/rbn3wEFXDcT3YR/FhDNPxZnSWvX X-Received: by 2002:a5d:5283:0:b0:35d:bd46:960a with SMTP id ffacd0b85a97d-3607a764bf2mr1704154f8f.23.1718368911072; Fri, 14 Jun 2024 05:41:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDCXn202g0cRFTygkw8Oi1Eh/fwqFY0cLSIqyqzWBUKuRCdAAvjwjeStFj7/sd3j8BQHttjw== X-Received: by 2002:a5d:5283:0:b0:35d:bd46:960a with SMTP id ffacd0b85a97d-3607a764bf2mr1704134f8f.23.1718368910688; Fri, 14 Jun 2024 05:41:50 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4f:2b00:69b5:3684:56c:6dd5? (p200300d82f4f2b0069b53684056c6dd5.dip0.t-ipconnect.de. [2003:d8:2f4f:2b00:69b5:3684:56c:6dd5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075104a0fsm4327929f8f.96.2024.06.14.05.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 05:41:49 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 14:41:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal From: David Hildenbrand To: John Hubbard , Andrew Morton , Jeff Xu , Shuah Khan Cc: Andrei Vagin , Axel Rasmussen , Christian Brauner , Kees Cook , Kent Overstreet , "Liam R . Howlett" , Muhammad Usama Anjum , Peter Xu , Rich Felker , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML References: <20240614023009.221547-1-jhubbard@nvidia.com> <20240614023009.221547-2-jhubbard@nvidia.com> <1ea35568-bfe5-430e-9f4b-edef17f0b22b@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1ea35568-bfe5-430e-9f4b-edef17f0b22b@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 41F854001A X-Stat-Signature: g65t6up7punqs47u1sx8a8m6jober19d X-HE-Tag: 1718368914-75203 X-HE-Meta: U2FsdGVkX18rxQssdwhrgi4Zcj6IBteTsmQZs/+Q9UTXh0zyd6MX06IoRxY0y/Z8V+rrl1h0CGXiSeiRCNd0016oDwVN7MWtRXDD+DsxitRDLV62ENBNhU2aI1iT7+IvPRFgH0gMU4izx7TkszcnXQZJ5TDykcnUUTLfIJ9ughfFv2nE9q6uaMCoiZ/LYWb8O4dNwVFeegUCucnPNV+TqWwBKwMU5L8aOwDT5X7DMjPe6bjvIhFMEsvg3JLmeQSZzI1R1JUw7rSygMw66HBKtHliw9UTtRUIHF/UamPs2dSgXjkvrJ8/j4Di+OrY1UT+mq9UZKH9Wl7vhYlhekmxRarvGzi9Sqrz8YCbRjpcBDjUi5Vjc7aLUzi/07hQ7CzHyzF2sEb/mW/8HUFZql9r2/3G0d2hwKKJumMLpmKucMjRY/fw162In9NozHJUpYIqOd4dvUfqi5npc8elSBssOE3mJ7FH3K1zNc175TIeg1WUyTMPwAPjFcjY67GxZ+swrfD+T/6xgvyAF2d54C6nUQSuQnIICoE+jo7DH/LLZgeZPdm8pW0W+TFpDx26cZ5DJVRkvwP0jekmqlIAvD4zUzWP/2LhXG6/Vxt2DpfTgaqPsXm6d1USE723XLXefevP7V6JObxcL6lNFTXtAZVGHilGdUq6KUWRnmCZCXTf8pjNoL0kjAmBC6cHmo8AU1e1OMlKmX0ov6wCR6ybPFftYLGGHIT6I/NlETSa4/YKqr+a+29rKY7k279ot0jyMjvItQ8zt/MeGqFKmRCF13gB93pz6i8p79gpFl07+BoMjLg6ZvuFc9jNF2LTNy6Jer6fQhH0s+kaR12vbWy3MtyDYWe3UnVOR8Jh99k+XOzBP0+H26NzDMP1pBxbtWcnGpo149ltg+yvCpERf0ho6phSUWEnT2WtPKmKhqaORwFVqFEGOYWXwedSNbia5mVInb7yoUANJDsV0GhxDOPD5pD RR9MlyJI 81TCnw5bfpVMIomY/M1xE+2UM2wWGFqqicdgHvhoq+xuTjao6YfiNuFAYvEPKyfbSWpfq/GNT7YCo6KfIuKr3qvwo9mLYZ0c1QtCLhi1H/CeRVUx5rcTImt8//3oNQRImkcOcAKm7zG1Kg7j1yROj4ZTxuxK5Qw1NEoSaN0X9KlykmqCH90nuHh+3wxqfj1Yqg/keyMY5X8Gv73qbkimuT8ctgKgo07tdnYto6vI3lFcpZm+TWsx0/gS+MW99JkiDejhmSLCOBSuY1RsmpKUQMKAMHro5NuxUAPqRTNxIj/Zk5xawIl5tnEEDJPeVf9Bz8yOGUtvGm/WNhj5n07Zx6KMSD6S0iduWD5612Dhdq/xWSkleB6Vrk8WPnmEOrwnqt7yU5QLXTPi/iHx6m6q4Pl0CQx98POKqi7VtU+gYE8EYgn5D12kNYZAmx5S3Qo59lVwQK4BIZ0wyS5/kppSdQi7YKm+Iy1Eg/LWm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.06.24 14:28, David Hildenbrand wrote: > On 14.06.24 04:30, John Hubbard wrote: >> The selftests/mm build isn't exactly "broken", according to the current >> documentation, which still claims that one must run "make headers", >> before building the kselftests. However, according to the new plan to >> get rid of that requirement [1], they are future-broken: attempting to >> build selftests/mm *without* first running "make headers" will fail due >> to not finding __NR_mseal. >> >> Therefore, add ./usr/include/asm/unistd_[32|x32|64].h (created via >> "make headers") to tools/uapi/, and change the selftests/mm files that >> require __NR_mseal to include from the correct location. The way to do >> so is to include instead of just . >> >> [1] commit e076eaca5906 ("selftests: break the dependency upon local >> header files") >> >> Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing") >> Cc: Jeff Xu >> Cc: David Hildenbrand >> Signed-off-by: John Hubbard >> --- > > If it works, great ... thinking again, are some of these headers arch-specific (IOW, generating them per-arch would result in something slightly different)? In tools/include/uapi/asm-generic/unistd.h, we already do have __NR_mseal ... -- Cheers, David / dhildenb