From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57D7C35FE7 for ; Sun, 15 Sep 2024 13:14:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92A0E6B007B; Sun, 15 Sep 2024 09:14:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CCFC6B0089; Sun, 15 Sep 2024 09:14:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 694516B007B; Sun, 15 Sep 2024 09:14:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 46B0A6B0083 for ; Sun, 15 Sep 2024 09:14:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA0F0C2403 for ; Sun, 15 Sep 2024 13:14:29 +0000 (UTC) X-FDA: 82567016658.05.EAAD26D Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf06.hostedemail.com (Postfix) with ESMTP id B5F0E18000C for ; Sun, 15 Sep 2024 13:14:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kQXCIx3a; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726405959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EKD0tpWk/TDA0am1PYoTZE4iDckLnw1hxZdm5GR5XZM=; b=0U27w5jYkJ7UR3bChBKeht09TXaMxLulW+JMv648oYnuotOVclwjsQmIcK6udssLwZLxIw W/B+ZWgPqtrDCfRiE+dX8e0BeUZCzWEftSPBXK4wPhcgU80qTzTfrqO0STgndMsj3DJ9PN ClC4uNEMVjmwM2Wo35fgZ5u26aQwDQA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726405959; a=rsa-sha256; cv=none; b=wzswfYkjtO22T3vmXeOfEUwpRqtTJrsJNRdkgjQKF7G7AMcT+XiKhkKT5IpxVROSioZK2C As+scEwRBWgJ3onPyJEZQez8MjwucLFQAnSInd+jcdnkNvayrpoBthuMyom8l38pMC7If8 kiOc9WrAOyXMeS0rU1NqJrjnCS1b2EI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kQXCIx3a; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.48 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-374c180d123so1341934f8f.3 for ; Sun, 15 Sep 2024 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726406066; x=1727010866; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EKD0tpWk/TDA0am1PYoTZE4iDckLnw1hxZdm5GR5XZM=; b=kQXCIx3amXoKWPVNenyKLy/pCHNmrLT2ZW/LisX3wq/CAdeX77zrYYvqXggwxV/AEx mRsw4851igwYkBmyPIJiExL7p3Ef0041W1WJKo1gYzu5x8ylRH0OVEHEduNI/6ChmuT6 Ue+X8/3ipIrNjauW7fKkbV0osqoqRgBFPcHLW8+/QGQ6vhy12HKLOcpeDZI8MQtZQ6yp AAx1Wabx8qZDagrPld5RF3SMP5Gopmx/JvImWfe3ME3TE1P0QcbaZ2/awjEFkcFTZf9x 4FQqpUeCsxMZT8LdtyLDk/Tq8fAl5FghReKSXN47A45H02bJYJxrtHqu5bqlE6o00Xsm kO+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726406066; x=1727010866; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EKD0tpWk/TDA0am1PYoTZE4iDckLnw1hxZdm5GR5XZM=; b=Vs1Z5pywgf3zgpQCutAqOuKVPzKjYi0xuCf8qfEG5Hc3/kOuGcD7uGaf2+whG8AzOi SQ6OeXdXVTGAWbDNJjSLeSit2tTsRykx97OwMHcE89qwit8QgRjSfcxOh8tAKmwfVIDD anYpW5AKPE9XvaOvCDInbH4mXZbhTgVMZXQolX3uU+SmYja/UcXyb7now3ubN3gLP7Mg 5G1GSrV5dnPk3Fo8l5IjhGIMAqTDJ1sz855KwAByfWF/TiuZ22opPnc4Roi0j6sxnWH4 02HyjuZ7BCN7r5MTt9mlNmRHa53Bf4T4QCGUp4LL8kssDZGDahW+zuB4uNzZAjki4MAI EdVg== X-Forwarded-Encrypted: i=1; AJvYcCUlunmR0Zor6xo44fZ5xJwmAP9mxANDIEFV/kPlZYkwix+KZJe9r4BHERUcSqYuuY8CSstifo4riA==@kvack.org X-Gm-Message-State: AOJu0YzvhOC02oXz396+vY7ZCIDUQhlyBqPrtMu2JAws6c9ID7CdWdal 4myjwEmvEIGCeJ0T0mvw7NtojrKZ6qvRFijuYWCYaNXSVINsbMDT12eE6ddAQCPYjrHOvbjPd0C v X-Google-Smtp-Source: AGHT+IFtIuzO5eYvGi3Zx+kKoxVxq6/zqJvEOCLFr12A5pI5BsIr6lY6Cy/lE6tjqXv3EVut986fzw== X-Received: by 2002:adf:b219:0:b0:374:ca4f:bd70 with SMTP id ffacd0b85a97d-378d62537c7mr3858969f8f.53.1726406065923; Sun, 15 Sep 2024 06:14:25 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73f9999sm4645289f8f.58.2024.09.15.06.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2024 06:14:25 -0700 (PDT) Date: Sun, 15 Sep 2024 16:14:21 +0300 From: Dan Carpenter To: Lorenzo Stoakes Cc: Linus Torvalds , linux-mm@kvack.org, Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [bug report] mm: avoid leaving partial pfn mappings around in error case Message-ID: References: <8e3ffaf2-358f-479c-8de6-46e1b0bb0c5f@stanley.mountain> <68590155-fd3c-4ce4-9a1f-d314efada198@lucifer.local> <5a2f4219-e863-413a-96b9-ad2002f5b35d@stanley.mountain> <998b7c12-19a5-4213-8df6-154f50cd5dee@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <998b7c12-19a5-4213-8df6-154f50cd5dee@lucifer.local> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B5F0E18000C X-Stat-Signature: xy53gc6cmi1ubd3a6ksoprs6z7r34pjp X-HE-Tag: 1726406067-33783 X-HE-Meta: U2FsdGVkX1+gtTOJSaL6oRB/IMfjyVHGpC/FOOi7W9zOXg2yrh/n0+57E1kzSzjfjMp3HiKlzNpuNDgvbCtto0HIOsuJsKaTNHKRAoJ1ip0PPOAyX782anOppC2HrbtUgw0qeWJSSWkyKfmFLLZj7H0uXUtPAA62mMT7II+Xd2yXUvcwT9oXkJ9Uc/yBBMtxuk3W59Lg+LkCJoidKnxPHmasc/EpCauZpWsz5DLhU+xTSkPFn2IfAXAJ+LaY0GJmtqlEBLZJ/lYF370PfGbmVvjMD2wpLue52QoxxxqPRmX3yZG+GnBIHiluBkxWCFNuy64QUCcCaeUW6nFd38fvMuKXLJsniCRvvs1CQuwsDIB5pETkg+r1jQJDHVk3taagGUtVLfbItILoEJ65CJE6FXOj743AhP0k8OtVASph4ZihO2gKnkbkso97KSO4cZtuF9cNzojG7NjfHVFhj1H6R8oXhzrmUu2PMBfE8p7TWCVV7W2V6ej2kYsMj64zXm7/ku5GhoN6uHm1ds0MJ/FxUp9re0A8NtAnBUFcBRUF/e4VB8q1nbwDRQ31X/gl8Esw+ltEVhXvhI+tnqcwEY2oulxNfklXVurD4xJDxKI3JHaDlvLiU+iWhas456kk4DGkYUxP9cByuqM00Y+xOx0JcQ5QDmEaaHKiwmRzZKAfL2cRXci+smULf+0UxUTKpU8ZHAIpaaVl2SjyWbo+TkzPt/30V7onLI36w4Ipo5pvShAT/lWZYcFH8LDUdmT25swGkuYBSshrqxkKYno38T15ywqI5bv6ug/JFbzCzmMov8r/FWJ1lCtxjTHjRlZRzLWAnmXgDIOgQwLuUL59aCMy82FksVsBUF8TBFh731eY939ENLbKfnYn7Y5eEcf+ExXniouSLqsSgGbziqGMtqvdLCfEjjj8M0zjzUAMhWcWkxMEceDbJ6yUcF8E8FShPsGxJ3ndSMkUaO5gfE70HO7 dSuHZ175 aeZ3ae+mhztnEMRAcMyY4eGGvt8k+jyRLGYk2MJEIMMw4Jy70y4unqq6JsjBi8diE7VjQ1te9hZ5811jinJ04YMzAl76Ns2VTjZrZ4y9peeaqMloumaCIvxgGR0GOp6oUu5TA6dPdXBQbXd9ldkW/1ctEiBlPg/FiJJ5ihakgre1iTz4YWJMTb/J+b2T4biNbJ2j/nKjaf7c0GyyXBYTTzazMy3n8Y9FQZQjzd/Ph4xKK7+S9IUqGreCOSPFcYXAKoh/yYxSyAg3+W0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 15, 2024 at 01:38:40PM +0100, Lorenzo Stoakes wrote: > + get_maintainers.pl people for drivers/misc/sgi-gru/grumain.c > > On Sun, Sep 15, 2024 at 03:09:35PM GMT, Dan Carpenter wrote: > > On Sun, Sep 15, 2024 at 01:01:43PM +0100, Lorenzo Stoakes wrote: > > > On Sun, Sep 15, 2024 at 01:08:27PM GMT, Dan Carpenter wrote: > > > > Hi Linus, > > > > > > > > Commit 79a61cc3fc04 ("mm: avoid leaving partial pfn mappings around in > > > > error case") from Sep 11, 2024 (linux-next), leads to the following > > > > Smatch static checker warning: > > > > > > > > mm/memory.c:2709 remap_pfn_range_notrack() > > > > warn: sleeping in atomic context > > > > > > > > mm/memory.c > > > > 2696 int remap_pfn_range_notrack(struct vm_area_struct *vma, unsigned long addr, > > > > 2697 unsigned long pfn, unsigned long size, pgprot_t prot) > > > > 2698 { > > > > 2699 int error = remap_pfn_range_internal(vma, addr, pfn, size, prot); > > > > 2700 > > > > 2701 if (!error) > > > > 2702 return 0; > > > > 2703 > > > > 2704 /* > > > > 2705 * A partial pfn range mapping is dangerous: it does not > > > > 2706 * maintain page reference counts, and callers may free > > > > 2707 * pages due to the error. So zap it early. > > > > 2708 */ > > > > --> 2709 zap_page_range_single(vma, addr, size, NULL); > > > > > > > > The lru_add_drain() function at the start of zap_page_range_single() takes a > > > > mutext. > > > > > > Hm does it? I see a local lock, and some folio batch locking which are > > > local locks too? > > > > Ah... No it doesn't. It's the mmu_notifier_invalidate_range_start() which is > > a might_sleep() function. Sorry for the confusion. > > OK so in conclusion it seems to be that Linus's commit introducing > zap_page_range_single() accidentally had smatch hit a might_sleep() via > mmu_notifier_invalidate_range_start(), but it should, in theory, have fired > due to page table allocations invoking the page allocator that might sleep, > but didn't, because smatch misses the below might_alloc() path... > > -> prepare_alloc_pages() > -> might_alloc() > -> might_sleep_if(gfpflags_allow_blocking(gfp_mask)) > > ...as a result of get_zeroed_page() tripping it up *breathes*. :) > > (please correct me if I am wrong here). That's an accurate summary... > > The preempt_disable() is introduced in commit fe5bb6b00c3a9 ("sgi-gru: misc > GRU cleanup") from... 2009, but it fixed it from the far far more broken > 'disable preemption before taking a mutex' situation that existed before. > > So fix seems to me to not invoke remap_pfn_range() with preemption disabled > and a mutex held? gru_fault() maintainers added for input... Every time I get a response to this bug report I feel dumber. How did I not see that this was a bug in drivers/misc/sgi-gru/? Here is another one from the same driver: drivers/misc/sgi-gru/grukservices.c:262 gru_get_cpu_resources() warn: sleeping in atomic context regards, dan carpenter