From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB96C67861 for ; Fri, 5 Apr 2024 10:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE8E26B0154; Fri, 5 Apr 2024 06:44:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E71726B0155; Fri, 5 Apr 2024 06:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9DEC6B0156; Fri, 5 Apr 2024 06:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC7D16B0154 for ; Fri, 5 Apr 2024 06:44:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 67C73A1863 for ; Fri, 5 Apr 2024 10:44:27 +0000 (UTC) X-FDA: 81975144174.11.EA2FEF7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id F24ABC0013 for ; Fri, 5 Apr 2024 10:44:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4++e9W9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FtpHEAcp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4++e9W9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FtpHEAcp; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712313865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ujKJNakC2lY1afOYTNxjDOu1u3voQsxq+lDvp53sD9I=; b=GL31d4921UHMTe4xq/hTy/b3Fkz7v/o4ayVsLmLfRlSyuFzI7Z3rFTbTMp0mtqv0syKlfq hnL1Z8UkSCmhdTEcUdQTVfQLHXqIbd60E4QPVgK6w9KDT818kOoQIJt2FdV5NlYUvqgTFo iSPrssn7JYop9vflL4JRTizYBxLQh50= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4++e9W9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FtpHEAcp; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4++e9W9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FtpHEAcp; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712313865; a=rsa-sha256; cv=none; b=EPZuYzCf13GR1G9RLblyYlqQVlx/SoSLUHbrDhrw2lHKwp3muN4FXY4mEw0CrDAChhS1e0 2xd5fMOB/AEWzLti+KRUTOZBKODuvfrPDbrDFu8lzShHdl4grTE/j0WhesG2TdCU6dzekJ fNS+iaU/gc+DueXrYgZ/iURwsUgYfw4= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9BEFB21A34; Fri, 5 Apr 2024 10:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712313862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ujKJNakC2lY1afOYTNxjDOu1u3voQsxq+lDvp53sD9I=; b=j4++e9W9r8Pl33/JlVK9iLxWXn00q9gdZDwnI9mK7jlrFQkK7wQTbQeOZwe55COg8MDoqP /jvWm/klVqw6x4eCZf6MUvq/3r6tdMjAHeMpm9Jp4QCVjjX/621qDnn/t9YRG7+fT5urSc AgFmEkUg+shBQRvFzn/JJBcqefjVVE4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712313862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ujKJNakC2lY1afOYTNxjDOu1u3voQsxq+lDvp53sD9I=; b=FtpHEAcpdpP5lMTQI3E5MKG4VlaV95PKQiTPtGKvu6NetWZjVJ9AkZLpnMXvSthH838MDA LfDNDkWeg4rlUgDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712313862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ujKJNakC2lY1afOYTNxjDOu1u3voQsxq+lDvp53sD9I=; b=j4++e9W9r8Pl33/JlVK9iLxWXn00q9gdZDwnI9mK7jlrFQkK7wQTbQeOZwe55COg8MDoqP /jvWm/klVqw6x4eCZf6MUvq/3r6tdMjAHeMpm9Jp4QCVjjX/621qDnn/t9YRG7+fT5urSc AgFmEkUg+shBQRvFzn/JJBcqefjVVE4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712313862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ujKJNakC2lY1afOYTNxjDOu1u3voQsxq+lDvp53sD9I=; b=FtpHEAcpdpP5lMTQI3E5MKG4VlaV95PKQiTPtGKvu6NetWZjVJ9AkZLpnMXvSthH838MDA LfDNDkWeg4rlUgDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 6BEA0139E8; Fri, 5 Apr 2024 10:44:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id Ndv/GQbWD2bpcgAAn2gu4w (envelope-from ); Fri, 05 Apr 2024 10:44:22 +0000 Message-ID: Date: Fri, 5 Apr 2024 12:44:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 4/9] slab: introduce kvmalloc_array_node() and kvcalloc_node() Content-Language: en-US To: Alexander Lobakin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , Ilias Apalodimas , Christoph Lameter , Andrew Morton , nex.sw.ncis.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , Kent Overstreet References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-5-aleksander.lobakin@intel.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240404154402.3581254-5-aleksander.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F24ABC0013 X-Stat-Signature: 8s4sm1segcc165fj5438whkedjnuxiuj X-Rspam-User: X-HE-Tag: 1712313864-238991 X-HE-Meta: U2FsdGVkX188/GJKIGOaEfj3aOrh6RBX+O09btn16frycQDQf0UD2X+jz/2yvspzofUMcH0jfLsCJK+74S+fnD+khGdfCyz7AbUJIAoCTrkaOiDFnwaiyRqIVk5D1LhA/amiZLVw+GajRi6NdDsIuE5jtwK/+Vfrk+4QPzWv3kkFnH54TUS+65AlZg0SQ3N3eYBuWpiWUhv2GyFvafcna0A77ns7NyIm7NFC78gFpGK2CrdPAiBDqNCDlAo3hCSYuJ9Mz03y/BNrHOjQ+tmYJo0t1pOHGndbTTf2gcXp4Dg9jIGQ0YfODXmm8qh7MykmyQo0jAi12J7tNzCssdP6sHC9Ov3vffQm6QQ+Bp30e9JusHpu7S4XPkrCGt5MbggtwJUj7GHFnI72XVZNYaHCkLwTHh4P11OqdyrPdWCAFjScmTQRjR4OduLoC0m/C4gcZKkUvbog4f/HnoqF/LF2J3weiKPhrH3N1oaeNX2pSODt5FlmSCUWwnLYggAE14ygvPmuhjPha7Mk+ym6nhHkq38I2WSztQryikC4e8xFQ29DljSSGXjlZv2pO5zNpS4bo8lYiLkwR+RnJIHtReCHK/BF2aco/8rY7fukoAMrsig6ZcZJ4qrrGMDgE1uafCPFgXBZ/vpcHuB8AS60e+rm0IvbOPaPzXxdrqljcVQ6oSAGeromnRpwmmd4EvujwtWdgN7yjpc34nf+6KrPUHXKWWAT3/g3M3OKmK2HzlC+OTyAqD5aPnTyO8cGCMbw6XAxdAp2VbbXD0gw+1grEBanzNzeBZMp/3FwTNXB8ZWVPhzACxpQQaauBvHxFeOgoWDeO6ceyAPe51iYwSW8vsM9zmPkMsi9hT/oA3gHq450WEIcq4dL/lFWnLERAnVIrXkN+JqmF0ENCCbVCw7jtR4l6vChszoS0BuEARyds2m2c5RWbiwo7+sMiKRj2fJpyIcuk0P40RWTDLlB+ktD/6G 3Xojzc/+ 6scfdgWknVRrNLhAnNq1l7AA3Mc9S93ahLIRJNXz4qgV1zjUMGxDP/GANPCNTMRFyX43RVF1WdAi0Yoo2No/AAj4nJaf9qjV0do37SaA5O7r8n1Hulb7fXe+i/D0mj4CParMFCOxmxZWFGt7GogZY/tfscK+QEWqYDXY15x8w3E6X09i/PcR24Q9DJke+Hp4fEdl2iPiHT4hdLogAfKT8BXSK02Hv6r1MR4EwXlM8X0vq5ZZLP9LeUm8GsD8GLrgYqtXqhv7z9PLwpnOkvlaTEAaWOC43AgkdgkmHuwNfWTel1qFR9n2hj8NbznsM7D/cNerT1DB+dngvyyg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/24 5:43 PM, Alexander Lobakin wrote: > Add NUMA-aware counterparts for kvmalloc_array() and kvcalloc() to be > able to flexibly allocate arrays for a particular node. > Rewrite kvmalloc_array() to kvmalloc_array_node(NUMA_NO_NODE) call. > > Signed-off-by: Alexander Lobakin Acked-by: Vlastimil Babka This will however cause some conflicts with alloc tagging series with mm tree in next and the new wrappers will have to be adjusted. > --- > include/linux/slab.h | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index e53cbfa18325..d1d1fa5e7983 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -774,14 +774,27 @@ static inline __alloc_size(1) void *kvzalloc(size_t size, gfp_t flags) > return kvmalloc(size, flags | __GFP_ZERO); > } > > -static inline __alloc_size(1, 2) void *kvmalloc_array(size_t n, size_t size, gfp_t flags) > +static inline __alloc_size(1, 2) void * > +kvmalloc_array_node(size_t n, size_t size, gfp_t flags, int node) > { > size_t bytes; > > if (unlikely(check_mul_overflow(n, size, &bytes))) > return NULL; > > - return kvmalloc(bytes, flags); > + return kvmalloc_node(bytes, flags, node); > +} > + > +static inline __alloc_size(1, 2) void * > +kvmalloc_array(size_t n, size_t size, gfp_t flags) > +{ > + return kvmalloc_array_node(n, size, flags, NUMA_NO_NODE); > +} > + > +static inline __alloc_size(1, 2) void * > +kvcalloc_node(size_t n, size_t size, gfp_t flags, int node) > +{ > + return kvmalloc_array_node(n, size, flags | __GFP_ZERO, node); > } > > static inline __alloc_size(1, 2) void *kvcalloc(size_t n, size_t size, gfp_t flags)