From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC934C369D1 for ; Wed, 23 Apr 2025 14:29:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52B1B6B00A1; Wed, 23 Apr 2025 10:29:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D90A6B00A2; Wed, 23 Apr 2025 10:29:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37C166B00A4; Wed, 23 Apr 2025 10:29:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 160CD6B00A1 for ; Wed, 23 Apr 2025 10:29:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8FA38C0A6C for ; Wed, 23 Apr 2025 14:29:03 +0000 (UTC) X-FDA: 83365540566.08.76E123A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 585A520010 for ; Wed, 23 Apr 2025 14:29:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp8FqXT5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NVWwooAS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp8FqXT5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NVWwooAS; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745418541; a=rsa-sha256; cv=none; b=yeyF1vdOWj9JXZVsioDmjH5RsLJs9KWd6WcKrKRx9vU+8+MBCIPBulxJ6OPrNlShBQ2LYF H9hGiCmD8bB0GY9sEtMQknTSYxZvBW4p9r4IueecM5yDui1UFvyiYcxC3R+PwAj5jYk32J tW1qAvwRJ8e/HFc4FUAmqQxw0dlfVa4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp8FqXT5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NVWwooAS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dp8FqXT5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NVWwooAS; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745418541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=npgYSTolsEw3pRzOgXU1OaKWR6B0HZRvyZWAUvt1pes=; b=NQVSicWZ/+YAyBUeLmIVYKMi+6xBho6SNMaxuNPnsAS9VOHD9PqrmkZzcxC9fC0QmDWCCH qat3Zgg/TgryyUfMOws6i+T0oMsF+H/WyA3y1Ew0n0a+13NxrkJL+MGC+nucgK1WjeT2Xm zCDuAb6w/WcnjaXsMTuSr/SzEJhKtOI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E44A61F38E; Wed, 23 Apr 2025 14:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1745418539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=npgYSTolsEw3pRzOgXU1OaKWR6B0HZRvyZWAUvt1pes=; b=dp8FqXT5X0rN0CDV3WAjIZGGZuVU7E1HV2L/5EEpfgdPvAPEAATvA4qZ9Du4y+dTGdDkNo vX38hLNbsmkZFKFlPNRBtlKzvPka1linVisfbyaGOzMIbmmR6WG88rN8iBMTHJjYuaxAMQ kPNv5SJUZNtZtv2TsRuQsyFainUfh3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1745418539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=npgYSTolsEw3pRzOgXU1OaKWR6B0HZRvyZWAUvt1pes=; b=NVWwooASrJzzBKmT/F8JjQAHDibk0AiRonGHt60xqA0+dXzYPzFSZDll/O8krwPEeMhF4o tR92lcvzUgGpTsBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1745418539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=npgYSTolsEw3pRzOgXU1OaKWR6B0HZRvyZWAUvt1pes=; b=dp8FqXT5X0rN0CDV3WAjIZGGZuVU7E1HV2L/5EEpfgdPvAPEAATvA4qZ9Du4y+dTGdDkNo vX38hLNbsmkZFKFlPNRBtlKzvPka1linVisfbyaGOzMIbmmR6WG88rN8iBMTHJjYuaxAMQ kPNv5SJUZNtZtv2TsRuQsyFainUfh3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1745418539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=npgYSTolsEw3pRzOgXU1OaKWR6B0HZRvyZWAUvt1pes=; b=NVWwooASrJzzBKmT/F8JjQAHDibk0AiRonGHt60xqA0+dXzYPzFSZDll/O8krwPEeMhF4o tR92lcvzUgGpTsBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C8D7613691; Wed, 23 Apr 2025 14:28:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yIUnMCv5CGj8bQAAD6G6ig (envelope-from ); Wed, 23 Apr 2025 14:28:59 +0000 Message-ID: Date: Wed, 23 Apr 2025 16:28:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v1 0/2] slabinfo: sheaves statistics support Content-Language: en-US To: Harry Yoo , Christoph Lameter , David Rientjes , linux-mm@kvack.org References: <20250407041810.13861-1-harry.yoo@oracle.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 585A520010 X-Stat-Signature: jjffkttx9jw7fsx3oijntw5c7gc4g866 X-Rspam-User: X-HE-Tag: 1745418541-680408 X-HE-Meta: U2FsdGVkX1+EE2WRn+Cp0JtUwDMMRbkgzMxIJltVXX5iKwxT+3dnzZxK6BwuEyCv6RFYnpzqe6Hkr7k5T96Rz6+P4E8L7h8Lz7r2xuBbgUmZ4uF6Xfy2danpJh9yBXqiLkzRslKx5ehzVh9ojIXbRymgPYUs1Ob/79lZhX5pQGBuK7v4XSO1LAkgfGDfY2AzOw7h9EH1fINgYH5hK4wdp9J1XOBfOjWx8qE0a5iGBoXQ9JbkcPN9+sbF2y6BifBCbaQadQrnmHKwsQnN+LB6Eda5Nm/L+/6MfIvOndLst8+yIf/0N5c3BnKN+fdsc2fxKAaVt1X1/7zifFKMupJYybrEVY4B6WAyoCY/2yn1pmL4oJ9f5/jr8hSCseTHjcCTTNVSAg4j894i211oGF8g6pATBUcPAYV7LY9PjyNHhSgXt8E6UGPCIJZJC9PffILndsLsRnzdWQ6/VbXW5dDnad63T5tXMf18NGstxGa87SfvF/3Fby4NMSzrSiWIIf5HSLTzL7a6l2JtawS7gp0i0U06JClGzpGQdWkuFELCS3NqP3vJ9Pw5+iCSGT505f8EOGjhlKqRUaOpcdJQAfRbbnk75gwERMlFf6/D2BK5pimq7Vz902BP/q010jrq3AWXuGBPDwHfxTpVGxF4o0jd+E3N8lelAKMViNMIoOvdbJcVrR9L43zQM45UzPxzyXldYUUogefE0E1lZp9DCsZWy6ZSBexUVNTlYELEXdzIREJ8Jj65ImL51r7KkraSzwswCB8bHFHJUm8ZAivJT7zGy0vyQM2M42DHHjCkB/mQ4PxINSMD7i/Dns3RZM5kfd4bAtaMXiSpIb472GQgrRSH9ZtDlsbrno8Tenq4mQAI6z7WTm5xJjb0TT3nPAxuRbhuxesfzs0+Y8i5X+b93N+e/g4wOsX7ZNzcHx7YJahW1zblCFT4gTjg4puJEFofM5ZfNbsRlxshIlZpjPCI8m1 CqQHFmQj 5qeJdlMd32n7OxAXiauzr1CCpr1vpw4lTgsx0NttAmvRly2rZKxUULPc6lHNtWgtzgeimS36RdvvaizAfc8D9s4Qd8ED13Vm75L7jH0fQGdxXIOkF96IpXWQMsBzmO90TWwTEc28gaKBvnWt77eN6lrIU1IshxvD3DQMUbKWaQkUqFjjSluQTA+uhDwiDPrM/sSyI5bQtoJVgdHWcoEAaNeQyaGeeELb2ftd3Fli0UgRKbltnpoewnyeD7hQv1cDTMC6DhZCruCFVHdB0qMYuJT5c5kHPqous+sKj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/7/25 06:37, Harry Yoo wrote: > On Mon, Apr 07, 2025 at 01:18:08PM +0900, Harry Yoo wrote: >> With this series, `slabinfo -r` now prints sheaves statistics (if enabled). >> Written on top of slub-percpu-sheaves-v4r0 [1] branch. Thanks! >> Q1: Vlastimil, do you want to integrate this into the sheaves series or do >> you want me to send it as a follow-up series after sheaves land mainline? I think it's fine to do patch 2 a follow-up. As for patch 1 I will instead export sheaf_capacity as part of the initial support. >> Q2: 'sheaf_swap' does not fit into the table because SLUB swaps sheaves both >> at alloc and free. Probably split the counter? I'm considering just dropping it instead as it's not that useful as a measure of caching efficiency? Probably sheaf_flush_main also doesn't need to be a separate counter as it only happens in corner cases. Due to ABI becoming set in stone we should be conservative. > Q3: Having 'Add sheaves to the barn' & 'Remove sheaves from the barn' counters > might help better understand the behavior? (just like 'Add partial' / > 'Remove partial' pair in the normal SLUB path). Yeah that could make more sense instead I think,