From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A746E7716B for ; Wed, 4 Dec 2024 14:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1E0D6B0083; Wed, 4 Dec 2024 09:31:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCD7E6B0085; Wed, 4 Dec 2024 09:31:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABC226B0088; Wed, 4 Dec 2024 09:31:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8FDC76B0083 for ; Wed, 4 Dec 2024 09:31:09 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04A59C1156 for ; Wed, 4 Dec 2024 14:31:08 +0000 (UTC) X-FDA: 82857513438.12.4714136 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf04.hostedemail.com (Postfix) with ESMTP id 3A3E540023 for ; Wed, 4 Dec 2024 14:30:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FRjYTeLC; spf=pass (imf04.hostedemail.com: domain of haowenchao22@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=haowenchao22@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733322654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yERF6VCtTz7SIEjSl38TjVuiwNFWoV8cA+qmoqUvTRo=; b=c54Ok2e/IeIc2qsuaXx+wn5L9jPTaTQAzhdPlN9n0qceyGId6iQZnjFLBMQ/KxlcoSDnPc IQgvBfcOoFpgx2owo1aVHiE0eIHBCpqUeemhiX5ASGSmbN8SR3KadLsyekgZfxaLa9zoIf 75JLmKFEXWsu43JYeNLd0LBvTq3v8yU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733322654; a=rsa-sha256; cv=none; b=zSo6gpcMben//XtGDF/PfUA8cxR8Ct9qXuadqOoqoLsCE9RSnZb1/AMgnY8UXBZEF2dnzu 54jNvqEuwYlM58mx4xdSZ6tDo+dwiYebF5fjOPWTGNcjYQfrRKCnmWgteOm5kChTOI9ON1 7dpYS4tq3PNhe/9RXycb6/vw5vJhpec= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FRjYTeLC; spf=pass (imf04.hostedemail.com: domain of haowenchao22@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=haowenchao22@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-724ffe64923so7262050b3a.2 for ; Wed, 04 Dec 2024 06:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733322662; x=1733927462; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=yERF6VCtTz7SIEjSl38TjVuiwNFWoV8cA+qmoqUvTRo=; b=FRjYTeLCnXPLSzkGK9C+Gla6zG8NuW10DN1Jp4omUipx8ax4WuTuTgd1oq/UfgjnV6 YkMAhG56EIsyMxt0ozhBcGNMWgig7eIJ905Z+wKkJlTOP/7m26uOZmDvUuAC1L6L0xsc hj+peKkiKNWujor2gzQFBUEOgxGvzD/63npsuUpOEUoviRq1j5c+/ftYmtOgg9/EUuoH kyF+iY5mS6ASQON1ihSwBWDbrGVIZvf5kEayN1PRohKK75lkiTnEjM38EmmDezcIH1bS Rr7y+DP4LzYwb95URr2ym4trgAiT9pK8ePpyRaqqIRYD9vJ9HYK8MXcANe7POzMtkHmm C/Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733322662; x=1733927462; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yERF6VCtTz7SIEjSl38TjVuiwNFWoV8cA+qmoqUvTRo=; b=ewJnuvg/mv+FP8seDPa7Al8a2IIod09jH/rtX8kTyGQpmzICn4YbVRo1B7OSPMtQCj 78NmS2QlxS5GTLwzTAl7OzM79T9T3YJ5dzcjGvlLWQ7GtNtY9H7xDUpFG7uqk//Z0/65 xJ3Anq6sDYjrnA5+xiwPXEKwpYmQWMy360G9aKxMzU/2MCZZiKNVsylhuZL3vnOcbgov YfB+AgvQdHDRELxp8KQ2+qaiP5o+MmvpjlavpL+VIssQZGQ0ICslgxayNs1z6lw+806E guG2pqK7t2FhtC3WN3iUrD8l100gK5vC+n/AzU2LJi8fT/Q3tIhWkQe5ty2oxyQk79Kf VB/Q== X-Forwarded-Encrypted: i=1; AJvYcCWokWRKEnRANcguap4ipZ+i9xSHHilDKJfZZOB/MVC0XnXHfksTUV/elA0/e+2l2MQrxSV61nkeBw==@kvack.org X-Gm-Message-State: AOJu0Yz7+2sXRC0S6/8VvwlD/rUyCiksWKBGeXSJ4BvHFxk3w9WA6+tB IHVvfeGc4Ru1oD7jpGIqS8qaGhujbsbRtu6sqjiv0AdgHl/LdbX4 X-Gm-Gg: ASbGnctdEFUeEBWw62PBb9BgR3nwojsmqThmsUgdrLT9p+56khz5LPdtKGoBwzf9L4Y cO4IIiR7pt1xGU+IEMfZ0DO620NIhZGhjem9zcmG5TFZ6sHdaW6PT9hudEtQhq0vQV89HjnJF2t Pj2Tk0ushwqmiSo87Hk7BmKdVdMy0sfSUbJR93u07ts8jc9Ak8Hgl3gRCflLLSWP6Tjxa3niFW4 flb898o4KFzGdsdSvW6caakRtBxVYWvCGVLyIOCWGEvNK6X63oP+1owjng= X-Google-Smtp-Source: AGHT+IHCmj9MQosZNtKH1r+fGojOSp3mgTUytzHtuPCGtR6ojxpPgcwmykPfmMare5C92TgoL5IELg== X-Received: by 2002:aa7:88d3:0:b0:725:4615:a778 with SMTP id d2e1a72fcca58-7257fa5f065mr9772323b3a.7.1733322661032; Wed, 04 Dec 2024 06:31:01 -0800 (PST) Received: from [10.239.15.156] ([43.224.245.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725417612c0sm12464807b3a.17.2024.12.04.06.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 06:31:00 -0800 (PST) Message-ID: Date: Wed, 4 Dec 2024 22:30:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] smaps: count large pages smaller than PMD size to anonymous_thp To: David Hildenbrand , Andrew Morton , Matthew Wilcox , Oscar Salvador , Muhammad Usama Anjum , Andrii Nakryiko , Ryan Roberts , Peter Xu , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20241203134949.2588947-1-haowenchao22@gmail.com> <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> Content-Language: en-US From: Wenchao Hao In-Reply-To: <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3A3E540023 X-Stat-Signature: wz4d8gw9wfe53rshkqbc1aegmahjyqp9 X-Rspam-User: X-HE-Tag: 1733322647-231595 X-HE-Meta: U2FsdGVkX19uoCovpK5pBsr6mfMeLMX+yeOJvZjU1MGFyjYlfcETMJIanPLWlQ/3vEQ+FIJuZR9uE1qdYe4Zd/YiuqgVdxbTcbGiedTBkCZ49euhzRcU0EcbDbqJb9ndZysyZ6tKP5KF5XWiM+cCOQ3uVv0NYOx10RasA2e2ljMpWscTRcdCdzCSpXpzSGb/5UbXHL1WGUIZZfgnTO689WQ8aLNkguUO/TwHUvTcUSyQmnplVJBAs3hqRlJEdzg8DUw8l0HDOupLTxVssMZbUa+8gVLpp0sgLlWpTmIufC47vJ+0MEseznpB+OBZjACK4u7pjuhr60q/O0mJIR7GKiDV23YyW9rtGHmbNj4aB6D4in1+CtHoGTjsvbVEJx7iAYs7EVaHOhwvpRBF1Kt+evD4LyhTYLckXvZrYwNhZ0pkgltY6714JG07YfmuJxSdi4E3Z9/pp+PchymwqFmVaCLrIe/yg4OV0NzQ3nmcj5JRMqQy/foL4LmsxIEu0fIxh7+vrzrh1Ij0uzvsPf1wXlM/5FqMVGFZUERqs1T7lA+uDv1G7blmHdabMKpV3fxmh1lQvvD8bwgdQGpMTXZJXjhkRXdklyWuHd1igDS4LptQuA5u9dWPL3I97harF93hhi++L6KBffOrf73+ZYzOweZsdbbbYwXSvPQBrk+mRzqxe5864CTNc1HOJoxDfOJqNCQy3JIvvzqy2qQklGu8HwN9QfsTfLeaeP86KxVml8CehtZ0aXVBazUttpcRqosKIYS7+KVbBRW+TmmkaKG0QWh5J44Bu6xpOb7Y8YCWULDkoAr40SbPLARDCiU/MXqAGxNwEb0yFc6x1JiBlPf+WKRVBFO/e+Waess1aadMcsJdgZyMhNy21V5CqPOYbaGQo98x9O6H7vkM3R4fMv/4A5he3pQYZNWqSeagjUnTQqfse5r0Po+pzjVtkS+9LY7vQxsyrqZTB/uLQXVbBIY gTLZcfeC k+cNFP2f02D0eFXCjMVhqYWkNm95wLRYfYBeWAaSuj9JYGbjOLDGsCZ7DUr/tbJfUdKBVTZFX6v8a+iPhHFe+qBNB4w4tOLt2ltu64bC24TO9vLLBeLOExS3RIGP+6nglZfYvQz8l4Jxaym46K/1bQk4S5VT1g6KEkuhMhbnkwNjKKV4YKGlL/lnVjX3o3Sx2Ayt5ol6IK6SClMbQ4/rtH4t60imyYffJQgnJEEbmVKEi/3igtp1Kbzi4++2mxTPPzgkEPIqAYbo6LpMEbgR7rdfSVnaO4EfvQIP8iA5Cg09j6o1muQnwd4fWrblDVPYhg5LZsfjy6xBlkPsXgdRIFhkZ6ql99pMW3OolaecvMg+royEqSlHbyU9EA1AKgrsDgBDb+tDbRlh8lQQFkw+16/BbCOg5fnbyQfbzFPd/Od95YUwchMlIkCJsHacHhouvRbZkmdgZXpZToFBUFWlxIYqDd2mLXbQLcAU8MqgAiCh1KmfdbCwyiTxeUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/3 22:17, David Hildenbrand wrote: > On 03.12.24 14:49, Wenchao Hao wrote: >> Currently, /proc/xxx/smaps reports the size of anonymous huge pages for >> each VMA, but it does not include large pages smaller than PMD size. >> >> This patch adds the statistics of anonymous huge pages allocated by >> mTHP which is smaller than PMD size to AnonHugePages field in smaps. >> >> Signed-off-by: Wenchao Hao >> --- >>   fs/proc/task_mmu.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index 38a5a3e9cba2..b655011627d8 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -717,6 +717,12 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, >>           if (!folio_test_swapbacked(folio) && !dirty && >>               !folio_test_dirty(folio)) >>               mss->lazyfree += size; >> + >> +        /* >> +         * Count large pages smaller than PMD size to anonymous_thp >> +         */ >> +        if (!compound && PageHead(page) && folio_order(folio)) >> +            mss->anonymous_thp += folio_size(folio); >>       } >>         if (folio_test_ksm(folio)) > > > I think we decided to leave this (and /proc/meminfo) be one of the last > interfaces where this is only concerned with PMD-sized ones: > Could you explain why? When analyzing the impact of mTHP on performance, we need to understand how many pages in the process are actually present as large pages. By comparing this value with the actual memory usage of the process, we can analyze the large page allocation success rate of the process, and further investigate the situation of khugepaged. If the actual proportion of large pages is low, the performance of the process may be affected, which could be directly reflected in the high number of TLB misses and page faults. However, currently, only PMD-sized large pages are being counted, which is insufficient. > Documentation/admin-guide/mm/transhuge.rst: > > The number of PMD-sized anonymous transparent huge pages currently used by the > system is available by reading the AnonHugePages field in ``/proc/meminfo``. > To identify what applications are using PMD-sized anonymous transparent huge > pages, it is necessary to read ``/proc/PID/smaps`` and count the AnonHugePages > fields for each mapping. (Note that AnonHugePages only applies to traditional > PMD-sized THP for historical reasons and should have been called > AnonHugePmdMapped). > Maybe rename this field, then AnonHugePages contains huge page of mTHP? Thanks, wenchao > >