From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8AEFA373D for ; Fri, 21 Oct 2022 15:50:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 104268E0002; Fri, 21 Oct 2022 11:50:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B4848E0001; Fri, 21 Oct 2022 11:50:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBED58E0002; Fri, 21 Oct 2022 11:50:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC4EF8E0001 for ; Fri, 21 Oct 2022 11:50:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B69561C6E17 for ; Fri, 21 Oct 2022 15:50:43 +0000 (UTC) X-FDA: 80045394366.15.E4FBAA1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 0DCB5140038 for ; Fri, 21 Oct 2022 15:50:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B17E1F8BA; Fri, 21 Oct 2022 15:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1666367440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DII+7luap8mc/o2KNlYlLUHPxsLxFa8m0/bo2FeFrWc=; b=ZV1+yQgR0xpwvV6lamom5Ibq+hV6T/KsS7K3EaKO0yCCSmBSXkV+0kRiWuGeS/M7qXyWaE 1/4KjYpuerhzVC6QZSvESKSJ031CNpm/n73JIS3jssM5JusJOeM0ymjBp7YXRjZsyosms9 jKINnM47UttlK5nezUS2x0htPyLLRX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1666367440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DII+7luap8mc/o2KNlYlLUHPxsLxFa8m0/bo2FeFrWc=; b=YJsJVMrEDWM3iFfSqdB24dtvyunJ1pk4mK8ZDg1QBCyfA3AF6IkAzDh8SwJ5nLGA497u1l 490sLdmWnNYFu+Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 445B71331A; Fri, 21 Oct 2022 15:50:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5gDAD9C/UmPnSgAAMHmgww (envelope-from ); Fri, 21 Oct 2022 15:50:40 +0000 Message-ID: Date: Fri, 21 Oct 2022 17:50:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH rcu 5/8] slab: Explain why SLAB_DESTROY_BY_RCU reference before locking Content-Language: en-US To: paulmck@kernel.org Cc: Christoph Lameter , rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, rostedt@goodmis.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org References: <20221019224652.GA2499358@paulmck-ThinkPad-P17-Gen-1> <20221019224659.2499511-5-paulmck@kernel.org> <03d5730-9241-542d-76c6-728be4487c4@gentwo.de> <20221021134309.GG5600@paulmck-ThinkPad-P17-Gen-1> <8504f36a-b6bc-4c46-843e-55d8cd5a1dd0@suse.cz> <20221021154224.GJ5600@paulmck-ThinkPad-P17-Gen-1> From: Vlastimil Babka In-Reply-To: <20221021154224.GJ5600@paulmck-ThinkPad-P17-Gen-1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZV1+yQgR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YJsJVMrE; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666367442; a=rsa-sha256; cv=none; b=hkyZgrQT1Cj2XPIPLGv8YRQawS8CVz+Sb96B/a0JVlcVthFIr3esvl7ScfZoQMA6eefRn3 hTLiKY8KH9aW9JvzjWRyaEJaTIdpfrUM+w3aWQ/KuHENRhJI3kkeG0Ax3R4C5xh1AEvsJG 0a9IfgBWVx/7V2mMkFq/QGFVc2HFNZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666367442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DII+7luap8mc/o2KNlYlLUHPxsLxFa8m0/bo2FeFrWc=; b=YlPnSM16Pd7fcQJAuGlYCJBjp/Af6j7e+v8Enwzict2GAE2XBMDFnR+GGpnk+43wzg939Q fFZPETxlPU7nrDqgTpWoGYXcSNHzqb9a2ReRZJ36YoWrwdThB98RwbDxbAlV+TdDxhNuxX SGZFSNGvhOFHloFQKVeW7VzQVjOl5Aw= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZV1+yQgR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=YJsJVMrE; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: 3bbtmn81bnbbq8hzcufqt7sk9wzqqq7r X-Rspamd-Queue-Id: 0DCB5140038 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1666367441-163746 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/21/22 17:42, Paul E. McKenney wrote: > On Fri, Oct 21, 2022 at 03:50:17PM +0200, Vlastimil Babka wrote: >> On 10/21/22 15:43, Paul E. McKenney wrote: >> > On Fri, Oct 21, 2022 at 09:44:23AM +0200, Christoph Lameter wrote: >> >> On Wed, 19 Oct 2022, Paul E. McKenney wrote: >> >> >> >> > It is not obvious to the casual user why it is absolutely necessary to >> >> > acquire a reference to a SLAB_DESTROY_BY_RCU structure before acquiring >> >> > a lock in that structure. Therefore, add a comment explaining this point. >> >> >> >> Sorry but this is not correct and difficult to comprehend. >> >> >> >> 1. You do not need a reference to a slab object after it was allocated. >> >> Objects must be properly protected by rcu_locks. >> >> >> >> 2. Locks are initialized once on slab allocation via a constructor (*not* on object allocation via kmem_cache_alloc) >> >> >> >> 3. Modifying locks at allocation/free is not possible since references to >> >> these objects may still persist after free and before alloc. >> >> >> >> 4. The old term SLAB_DESTROY_BY_RCU is used here. >> > >> > Thank you for looking this over, but Vlastimil beat you to it. How does >> > the update below look? >> >> LGTM. > > May I please have your ack? > > Thanx, Paul > >> > ------------------------------------------------------------------------ >> > >> > commit ff4c536e6b44e2e185e38c3653851f92e07139da >> > Author: Paul E. McKenney >> > Date: Mon Sep 26 08:57:56 2022 -0700 >> > >> > slab: Explain why SLAB_TYPESAFE_BY_RCU reference before locking >> > >> > It is not obvious to the casual user why it is absolutely necessary to >> > acquire a reference to a SLAB_TYPESAFE_BY_RCU structure before acquiring >> > a lock in that structure. Therefore, add a comment explaining this point. >> > >> > [ paulmck: Apply Vlastimil Babka feedback. ] >> > >> > Signed-off-by: Paul E. McKenney >> >> Acked-by: Vlastimil Babka It was there :) >> > Cc: Christoph Lameter >> > Cc: Pekka Enberg >> > Cc: David Rientjes >> > Cc: Joonsoo Kim >> > Cc: Andrew Morton >> > Cc: Vlastimil Babka >> > Cc: Roman Gushchin >> > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> >> > Cc: >> > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h >> > index 90877fcde70bd..487418c7ea8cd 100644 >> > --- a/include/linux/slab.h >> > +++ b/include/linux/slab.h >> > @@ -76,6 +76,17 @@ >> > * rcu_read_lock before reading the address, then rcu_read_unlock after >> > * taking the spinlock within the structure expected at that address. >> > * >> > + * Note that it is not possible to acquire a lock within a structure >> > + * allocated with SLAB_TYPESAFE_BY_RCU without first acquiring a reference >> > + * as described above. The reason is that SLAB_TYPESAFE_BY_RCU pages >> > + * are not zeroed before being given to the slab, which means that any >> > + * locks must be initialized after each and every kmem_struct_alloc(). >> > + * Alternatively, make the ctor passed to kmem_cache_create() initialize >> > + * the locks at page-allocation time, as is done in __i915_request_ctor(), >> > + * sighand_ctor(), and anon_vma_ctor(). Such a ctor permits readers >> > + * to safely acquire those ctor-initialized locks under rcu_read_lock() >> > + * protection. >> > + * >> > * Note that SLAB_TYPESAFE_BY_RCU was originally named SLAB_DESTROY_BY_RCU. >> > */ >> > /* Defer freeing slabs to RCU */ >>