From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10816EB64DA for ; Fri, 14 Jul 2023 09:55:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B0E86B0072; Fri, 14 Jul 2023 05:55:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 861F46B0074; Fri, 14 Jul 2023 05:55:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7287B6B0075; Fri, 14 Jul 2023 05:55:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 605BE6B0072 for ; Fri, 14 Jul 2023 05:55:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F194AFFA9 for ; Fri, 14 Jul 2023 09:55:37 +0000 (UTC) X-FDA: 81009760314.06.BA3990C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id B29641C0018 for ; Fri, 14 Jul 2023 09:55:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z80bSIfh; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689328534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kf132iRZ20EenuRtRXLIaAVz4mLH2YgT891kbbdMT6M=; b=ulPz8MCp+UunoSo5HFdf5N1H4tDZ+Rac5vabk1ZgeqhC+3P/76I8MyH91QhOl1BYzL5K5X 4xxMRLBNaq+TsluDsan+Ocvnf/vkWwtn7cWPip844+oCN4Aap7V+96q2q69J68Fbnd4JHa 0Vxum/KI7KDkweyifuvS+rwcy2GclC8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689328534; a=rsa-sha256; cv=none; b=ddPYN8mxZM2BSF45XKqic5HTFs5DToNHOii3K2JiB4YpshomJQMWjiOa6sgD2do4TUcqyE xpaVMweb1x5kJG8d73BPGHUr8txna2Os+aQEZaNYC34WABb8HCpZFJBEKvnIVS96g6ybgl eJBGJLWXRL9cUdNC3nqjrZkEnfT0geg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z80bSIfh; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689328533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kf132iRZ20EenuRtRXLIaAVz4mLH2YgT891kbbdMT6M=; b=Z80bSIfhZ+bs8XuqkaPX4UqRhKHNs+6L+3gKol3WeGYbte+uMGmiFV6aKtoLFFano/lU6O lTCrac/WmaFHyxiMrYH331TY9FIJG5p1ivUI9WhXcVjuqzkIbz95Q6YClyC+34pO7Ggr1C d6tVgm1wfrxSywhJbbPAjXLHe20vflc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-aZEpnbq3MD6L-9puHtC5qA-1; Fri, 14 Jul 2023 05:55:30 -0400 X-MC-Unique: aZEpnbq3MD6L-9puHtC5qA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-315af0252c2so1149389f8f.0 for ; Fri, 14 Jul 2023 02:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689328529; x=1691920529; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kf132iRZ20EenuRtRXLIaAVz4mLH2YgT891kbbdMT6M=; b=TuyZOQzLCv82Jnw3prf4tb6BYAPtTGLc8qwcZhHrEGG5B7TCytnsuqRcBRRm+smsUp fyV+lVA36qjvm/3LRnJGEF6qFbu0LFyLOKeFVu9USvsfxsvS68uKqEKo3R5j0wQ4W/9x CSAO1pN4Guny+RteRFrE0Il6knWZi3iWaEkpH5AYeOgF6X8+gRnL3Hk4cF5790ZM5Y1z mKj4M5rLihK18Tp38famOChLRz9lORyqxs4P/YnKC7HchKf8OY5M6mFei98DMfwxoH7Q XGwtm9wZ0G54vIBcOuPzkMqo11lGO0FcljtvA5iqR54R/dWaDTmEwjKgimfOj8Tn8j80 tM8A== X-Gm-Message-State: ABy/qLa72hB45WBEovh2jl18Nr5BQT/B9p2mvQ5WKp6iBQjylH7woB+w WslWrG6bMWD7DfRZM0Z9S6uxzi57vKcbMORfRMClkC9GSIvzOlHBPYGgjVYO8bFO1DrN4QBBXJf LPvqololfqGg= X-Received: by 2002:a5d:67d0:0:b0:313:fbd0:9813 with SMTP id n16-20020a5d67d0000000b00313fbd09813mr3466959wrw.28.1689328529635; Fri, 14 Jul 2023 02:55:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlEdlUo+JN4v1o9lTJZqXuq/+tLZCVapgyI00wczrknXcEiLAc8BYt3hBc2KTjJX7LpL9n/i0g== X-Received: by 2002:a5d:67d0:0:b0:313:fbd0:9813 with SMTP id n16-20020a5d67d0000000b00313fbd09813mr3466946wrw.28.1689328529256; Fri, 14 Jul 2023 02:55:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:4500:8a9e:a24a:133d:86bb? (p200300cbc70a45008a9ea24a133d86bb.dip0.t-ipconnect.de. [2003:cb:c70a:4500:8a9e:a24a:133d:86bb]) by smtp.gmail.com with ESMTPSA id w16-20020a5d6810000000b003144b50034esm10371315wru.110.2023.07.14.02.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 02:55:28 -0700 (PDT) Message-ID: Date: Fri, 14 Jul 2023 11:55:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 0/4] virtio-mem: memory unplug/offlining related cleanups To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Jason Wang , Xuan Zhuo References: <20230713145551.2824980-1-david@redhat.com> <20230713110235-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230713110235-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B29641C0018 X-Rspam-User: X-Stat-Signature: wdeino94tjfmez4zdcnzfrpge1niizyb X-Rspamd-Server: rspam03 X-HE-Tag: 1689328534-533141 X-HE-Meta: U2FsdGVkX1+1o6sOsKFlmoaJlvl3UNrCYfPuEZgp6HuUexR7/pHFPWUpk8DTLiRdY6d/C+nkVpvBVJaXvZ6M6jCWdolMpoTUiSZYlpYPekvs2oTu30XwPiWh22RKSAG1XqSn1fDhqBrl1dRkGodKm8Y81pZIkwHmAmqsQGawthd54X9sDLE2ffwO2/I1kLaAt5Er/+YGK84PEta6c4jpKdMFKaeij5+rRXJhLF4+FPpfxF6rhKF8o2h7f51Vb1BIbMe7HL1KLnSLbiF0cAr7ZB63kqzS/ajB+dsZFY+sC72rK9OtSMSBaWAsygmUMtWoIUVZk2QdDXs0aj6qoBE+LVBllDrVcjl6Bq/xWB43bgO5FGsJOMfjXZV+OVngG0FjHEMrokzfAw9+X7t+ZQbtti7RUhACjYQzDaNfXdotyPLp3eVfoDbU2fs/7XxdcUlbpUrmivmIKvQ/TtldrMsadtmnxtEt5MFc788rulD3YUYGfg851Rz5qkgy5c2SchS6WuKqZMee4CIW2OrxF/owbzGD83wChABIHzZdTGbuXhoYbWpGjyrc6Qd6614bY3ypMr3Q0urypy6on+G3XxZP5dsi7SAuKlDhqbbi8pTdA8igzgXXhFL/HqWBR+x55N5ljBUl8jjY2MxjGc0jLIaBH199RNIMceBjczhPKrYfnCKsGfRS1GJnBGHr0sCwcR6lqvEeB4QzJrfKDsJVUSM44yaxgJkOZ4PgH5jNnqSZUYtmfMFzPgWYvP63wqzMPH36/Lou4LfMXRR1S16gY+VXoRXN8lx6RYtdj/F/XuWIKubG9WdEvbk/WU3aVFpRP+N9qjCZla6Mw7Jq9HWrjolvqoguy2+MDEDKuqjMRSb7L1fGP2VLIsM/510uKchYdnGJ+pPET+VMhjmnJEK32QiJfpuRVnW/EkD3zfqI9QZsfT9N7Py301K94MlUBHL4XgFAhRxsCVJ+fATuWbmIJpu dSp33Rj8 DTYlRqOLqUVglQpggRE1XCBPH7GpMOStFqEqEUgYtBHSaa1gfaANWtE0xV0UdsmcmJmTAGJxJcI06U/51mtjSs9xNR4ZdotkYkqdptcQB8ZpKVrZ3OMYuN7DcL1dRPRxW56qQBAYaX0Hc0En5nRk2mOCFVA7SykRi/FIMc2JE5qoOqRK1UnRooshRVX17a3wNZZqp0qm8p1dG66XGVQl2RC4fWxXtRGf8GLVnlreTqrBtFrDRe3ot6rAYKhasDwOZuo0rKJUrAz46crG7u2pp8tGJH36n3F4rF738Jp8E0KJePS7QPKt6i1xlOz4OEjQp7k9wFYqWjwcDWu0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000209, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.23 17:03, Michael S. Tsirkin wrote: > On Thu, Jul 13, 2023 at 04:55:47PM +0200, David Hildenbrand wrote: >> Some cleanups+optimizations primarily around offline_and_remove_memory(). >> >> Patch #1 drops the "unsafe unplug" feature where we might get stuck in >> offline_and_remove_memory() forever. >> >> Patch #2 handles unexpected errors from offline_and_remove_memory() a bit >> nicer. >> >> Patch #3 handles the case where offline_and_remove_memory() failed and >> we want to retry later to remove a completely unplugged Linux memory >> block, to not have them waste memory forever. >> >> Patch #4 something I had lying around for longer, which reacts faster >> on config changes when unplugging memory. >> >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: Xuan Zhuo > > This looks like something that's reasonable to put in this linux, right? > These are fixes even though they are for theoretical issues. Yes, but these are not high-priority fixes+optimizations. So if you feel like we should be delaying them, fine with me. On the other hand, getting them in now also shouldn't really hurt. Especially patch #1 might be better of just going in soner than later. -- Cheers, David / dhildenb