Re: [PATCH v2 2/3] bdi: add error handle for bdi_debug_register

[Jens Axboe <axboe@kernel.dk>]

On 11/17/2017 08:06 AM, weiping zhang wrote:
> On Wed, Nov 01, 2017 at 02:47:22PM +0100, Jan Kara wrote:
>> On Tue 31-10-17 18:38:24, weiping zhang wrote:
>>> In order to make error handle more cleaner we call bdi_debug_register
>>> before set state to WB_registered, that we can avoid call bdi_unregister
>>> in release_bdi().
>>>
>>> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
>>
>> Looks good to me. You can add:
>>
>> Reviewed-by: Jan Kara <jack@suse.cz>
>>
>> 								Honza
>>
>>> ---
>>>  mm/backing-dev.c | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
>>> index b5f940ce0143..84b2dc76f140 100644
>>> --- a/mm/backing-dev.c
>>> +++ b/mm/backing-dev.c
>>> @@ -882,10 +882,13 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
>>>  	if (IS_ERR(dev))
>>>  		return PTR_ERR(dev);
>>>  
>>> +	if (bdi_debug_register(bdi, dev_name(dev))) {
>>> +		device_destroy(bdi_class, dev->devt);
>>> +		return -ENOMEM;
>>> +	}
>>>  	cgwb_bdi_register(bdi);
>>>  	bdi->dev = dev;
>>>  
>>> -	bdi_debug_register(bdi, dev_name(dev));
>>>  	set_bit(WB_registered, &bdi->wb.state);
>>>  
>>>  	spin_lock_bh(&bdi_lock);
>>> -- 
> 
> Hello Jens,
> 
> Could you please give some comments for this series cleanup.

It looks good to me - for some reason I seem to be missing patch
2/3 locally, but I have this followup. I'll get it applied for
4.15, thanks.

-- 
Jens Axboe

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>