From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A729E7718B for ; Fri, 20 Dec 2024 11:13:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0DC6B0083; Fri, 20 Dec 2024 06:13:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A0C96B0088; Fri, 20 Dec 2024 06:13:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768E46B0089; Fri, 20 Dec 2024 06:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 577286B0083 for ; Fri, 20 Dec 2024 06:13:30 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0BC541608EE for ; Fri, 20 Dec 2024 11:13:30 +0000 (UTC) X-FDA: 82915074144.20.D871477 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) by imf12.hostedemail.com (Postfix) with ESMTP id 1A22E40011 for ; Fri, 20 Dec 2024 11:13:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="s p7QKj8"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=5k7jANgN; dmarc=none; spf=pass (imf12.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.157 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734693191; a=rsa-sha256; cv=none; b=mjUBCTxUsKkn2UgqcJqWxduw5M6KAw/Ra+6f7ZAytqIfte/oRezi1//0Ttaigp4PiCoo1H TPw4lwEt4NeQo5edHVuaiGXkUtY7BD4K5k02ipaR+FH0yopsWat1THk9DSz01NtpeoeLqN 52PViNDuu+X1Qxvcq7qL/TwE1IybmbQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="s p7QKj8"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=5k7jANgN; dmarc=none; spf=pass (imf12.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.157 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734693191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fJKmBYZgFq2zq57c43y1QXL1v3pj/4Z2PAfnM7ewV7c=; b=TwQcdJiMLQ2kWOI0iyN+WYSRovgqp9fM58Qs2z/frBOCoLLyrCwUYrVIsPwkSEH33OHxge pX8N3QNcBrROdoIFByg1rrXOSy4hos2etVwdBP3UN0oZwInvyvt8H/EHNvDb7C7H/Ja8qP PV79XIGV3ISOy4ZT/P3YvWbVLj+nzBA= Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 61B1E114015F; Fri, 20 Dec 2024 06:13:27 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Fri, 20 Dec 2024 06:13:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1734693207; x= 1734779607; bh=fJKmBYZgFq2zq57c43y1QXL1v3pj/4Z2PAfnM7ewV7c=; b=s p7QKj8rs/FRJM8ZzNobx0SgEvPOzXaEpfh63ioALfx7kcBYAIxMcEfkNrnHG/8m1 Bn69PtG+6kYWcnO4E6IEHs6S2JiER3Aq4eHrgRPQzP0xxKKRlWuTYIzBNB8RnAg/ T9BAzqiAYa5LLsYvropCWSm5Q8INDvZhrIDdtfo/GQmLWAaFbRSqcOiL5AV6DfJN 7rxueLP2ktFzh6qOE1/M3utCFmiKdMYk6gosN7KVWdZ90YoeOuPRTSYb3IYr+XJv DeXFYO5QQZ/vxaj51B+G+Hq6EcCsfaPeLk/wykBfGtE1eiT65zHNQfycyA/g84MD +MZRJkFUR3h2Ry+6ZRJwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1734693207; x=1734779607; bh=fJKmBYZgFq2zq57c43y1QXL1v3pj/4Z2PAf nM7ewV7c=; b=5k7jANgNb+WxPNTUm2JOfJMkebYICsaPYDO76bt7q7MbvCHvZLc 9eqJp/8U9DZxClXSB8Hn4iGVVp4DCq42St1E/syX0f6AK12nhsMC+oxSSFsJtMKf ZocJ5xNPtZCRU0phAKrOvpoI2kVvSabhaX1wHsuULX+ULSrcxCy3HMEji9pHlJFD Ymzs3KgZFMOz5lGrUVF/e81lTUY2pW4ho1uFwQ50HMnVjr565bb2dYbu43GnsaDv 1ACkksCEmP0xsUoDJsxRNs9jEgM5Yc86B6KcO59fc6ZjLL2cNCmSnIzFQ6LIQp8D /PA+40/9zcC+vP1z/08VLzyhdaVx5WXATgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtvddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghpth htoheprgigsghovgeskhgvrhhnvghlrdgukhdprhgtphhtthhopehlihhnuhigqdhmmhes khhvrggtkhdrohhrghdprhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrh drkhgvrhhnvghlrdhorhhgpdhrtghpthhtohephhgrnhhnvghssegtmhhpgigthhhgrdho rhhgpdhrtghpthhtoheptghlmhesmhgvthgrrdgtohhmpdhrtghpthhtoheplhhinhhugi dqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepfihilhhl hiesihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopegsfhhoshhtvghrsehrvgguhh grthdrtghomh X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Dec 2024 06:13:24 -0500 (EST) Date: Fri, 20 Dec 2024 13:13:20 +0200 From: "Kirill A. Shutemov" To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com Subject: Re: [PATCH 06/11] mm/truncate: add folio_unmap_invalidate() helper Message-ID: References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-7-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241213155557.105419-7-axboe@kernel.dk> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1A22E40011 X-Stat-Signature: fm8hg7c3upxqbs79dcbd7uw1himjww4m X-HE-Tag: 1734693192-259235 X-HE-Meta: U2FsdGVkX18LDNOgqgw7z/Dpl1oc0lzp3zOKkUnBWhmGYDxTLKcT07LZT8ajYhJwjkMHDBNnC0mDGU0S6B6A0n7VXGNi+0bsNa2NV1jwsaCjU88h6FN9WMCPtJCUjt2k4NkiDKtPSngJd88QGwyz0FXXILhy3D9m05aflfkgeHs9ayQXD03MSsIbIiOUU0hg8UD/bX81ge72GoqKpZyNYW23KJRO4XeadIJU6FbM4RRIQMCMdIdU9LYQTsgTVnmlHcZwCUMVazlQVmztrdJhqLCxu050RTEKKZuV0slFhx+fvuCSK9w+5PHJLhPF6ivD3ne9XaR7HnxVB+VLmP6pTlJmqSQwRsOAuUop5tCXOaAfS3lDS981sKns9LnBmdjB278cte6KeIn+ax9n54m3xdGP+6sFDb2haKGyOV7uasdpJK6N+bHanL76KsfJUMLFQ5GtXJB714OhKT/uc7tUJXhhv3T1mJVJUnNGKTamvnpUsdlnL8Jt8xuIEcjTiioX3vSUxcRwSJtumOuLsPjbVhu6+DZla2r5Oo62uumeg/M3nNzB87piPJdHQeq6iGIjp4brytftqAPCLsqB9JDcE5BNd50oxjIrbt1r8e+IOuoAMb/d7GoJrqciGtb4Wp0c8LJVRw9Y1LWY511eKgb+TP2RHUzCYcAtj4Xml0fPN02zmUZjKSJ/Z+EzlTmx+evj3Xko7eCNNHulaovKlC/6yc+jBEnpOO6/Zzcb6CZ2rNtH/Bq0zE5YvNkrU0oPnsnNasTuou2NvALsM1Ttu670+8/UBeUdnYmp3YJKYw+7fROgM3m6MTuN1sFGgjJ/qRv5U9813yJHZaPlLiPdhOgNHPFo+7xgfspDHPG6gMiFmPlDjO1+kvQs3A6owoDdzypwVVd63UhrAgqVLtt9rXKjgIySruyw2qfnql7whNdBZsY50kFlQ8HFkwdLVFrH7tfstJba9Kn8HavaQCKDzlk ZY284rxK LVOxgPmq5m7O8vFn+YOaPr9us/YfpfZlXmOb2v2WTHts6g4nl4rFf0GDveBrUESYMv4rcdzyecASI7L3H76CsZM7Cs+RPpSbPQD8tT6l0nkTOc7BjX2LVTbvou/zYBsX5OltEq4HKiC+oFFZReTDW0ZqAXm5WXlrtQ9IZceezX+ZGP2CuK7dKjv03yLsn6b0LRNYwP10iCMo6tw8xyOFvK1M540bBp1ImoS2NSCo7S5LCIaFrQGhZl2CU6+7W9bjC9/dySPX6dEJ72UJpu+CytwDUeVH8RtHJuyIqykUMbyofh7clqSHfM7NJoOIcL5HCn/XacDOZ0VJI+tz9+Z+zLDFyxC8NSEm5D2maJquIDOzRMt7WhXUDDlBXxRoC8XEbuXPatU2zmZLEyBX2qtkNa5ValWz8JYlGJDR7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 08:55:20AM -0700, Jens Axboe wrote: > @@ -629,18 +641,8 @@ int invalidate_inode_pages2_range(struct address_space *mapping, > folio_unlock(folio); > continue; > } > - VM_BUG_ON_FOLIO(!folio_contains(folio, indices[i]), folio); > folio_wait_writeback(folio); Any particular reason you drop this VM_BUG_ON_FOLIO()? > - > - if (folio_mapped(folio)) > - unmap_mapping_folio(folio); > - BUG_ON(folio_mapped(folio)); > - > - ret2 = folio_launder(mapping, folio); > - if (ret2 == 0) { > - if (!invalidate_complete_folio2(mapping, folio)) > - ret2 = -EBUSY; > - } > + ret2 = folio_unmap_invalidate(mapping, folio, GFP_KERNEL); > if (ret2 < 0) > ret = ret2; > folio_unlock(folio); -- Kiryl Shutsemau / Kirill A. Shutemov