From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375B4ECE582 for ; Tue, 10 Sep 2024 07:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEE448D0021; Tue, 10 Sep 2024 03:08:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9E3A8D0002; Tue, 10 Sep 2024 03:08:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9661D8D0021; Tue, 10 Sep 2024 03:08:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 76A858D0002 for ; Tue, 10 Sep 2024 03:08:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E727E40965 for ; Tue, 10 Sep 2024 07:08:30 +0000 (UTC) X-FDA: 82547950380.19.0DAC0BE Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 07FEB40006 for ; Tue, 10 Sep 2024 07:08:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vVSTO2TF; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725952007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vplBtqjlTg4eBgWma6lIzm6/3ie/7e5vk9lsOVwoc9o=; b=v0nvXfOz/+6CTgcNpxlgR8hF4l6UGmk4nIAoI+p0OX1uXoe84olvmeU28XLNGHjxb3jE9c KDvvs978/mcYW2VxEZyNKudoUpB7wx7z4/Btl03VQImInKJG9n5cCIwMhx+Ya1WcDR9H0a WuFS75UQpq1fnSH64zSO7D70xO3QVVQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725952007; a=rsa-sha256; cv=none; b=XpW2D7RUdxsUQclVF47tyA4hDrjSDxQcPTqFJFoz4b5LmWyqiea1vsrXoD3FLz6vVSpEGP jjGz8tB+l83A5+UBoggFlTyPdzICWmYoNO42kXYwMsSx9SWtgo8Q13wSwV6UqXQgPGISYt kDOGUytHz9e4Fy3cJEL6zGFKtUVDL5o= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vVSTO2TF; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 10 Sep 2024 00:08:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725952106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vplBtqjlTg4eBgWma6lIzm6/3ie/7e5vk9lsOVwoc9o=; b=vVSTO2TFJfh1EBJG/XSokcOFNomrhN3BkYDziVC4NY2avzIdL6S/ILOCI72lp+3AsqkUmD IJkeVKGcSo68y2a+HxMZyf5W+b18idowDgAk3gy7qu1MQ1hnmkRuvVOi+EMIedD5CNhRAh 7Rv1kTIzsdPeW7p7GQLEJ5U36BCkjeM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jingxiang Zeng Cc: linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memcontrol: add per-memcg pgpgin/pswpin counter Message-ID: References: <20240830082244.156923-1-jingxiangzeng.cas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830082244.156923-1-jingxiangzeng.cas@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 07FEB40006 X-Stat-Signature: 7c1rzou633xmtedcca3e8q6uyxnh5u6z X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725952108-182346 X-HE-Meta: U2FsdGVkX18th/XsFmHM9BIFN6gIamb2u0LTP5vk7vYwDU26RJ+LvPTg6ZImpGudocSVUFjmH5eRYDFXIM85apRvwXlDLtPri/ppXnNROO2XERt/W5E/hfd2OXVGwudOfnKFQS/X0ZPG04cQqgbJyo+XeA/U9j/NA6U84qPTY52DpHjDoSdhwJN2w/FiD+o6p0RHP2CuEml1p6QwEtJEg/smtQ9VBoL+l9VixbDBfKLQf+kyKmgy8YP6gyY0XRsFnX3mtdnwB0oXDlmXX8A3coca0WqkwrSR9ievGT3HIqP5+uYdSoVr3QsF01ePJCaYVnuz98AHYgYXG5/IYK7Uu0huhuC6LrxNK2Z+WMv+l3QK2YA69cgvbiWAE+T4zZJJ929WglxMwbEpcSUmA+i8cKapTnN4Rr3MQhkEBpPZSaKtYs7wQtOlFfS2qA0P0cbQf4oGBp8NJ/aGkP28Dl8g3HenT3hw/SUtsnLCMucu6Pfj1U/TOMvRbH+2MA1UYxBAxkBP5WXi21JoWMa7kaIdLxoYAXp6v1oN0yxAvJjionJEDaLO/AN4V37p4jv+sjR1S59hr+cSOxwTxVw+GHzUxWXKjCvFbFlXDe5tJFoYRgXMjYDap4hYC1i8voCWbQYM6/xryojze/yDg0RK3d+0Hc6HA9g5hTmYo+YQMVIRY0qcmItapQ86lernQMJvgcpIWP3sDqenxza693IUmTDB3W+Jdm9dI+MGdIC7/LU/5mNESOPq83DoiwHMYyhGFIO0kpA6/D91Hj1sJK2jnXTNzBGw0vjBt3if0W84oJERYoJIB2hdBFFWVSS+osY9n5OflkvKk+C2B5D1wYksDWKfrXJskmJS6WH1Ay9gbUozP41ujKgkXf9MMowZy2m6SwD9oAg1l8+tr7w3Ge1G0lO32sxD0FhbQK/fxj0xlqNkjFQe7tQdCfEdRPPFN7SPsKb1Rh7CNLiZyMRcBluQWkC 8x5iiIcy alLH4ohUmNOnybrGq/FE9nKqtB/nsWcgBM39nyrwraT+igviewTgyWo2vauYuJWT2JqRCOExQMvRGH/oK/pNIYJ3G3QgVwbS2P4P9NnIK/NIvInRD5mBcp+wPyNlyPCXpxXvbQHH8KuuqyDZ3dKJoxLsaGfo69++v7fXEWXD1GBpUHzg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 04:22:44PM GMT, Jingxiang Zeng wrote: > From: Jingxiang Zeng > > In proactive memory reclamation scenarios, it is necessary to > estimate the pswpin and pswpout metrics of the cgroup to > determine whether to continue reclaiming anonymous pages in > the current batch. This patch will collect these metrics and > expose them. Please explain a bit more on how these metrics will be used to make a decision to continue to do proactive reclaim or not. > > Signed-off-by: Jingxiang Zeng > --- > mm/memcontrol-v1.c | 2 ++ > mm/memcontrol.c | 2 ++ > mm/page_io.c | 4 ++++ > 3 files changed, 8 insertions(+) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index b37c0d870816..44803cbea38a 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -2729,6 +2729,8 @@ static const char *const memcg1_stat_names[] = { > static const unsigned int memcg1_events[] = { > PGPGIN, > PGPGOUT, > + PSWPIN, > + PSWPOUT, > PGFAULT, > PGMAJFAULT, > }; As Yosry said, no need to add these in v1. thanks, Shakeel