From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9CDC5AD49 for ; Fri, 6 Jun 2025 10:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0323B6B0089; Fri, 6 Jun 2025 06:28:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 007D66B008A; Fri, 6 Jun 2025 06:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E39146B008C; Fri, 6 Jun 2025 06:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C01306B0089 for ; Fri, 6 Jun 2025 06:28:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6F04414135A for ; Fri, 6 Jun 2025 10:28:35 +0000 (UTC) X-FDA: 83524601790.25.3E32DC1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 1128C1C000D for ; Fri, 6 Jun 2025 10:28:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749205713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKVfXE5LvAUMRplqpv2/XdSj/f7PTYuXtEH5Yx/Ix2o=; b=OUomca1bhcpy05CiPTy8iT65fMxmKAHXUA8raF6b4K0Ayc/h/+JSYYTlYZt7eeHjNkCaov l7ubydiC53FFR0X86zGcPqte1R6zB1/Sy35tGbapFh2i0F8tijNnBkbpXe1rNelzWLqL+q O1tlUjZTMLtVHWBS22im421w3I8Ra1k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749205713; a=rsa-sha256; cv=none; b=hG+XOaifUvh5JKm1o1vZMVdmmTVT0/gYKAH5shv0/3rX/xtY5grP2yia9n3GCgN+XF/e7S xm5N1sIpo0mdyDuTM9YA/OutKUmf2VIago+nsDtrvmgyJYOu5IK40ShFLQtoXxeJjBFv7V Ony8bg8E+Mh8wIML3CGIYqrpXZx9spk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-xDeUzmNoNyGuU--jnGFnjQ-1; Fri, 06 Jun 2025 06:28:31 -0400 X-MC-Unique: xDeUzmNoNyGuU--jnGFnjQ-1 X-Mimecast-MFC-AGG-ID: xDeUzmNoNyGuU--jnGFnjQ_1749205710 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a52cb5684dso854637f8f.3 for ; Fri, 06 Jun 2025 03:28:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749205710; x=1749810510; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wKVfXE5LvAUMRplqpv2/XdSj/f7PTYuXtEH5Yx/Ix2o=; b=csH9sMbWbzExn3W4CJwJvoemUftNpk7nu8Pt1GIelGZbV1ZEn2u34bOTsYsaasPGCz lA35bWZBtzUCeofQy4nICQxchzlklcGZk0at8l2n3HXOnsbCUHluufA/YPuQuI5VBX31 XN1YnAx7s+xdP1zNnSJOwU4Do9CYykaAABy8Ypb2TR2DcSp10UHkk9aVO43Y8r3aWU1d xmNsZOYVNMXKieGxLa9ZTWqbvzy35lV8qDUU2rqSAQndFTkdw9uclsFeDzF+jizqzTqE bg+oTn1WPjBKC2Mf2Z7yzm61zAS5/nExBNQ/TGwdRz5mGFyPJhSCXIBiUL6hHga8JyxR Bdyw== X-Forwarded-Encrypted: i=1; AJvYcCXpwfv7LYPBq4jrIBb+2kPxGP7eHw5jD59ZkavjAmml3bz/H1Mw4G6hK0o8MWZVPxUCmQdbyTsKgA==@kvack.org X-Gm-Message-State: AOJu0Yx//gWD2Ba7tFw53ESCg9GHwp8mHNFmk3AHKT2bqLpIQq4MqlZt ggh8XM0c8HwWTdHjzuGiDalXDjadcEDrZkL4+vQB/o2M9UJkEv+GLaOWNwkYYp70su95KWYaQDf omG0rj0no/Vh80FuWskUhvOCjht/sWzqfTpOc0j/tbADeIqRCb/4Q X-Gm-Gg: ASbGncvB3x4AysKSuAh/UKFzUs5tbrDvZA3Cy/CF8FQHb1/4bjQIS/brGrL4GtLj7Q3 /+9s5h/lYYLUbarYEwaNZRt7ZI55HUklM6Z40/4r5y1TcZoOY8r+cBs3KgSlB/3/flnwuf8dSyJ 9tPyt+N3TSLbmm1Mbs00/yVUaMkpOmoBtcbFor0QdFMu6JuRpELYhXiTX8dfsEhTkOWfSuncbgi QdLONqownGi9/ofaBf0muf1K56pBjWcZdcPrX4GuUZzKxT9lmqU7nml/rctS/ONe74zjaYDj1UK eQEx4bGhJ95H71bAIKWeVUud43wKvkfsZMor98V86AqX0BM//jCjiBJAND/UAnCwD2rmTkMEG4H iXALEXF89Tpj1Rg3g014NVhIje2r7mDk= X-Received: by 2002:a05:6000:2f88:b0:3a4:dd63:4adf with SMTP id ffacd0b85a97d-3a5319a2f10mr2497844f8f.34.1749205710154; Fri, 06 Jun 2025 03:28:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKWiQBw/SFRtOD2IfGZYydjryehOqCEDvXvqvtVCdB4/fm2qrI6chgbNP+mu48KPOr7/8IHQ== X-Received: by 2002:a05:6000:2f88:b0:3a4:dd63:4adf with SMTP id ffacd0b85a97d-3a5319a2f10mr2497824f8f.34.1749205709720; Fri, 06 Jun 2025 03:28:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532435f94sm1459782f8f.60.2025.06.06.03.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 03:28:29 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 12:28:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs To: Lorenzo Stoakes , Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , John Hubbard , Peter Xu References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _DwJ7xzg0rb8Rm_wp-aQIE6Kd56st4fv9fZiR-CkBhk_1749205710 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1128C1C000D X-Rspamd-Server: rspam09 X-Stat-Signature: aeqjq9tsa6y39i9xfprra317r6z1wmwo X-HE-Tag: 1749205712-18995 X-HE-Meta: U2FsdGVkX19s+Iqi2ge+xkoe0DGDRL6Yv0rMunF8TKMgD38lquwPAyEuAsiDgXil1LKontXGx+H7RV30+voK2BnaeV4l0X9DvQWEiExr9GafJsBONXgcML04SFeMZw4WeP43NNu9MI7eJ2pxlQSAi9E09ELVDfZtaSalOdBg5WhAdg9WUte3MbibhhtnKlYFR9bq2BVoaYaTI5HlMiBIigkYHN5Fi7e3MXVImffRvgs5PrdIOFfqcPThP1mB2QBNFyGiNuVlIWidSWjmCoD7ak6oY8aPWh1SfGYi5tte612dWpAkv9QgZTvnEimtjtHfSjXGqbwKrLycCuBvvYcWEn+LiLjXf+qx5CjoTKZF0fQGwePT2oaW7iNnM+0pESku0G1JdpzAQ0VSFr9bDJ9z0X2pLaHQSTuXLZTVtgFlPGMkJzQPVmToe+qQhj5Q/azBejGQ20xrOfQw9Oewu1QBsqLaCiKvZXPQbHw3ZkqfK336GWaTHf6cd1kgHd85t9dWp0I8RzHM6fwhr/7caIxO4fZns7PKvs4rNMqaKJCe7XWf19Lx7iMkYKHDb++6fLxd86lxsAAdTc8qvmnarzb39dIzAmhv7Pq5HmTwuj3TVMsEsurcjSAGT3wqSwyfNAOYLhJ61v5jcGA7ZQ5APX7VsftWmnV9b5gWbfTp2iMzfLJpvVOzau8RCZc7MD7oPgbwu+zrlZU7ZpI22SFq2SGaVIYUKp15yNaNTzRPGiYyOk4zN/zGJ4E1H6A88Hl9vhN1LLO9mFWUT1iYaKc6uVwRNcbKBD/LE3DUOqoa81NoKxo9UjQ6xAbUAbskfUN5vYGKAZS/4g6yevGZPNCQecquieLhhyNHyKHUFL68U1RW9vfAkMtIVoKwCNx/+WWV8ClCBRddQbmIoCbDye8LBtm0OS8PNUnuQtbi2O2/6DTRnHAnJLo4ViX59ANNVWzoZkXXojSNtUnKoSPaktlHsqV ykmCwDrx YHYHushhcJtNlItk78t9CKOIlHHka7WBFMoS1BB9eLwEJx330cTGM6p8aV7b38p4DdPPNo8kBFTrbPu19GdxJBl61xBx8Yk2dTdniV/15FM9EHU/CdJDwpnu8ZPed+EnYutFVspl1z/RQcpazLTxcqjnehrL/hCBEdOnkuwv6KQq0heURCgH9NqG0WBmqBO7QYmGu4TuQJroch+vvqEwM0NEA/H+eFIBWxe7qDdjTKTNiXESbmDjPMpTAPmJ7eKlC5YGAm99Mxhu9PcHxGDMK9aKs7PPLXMZzETLBErhuimX8NbUU+du4ZT+BkN2WdBoSlAlB1np/wja2PpVAnhZILjImIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 12:19, Lorenzo Stoakes wrote: > On Fri, Jun 06, 2025 at 12:13:27PM +0200, Michal Hocko wrote: >> On Fri 06-06-25 11:01:18, David Hildenbrand wrote: >>> On 06.06.25 10:31, Michal Hocko wrote: >> [...] >>>> Turning them into VM_WARN_ON >>>> should be reasonably safe as they are not enabled in production >>>> environment anyway so we cannot really rely on those. Having them in >>>> WARN form would be still useful for debugging and those that really need >>>> a crash dump while debugging can achieve the same result. >>> >>> One question is if we should be VM_WARN_ON vs. VM_WARN_ON_ONCE ... >> >> *WARN_ONCE ha a very limited use from code paths which are generally >> shared by many callers. You just see one and then nothing. Some time ago >> we have discussed an option to have _ONCE per call trace but I haven't >> see any follow up. >> >> Anyway starting without _ONCE seems like safer option because we are not >> losing potentially useful debugging information. Afterall this is >> debugging only thing. But no strong position on my side. >> >>> VM_BUG_ON is essentially a "once" thing so far, but then, we don't continue >>> ... so probably most should be _ONCE. >>> >>>> >>>> So while I agree that many of them could be dropped or made more clear >>>> those could be dealt with after a mass move. An advantage of this would >>>> be that we can drop VM_BUG_ON* and stop new instances from being added. >>> >>> As a first step we could probably just #define them to go to the >>> VM_WARN_ON_* variants and see what happens. >> >> You meand VM_BUG_ON expand to VM_WARN_ON by default? > > Sorry to interject in the conversation, but to boldly throw my two English pence > into the mix: > > As the "king of churn" (TM) you'll not be surprised to hear that I'm in favour > of us just doing a big patch and convert all VM_BUG_ON() -> VM_WARN_ON_ONCE() > and remove VM_BUG_ON*(). > > Pull the band-aid off... I think better than a #define if this indeed what you > meant David. > > But of course, you'd expect me to have this opinion ;) See my reply to Michal regarding keeping VM_BUG_ON() until we actually decided what the right cleanup is. I don't have a very strong opinion on any of this ... as long as VM_BUG_ON() goes away one way or the other. -- Cheers, David / dhildenb