From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4727C282C5 for ; Fri, 28 Feb 2025 02:44:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5413E6B0082; Thu, 27 Feb 2025 21:44:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0B4280001; Thu, 27 Feb 2025 21:44:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3917C6B0088; Thu, 27 Feb 2025 21:44:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B8526B0082 for ; Thu, 27 Feb 2025 21:44:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5CC8142160 for ; Fri, 28 Feb 2025 02:44:37 +0000 (UTC) X-FDA: 83167810194.23.71E00D2 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 18005140005 for ; Fri, 28 Feb 2025 02:44:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=fdHjksRG; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740710675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KrHEppDznEYNt+aFJHMFnsD9ySUlfKEU8kXo3t7+HP0=; b=lkchiM+Vwiw60XsEmLDsJy0qN07nljAc9gixKL/qSXCq0PRyovxkk+OxX4RqYOWAOjLwjb ERaz/ftam42g+3muf2lcFZPW/DkKzw1zp5cihjoHqRJibEgSg/WVyFTI4ERZIcPKfPKSUz ajrLqwaiyg6PYwFmXj9aJ60wW+UkPF4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=fdHjksRG; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740710675; a=rsa-sha256; cv=none; b=4ME6fpRR1C9im+Ka+rIOjCL2sl7+c0uaQpg1owC7lC+Gr0roM3ZqNcDTExA8RnGEYeLzw2 BlGoCX9TaqX+VQ+07aTuZN5oBoI7+0UJJpqbkT7DEw11ER0diQhl/hpLsefyKqJ15z26z0 14EhQeVLteHKic/a+9Sct06Ae4SKX+o= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-22334203781so40777665ad.0 for ; Thu, 27 Feb 2025 18:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740710673; x=1741315473; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KrHEppDznEYNt+aFJHMFnsD9ySUlfKEU8kXo3t7+HP0=; b=fdHjksRGmwmiCHRi1NVOoKhhMPgDT4QHEHGzD/UHc7Hys2SByU5Rjxdc2DbDtGyrQd 0+ct9uN6WrHlkX91wqxdilrLKh3bBU3IhE4jBL42QekqAI270EJKNUXoezGvfcYdtorG tdo/QNFZsk4jQZQobnxvtK9Qc/EoAXEjCCHzAe/J3GE/aM9ngKRUwvz/zcwycV9TU2Ld zs7VOAdWzmU35tMzbjL1vjPfrrHjTbxyBSSYP8MZ+U0aAtet4NSSA6tD2t4XRpdGmHXR WhXeZhLMCtRqDuDeQUNZr+QJ0qPBr9pQjBx9RENHXtsGI88UlTUoO0QZFvAnXc9WWvgn 66AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710673; x=1741315473; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KrHEppDznEYNt+aFJHMFnsD9ySUlfKEU8kXo3t7+HP0=; b=J8yAjsmXCKU+I+w/fDFnS1CCaRTwqSlxg4wgKLqvLcWik7K8K3hW4MS9KGoC/vGIys ww+NKnq2Zz9+tLBVfzqRqYnrjY59jOudc4UWPt8rLF4QZ88oXGQFlNecYnq6JzTzm+ZG jksfCI90w0+ifWq/8wsoTKdVVAc3pscfa5WP8sHFa6muXPemSh8TiCEcD1Rvfv3byyga EjFUXGdXIxvJvAskQZvo4alQtjcf70g+SkksA2BmNxpDgJHf2UmPsiTm9n6fhyS6Oei7 +YYeA5MxY6o5HTmslmBcIDc7F+tA2x/l0+aO00BE1UpFUyCn+3etn8fGz5nGmzuFBL+O jx+A== X-Forwarded-Encrypted: i=1; AJvYcCUegw/352nhR3pJ0aTWs7baOd2+dQePpOIZtDM4H7rjwSM314jzMOj5AZ+evSU2MGXv12IAP9fTDg==@kvack.org X-Gm-Message-State: AOJu0YyPvlJqZAOETYnCReVD/cqM7945pOgSDbDc8GOOJQq5VYd4FEwJ MsPky/S89C+CQW1vr77omdCNOPXw7YLLPD/fIoUd6vi7obbMi7cbTLsR/de2+/I= X-Gm-Gg: ASbGncuRne8legBGVhE04IgoIFWbVqcVRWY82O9uZIPCdIH1J5Ca44cbOWshV55V1/M sguAG3pgVcHpUboG48+wvgdiCqnEYwebBWR5L4hNwsCWfmECNRvquT14SGv5FfMiA5Pie1i2X0m kmc/PYpJEZQIb1yEVB+OLkM8KiAaJ26VGy8Oo8DGMw6ISipZ0Y0JQO/LP6c8iPtMvgut2NiO8Ck CloJs7NzBldEKqLdHtJq1+q1JanS8cZy0LcdvPgkQ4J+fVFK9HGDcbAcfUNkWArxVuUKcpsFflP WjMed90fwlhVIiKhwAFO1zqadd08P4Wr93ZM2/Z8nVvvcexODQ== X-Google-Smtp-Source: AGHT+IF4hsdZRiz/aSbemK655CZrsY9ZUuvu4Xu2ENST8y9hxHTSO7PJo35OmCgDgimYWycuvOakGg== X-Received: by 2002:a05:6a20:1591:b0:1ee:d19c:45f9 with SMTP id adf61e73a8af0-1f2f3e11f86mr2902815637.19.1740710672736; Thu, 27 Feb 2025 18:44:32 -0800 (PST) Received: from [10.68.122.90] ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7349fe514besm2559832b3a.71.2025.02.27.18.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2025 18:44:32 -0800 (PST) Message-ID: Date: Fri, 28 Feb 2025 10:44:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() To: Geert Uytterhoeven Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: yp6mfqh1hr7wk93p6ngsu7qn3r69yuhk X-Rspamd-Queue-Id: 18005140005 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740710673-877324 X-HE-Meta: U2FsdGVkX1+rY71ljbgmFps9QmLj0UBB2vCoVV9RVAF8tHJliiVABvt/UGtqmphKPD6EITnjDCtmajAzEdmFlCsGBKcyiS91DPabn8lEIcEDtlFsQwuHXVu1EARvRTMKyYxIkmvanmjicZKnrYsUNPntpjmg4m0wwzK5RmrvF+va+sWUTSQvirjBOLLkO9omwKB3fqpENmDnhqqaRV5QY5GGEAbUp/iDs8NXq9V5cV1MOqhgew0h8nlg/Mr78fdiOUX7tC1C5V8YtgSzAnWnfmsGZeCJB2MPhmYgwu+1MvFj+PjkKagIIRZOZp0vFez+cSxbENjmJB0GUJvzqJDpXdmOXbcdPpcVxxw3YLZc7GcvbrH/1fJ9s0c/EZkf8sM6zrSuLCvT8gzBm5bzN/bgYkakFQO7YjnXiIdKsKQgMeolTUn1iYAvZekHxd433h3OlIU9boSDsrXnY9xGEiKw3YN2FjjR6lVstb2OeF3lUKiblUk31LlHORIKNpws479o7f0TzxJKIr230rdbxFMCZxOaZG157iSZLSG+JXAbls3yqUcTkMpR7raiXtb5BUOf+G6Y6pnXk+8Iw/3Ic0ytZp5S12aaGpuL9KQed0Wg+JIM3tUeWnOEbX+IVFBQ+sM0eZkpa8WAnME8lBTc+OTAbtGwgvQ8GqboyifeUBC11SWcOdU3Mnr0AIAuGKflcVqFflgJe+n84zoebXjlaUHYWx5iOCj3ZgTY/7N8t6mPvG8oqqdm0JvI/SQJnqJvlVX2+3jNTUVV2Ba0Q1a1FPBlsfNmlOKSK23V0mulUj0tJsEkSFoDX0ecTs24AGAUjbu0Pa69Ub1fyt/1qxsGf1L1oxqktEExK2SnpPGCUMuMKf35RXXvO81iZz2gUzKfrAGHHKkmMGKxxz9UEs3wH3z/81fkC/AJnPIyifmvsyzT0MuzmD5lskD3SLV9ZPOFTAE9jb1bNve4c59JoKVbFPk VvwPb9Hj 8Jz41uJp/i9FgbUV/0gWEGjgJlLKDkKTH/3XsxitW5NOdm585rQngOPJqJp6nAQXTZ6w8KysSYDk7U/jawmKebRlZ8RU9Y7bDiMC16QsaoijnFDf9BSG+jlAkT3cb+uEW4BJlhA9Dpwf3tgt97F2xFExcpYAxag7hp/001Q+fOi6ZUEI9QJNbWnnh6Fi5nVOGlQcNFuoh60wsYZQlhITgd2m/tzIUtiTQmlPQSWTtldtEMX+rhL7Nh4tBXQBBfzH2uhydvNkjBzL+XbxAqhhYrda4+8ja7MU19NEw6GiBtZlxa1pVb1OIWbdw7tG+JMVmoNbvNWZzUTdjCeFzl7rRyoIWQJiRaYWnQKKODdeKoIcUjNogyOvYL3yCKe9WVXkCYXzYK/z/F7sgAaTYkHAiE0LcDvh6amosZ63euuRsjG7CC7AZG04efonqRbnWrcyId7rU8u0CEijc9NxtCV8GToqk2D7e7kauDd7X8qLWztL+2mzkqDL2iV0DM+kyH0IO5hwT1H1AZLgYknXYIatk8mYQ0WXdD4zONe6/B94YpeHyCVS2nt0sjckOE2xyIfGw86uw3Ye5O43Z3eqMDWT2yc2JZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/27/25 9:21 PM, Geert Uytterhoeven wrote: > Hi Qi, > > On Tue, 25 Feb 2025 at 04:46, Qi Zheng wrote: >> Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, >> nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, >> and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of >> tlb_remove_page()). This is the same as the implementation of >> tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so >> convert these architectures to use tlb_remove_ptdesc(). >> >> The ultimate goal is to make the architecture only use tlb_remove_ptdesc() >> or tlb_remove_table() for page table pages. >> >> Signed-off-by: Qi Zheng >> Suggested-by: Peter Zijlstra (Intel) > > Thanks for your patch! > >> arch/m68k/include/asm/sun3_pgalloc.h | 3 +-- > > Acked-by: Geert Uytterhoeven # m68k Thanks for your review. > >> --- a/arch/m68k/include/asm/sun3_pgalloc.h >> +++ b/arch/m68k/include/asm/sun3_pgalloc.h >> @@ -19,8 +19,7 @@ extern const char bad_pmd_string[]; >> >> #define __pte_free_tlb(tlb, pte, addr) \ >> do { \ >> - pagetable_dtor(page_ptdesc(pte)); \ >> - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ >> + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ >> } while (0) >> > > With only a single statement remaining, you can remove the do { ... } > while construct, too. Ah, right. Will do in the next version. Thanks! > > Gr{oetje,eeting}s, > > Geert >