From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC964C25B7C for ; Fri, 31 May 2024 11:13:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EE906B0095; Fri, 31 May 2024 07:13:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 650A06B009A; Fri, 31 May 2024 07:13:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53E826B009B; Fri, 31 May 2024 07:13:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 36D1E6B0095 for ; Fri, 31 May 2024 07:13:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C0265161607 for ; Fri, 31 May 2024 11:13:09 +0000 (UTC) X-FDA: 82178429298.07.DA54393 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id E103680009 for ; Fri, 31 May 2024 11:13:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717153988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=niYS4rPJFRqqTwC0nadX0lfDrOuT6mSvakXhIiWxgpM=; b=ZNeETZvfU2Km1tXTxpgQTx+YhsI/hMJLOxSgW1eHfy5IU/1XSOmpew9EEtMIRMzQkcqcmV eYYwFNPHnZCh4FXk+c6edgEfuk3hg021pihNrHZl5Xeth4WxWQu4xMukt4P5w3qm602DJ5 lbpb8L9L7Sw3HjMAKJ1CIjBgusKZyxg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717153988; a=rsa-sha256; cv=none; b=fmqNUK0pVe6giSXqJyllSV3NzFNOr9RxzmpyGs+iigqI+JkDnqzYEnfiDj9ffYaCB1uQ+P zoeI4BQMm+w0wDNaku1BrFbHbI3whAt0M4lLUILta1Gz2+keOc6AT6f4DVw8qp25ibrh87 0esK5kscUhyh9+v3yLIzBAZFpovppkE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2451A1424; Fri, 31 May 2024 04:13:31 -0700 (PDT) Received: from [10.162.41.15] (e116581.arm.com [10.162.41.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D5513F792; Fri, 31 May 2024 04:13:05 -0700 (PDT) Message-ID: Date: Fri, 31 May 2024 16:42:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: zhouchengming@bytedance.com From: Dev Jain Subject: [QUESTION] mm: Redundant const parameter? Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ocqi3en8zxr3hw41xy317x66dcispmfg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E103680009 X-HE-Tag: 1717153987-351571 X-HE-Meta: U2FsdGVkX18WTM1I0molmEpyxbrKPye/zvJA0zkU8V/XQkLjUkEu6AAKGV73ILaqhL7Uw29J4OdwuFdSdOOpFfV0Wwayy53htq9/50yYwVvPU4JDGm/vRI7YhltZETG/f+tIwUnzXzH1vN4aSsPWb+MR6rfaRXgaNneWOL5+EPOvBiSF4thXFIkuMiZ2w5tEqRstct/IdFLNoOlewQswR2cGMgytBZLlUDFN3ubkapN0Z3C2fwYOiA5aijLtm1YKFnvybcQ13eLcesVwDd1LwyRhYSMVb+sKiti4HYHALkyVIBUf0AQiD1pbpub3S/d5XZu/Of3qcLaOUcMJmw/l2y3oslksVd+v9j8NmX/bco61gf7X7hOSufAO1aytcK9Mj+hzbK6+E6S3KZQ8hrTsSsIo0yTGyvWjM8Q007A1+LkyA58ShMDYDkD2/qJ4PoaMyVK7qmA4Crh54md8IrOGznFhSZpE6ra78yQOPDwahjwtwmuZb2sHxnMrsqdbYHHsylrAeuGF5hi8cIAu3ninTOKMoZLH9Co8pukAwDymH1Q+WSkGEpt8ujW4/Cpk+Y4urjN59wJYnjrr4WXvKQBgunVTN966WVmUt1HTeE+tBhEVfzl8jVsj7ZzySUX5sV8g/2wfWxt2g4vjdLGjal/Kx2c1vgsXCg4dFlVCI6JuxBidaKHIQ2BqFXRzQY6HhNRmMeiGg6usinG1WALNNLmgfFsAgCukWa+bcMtsPDRkCHeLERMJtmWEL9cuneIrMDPCMOdbAsZv/M3C6sCsuZzxOb7u/+STqVTMLYgNY4+6et6v4sXBa2MHnC70AKZsfIyDNnvYuBqtWER7owadZII4JF3/QYvwU9bCWe22cqniVj0Gh978/vli+OIjdxW/oxQLl1xyiD85R0IUoYmJIIBjcS8M8p4I1aUqunRThcxa95LGwYe4NzY9eifE8jPPpwRydwb/CjW8pidaFD3zOXy IRd9uctn ZcsZGYVDWSNS041OCNEnz/RQUsuLfXt5FplOC7w8NcLDFHeSzTEsVQHvMrNXIV9VS1zcbNyDkr719DJYLPvf2gSj507rkIIACqLL0zfl/B9ghpbukgWwjhbWVIOGPO6c14LcOHhGDzAQhv5iLYka5yBIVybvwrJ7BSEJCjI6M0QktJROW9g/TbcniNGGfzTMh/CAv X-Bogosity: Ham, tests=bogofilter, spamicity=0.022171, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Chengming, In mm/slub.c, you had defined slab_test_node_partial() to take a const parameter. Is there any point of taking in a const, when you are anyways typecasting it to a (struct folio *) from (const struct folio *) ? In fact, at the place where you call slab_test_node_partial(), the struct slab *slab is not const. Please comment. Thanks DJ