From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB649C433E0 for ; Thu, 28 Jan 2021 02:35:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 42C9F64DD0 for ; Thu, 28 Jan 2021 02:35:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42C9F64DD0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 817496B0071; Wed, 27 Jan 2021 21:35:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D1B56B0070; Wed, 27 Jan 2021 21:35:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE596B0071; Wed, 27 Jan 2021 21:35:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 577966B0005 for ; Wed, 27 Jan 2021 21:35:58 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1F1271EE6 for ; Thu, 28 Jan 2021 02:35:58 +0000 (UTC) X-FDA: 77753618796.01.car03_060c8962759c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id BA2491004EF5B for ; Thu, 28 Jan 2021 02:35:57 +0000 (UTC) X-HE-Tag: car03_060c8962759c X-Filterd-Recvd-Size: 4082 Received: from smtprelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 02:35:57 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id EC02F12F0; Thu, 28 Jan 2021 02:35:56 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: toy94_2802c232759c X-Filterd-Recvd-Size: 2922 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Thu, 28 Jan 2021 02:35:54 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] printk: dump full information of page flags in pGp From: Joe Perches To: Yafang Shao , david@redhat.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Wed, 27 Jan 2021 18:35:53 -0800 In-Reply-To: <20210128021947.22877-4-laoar.shao@gmail.com> References: <20210128021947.22877-1-laoar.shao@gmail.com> <20210128021947.22877-4-laoar.shao@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2021-01-28 at 10:19 +0800, Yafang Shao wrote: > Currently the pGp only shows the names of page flags, rather than > the full information including section, node, zone, last cpupid and > kasan tag. While it is not easy to parse these information manually > because there're so many flavors. Let's interpret them in pGp as well. [] > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -1916,6 +1916,46 @@ char *format_flags(char *buf, char *end, unsigne= d long flags, > =A0 return buf; > =A0} >=20 > +struct page_flags_layout { > + int width; > + int shift; > + int mask; > + char *name; > +}; > + > +struct page_flags_layout pfl[] =3D { static const struct page_flags_layout pfl[] =3D { > + {SECTIONS_WIDTH, SECTIONS_PGSHIFT, SECTIONS_MASK, "Section "}, > + {NODES_WIDTH, NODES_PGSHIFT, NODES_MASK, "Node "}, > + {ZONES_WIDTH, ZONES_PGSHIFT, ZONES_MASK, "Zone "}, > + {LAST_CPUPID_WIDTH, LAST_CPUPID_PGSHIFT, LAST_CPUPID_MASK, "Lastcpupi= d "}, > + {KASAN_TAG_WIDTH, KASAN_TAG_PGSHIFT, KASAN_TAG_MASK, "Kasantag "}, > +}; > + > +static > +char *format_layout(char *buf, char *end, unsigned long flags) poor name. perhaps format_page_flags > +{ > + int i; > + > + for (i =3D 0; i < sizeof(pfl) / sizeof(struct page_flags_layout) && b= uf < end; i++) { for (i =3D 0; i < ARRAY_SIZE(pfl) && buf < end; i++) { > @@ -1929,7 +1969,7 @@ char *flags_string(char *buf, char *end, void *fl= ags_ptr, > =A0 switch (fmt[1]) { > =A0 case 'p': > =A0 flags =3D *(unsigned long *)flags_ptr; > - /* Remove zone id */ > + buf =3D format_layout(buf, end, flags & ~((1UL << NR_PAGEFLAGS) - 1)= ); > =A0 flags &=3D (1UL << NR_PAGEFLAGS) - 1; Perhaps store the bitshift into a temp and use the temp twice foo =3D BIT(NR_PAGEFLAGS) - 1; buf =3D format_layout(buf, end, flags & ~foo); flags &=3D foo;