From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A9FC433B4 for ; Wed, 19 May 2021 15:42:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CC256124C for ; Wed, 19 May 2021 15:42:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CC256124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4B956B0036; Wed, 19 May 2021 11:42:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FD0B6B006E; Wed, 19 May 2021 11:42:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876596B0070; Wed, 19 May 2021 11:42:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 520086B0036 for ; Wed, 19 May 2021 11:42:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EACE38249980 for ; Wed, 19 May 2021 15:42:36 +0000 (UTC) X-FDA: 78158397912.14.55AB500 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf29.hostedemail.com (Postfix) with ESMTP id CF820408 for ; Wed, 19 May 2021 15:42:34 +0000 (UTC) Received: from mail-qv1-f69.google.com ([209.85.219.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ljOLD-0005oK-2R for linux-mm@kvack.org; Wed, 19 May 2021 15:42:35 +0000 Received: by mail-qv1-f69.google.com with SMTP id e15-20020a0caa4f0000b02901eedbb09299so9082676qvb.15 for ; Wed, 19 May 2021 08:42:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y58HNIGfyjO1NHrX6PUICkpjj0HsKsC4MLHocdrJRYk=; b=KvvANNyZwJOncTSNJo9jbZlOdB9iVtCQmaw2FenDoW2j/qXbTqhGmAjxJUOFwTJPUj R/AZZ2oS197QMKy+zwp53wdW/TfhGCM37XMZu5QGIuxbFzTy2Edzrwzn24Gk8gz+t2ZL jdP913dQZ3LecUdS+0LjUj0eoDycw/33S1X+yhjXC8SNnW7VBfyJzj0jbacckx1CySnI SiSVovj1z7RCXZNx6UqnnIcAjvaw0WKKSOpOORz3dV10C7udLul/cIUC6qR4aZmQO+8E uhIgzhPlGy/DWOlfnvsUbKVBzIxymKRaTzgNGLIB6FIpVby4iWbZXTtBVd8DZVXxWwqE NgAA== X-Gm-Message-State: AOAM531PUZB2IayU6tQXZMfUizxY2CJ9nbfjziOTB9E2jm6LQrJlOjOV 37ljqwXILljYo0nZhJB+ts5EzqRIHU7gMpQZM2WzqAqMGF3JBH20CfgNuehMzVS1zWtug/tM09g xd+h+OyLB/DURIvIc/lNVLKgSRpRE X-Received: by 2002:a05:6214:148a:: with SMTP id bn10mr54281qvb.40.1621438954266; Wed, 19 May 2021 08:42:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM3qJR3wRrIB8QCZlm0Kqj1eQyfF0OiKakSDAmRtrZDGKvkzveVMOvfO4jeZ8NFVcIbMF/dw== X-Received: by 2002:a05:6214:148a:: with SMTP id bn10mr54270qvb.40.1621438954117; Wed, 19 May 2021 08:42:34 -0700 (PDT) Received: from [192.168.1.4] ([45.237.48.3]) by smtp.gmail.com with ESMTPSA id h2sm22576qkf.106.2021.05.19.08.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 08:42:33 -0700 (PDT) Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation To: David Hildenbrand , Andrew Morton , Akinobu Mita , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Vlastimil Babka , Michal Hocko , "Rafael J . Wysocki" , Andrea Righi , Guilherme Piccoli References: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 19 May 2021 11:42:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=canonical.com (policy=none); spf=none (imf29.hostedemail.com: domain of krzysztof.kozlowski@canonical.com has no SPF policy when checking 91.189.89.112) smtp.mailfrom=krzysztof.kozlowski@canonical.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CF820408 X-Stat-Signature: 3hozwd94jgaowctt8uchnb4y4cg1mme9 X-HE-Tag: 1621438954-258854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/05/2021 11:30, David Hildenbrand wrote: > On 19.05.21 17:28, Krzysztof Kozlowski wrote: >> The documentation of DEBUG_PAGEALLOC states that it cannot be used with >> hibernation, however the Kconfig entry would allow it if >> ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC. >> >> Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix") >> Signed-off-by: Krzysztof Kozlowski >> --- >> mm/Kconfig.debug | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug >> index 1e73717802f8..0ace5b2a9d04 100644 >> --- a/mm/Kconfig.debug >> +++ b/mm/Kconfig.debug >> @@ -11,7 +11,7 @@ config PAGE_EXTENSION >> config DEBUG_PAGEALLOC >> bool "Debug page memory allocations" >> depends on DEBUG_KERNEL >> - depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC >> + depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC >> select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC >> help >> Unmap pages from the kernel linear mapping after free_pages(). >> > > I remember this should be working now, as we temporarily map the pages > in the direct map when hibernating? Let me actually test it on x86_64... Best regards, Krzysztof