From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E76C77B7C for ; Wed, 25 Jun 2025 08:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9A766B00A3; Wed, 25 Jun 2025 04:02:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4AC56B00C1; Wed, 25 Jun 2025 04:02:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D12AC6B00C2; Wed, 25 Jun 2025 04:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB4156B00A3 for ; Wed, 25 Jun 2025 04:02:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6CA915FDD2 for ; Wed, 25 Jun 2025 08:02:28 +0000 (UTC) X-FDA: 83593180776.18.2191E56 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 0F817140007 for ; Wed, 25 Jun 2025 08:02:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LNtjtFve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GYfHfzp4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LNtjtFve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GYfHfzp4; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750838546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DrvSwNdc81zvrML++2yKpFy57j7rZ8Jo3PIz7pXVsKM=; b=Iz8iXtOs/pl08AKBvjl6N0/0jhwln3QN92tDc2YqL4viyQZWGxegzmUwfEzIAgb12OOcKM 5Kv140KKZidTHYEyXPmc2rpUn28sE+D7bL5zFd0nNgXqGAiV0SiElkTpsxyFd+dTMM9eeq D2viY1XyOJwX9DxdiOnpNx4ewzZEca4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LNtjtFve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GYfHfzp4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LNtjtFve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GYfHfzp4; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750838546; a=rsa-sha256; cv=none; b=f6gWZog7Z2GNXb1a3WyoJQ7SaEneM3KTIg5FmTIMyvYNwo93xlPC4WIUhBuKEpIl66jR3T beAN3wI15LeBpk521hxS+lEi6czLDAjLq7q0Nd+l9nTFm4DEnGfOb7/rbIiSeuIsGPj5Lj KBRzkrs5QXy8tarw5g5N2tNcWEanSoo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5A89821175; Wed, 25 Jun 2025 08:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750838544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DrvSwNdc81zvrML++2yKpFy57j7rZ8Jo3PIz7pXVsKM=; b=LNtjtFve4EAX4VLkjkuECIDnRZx+AE7ok5VYfl3q2rjrMOHh2z6AEKfm+FuA1RDKvD1YRZ PoOwuxHgqbhPsXcJL+Am5Pv/hS/vSzPEgszIM1c26Hrmb7Py+5+hrn8EH+E1bOLM+Dh+ar sdq0q88BW/gZxyqvwwSKdulKEKQMtEA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750838544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DrvSwNdc81zvrML++2yKpFy57j7rZ8Jo3PIz7pXVsKM=; b=GYfHfzp43BZxq+QsvjasY0OR3usK3pRwsSiH3WlMquA5/4EhOaAxwWzV1B9ZNDVMzmtaZv 5l6CiULxfiA7xTCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750838544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DrvSwNdc81zvrML++2yKpFy57j7rZ8Jo3PIz7pXVsKM=; b=LNtjtFve4EAX4VLkjkuECIDnRZx+AE7ok5VYfl3q2rjrMOHh2z6AEKfm+FuA1RDKvD1YRZ PoOwuxHgqbhPsXcJL+Am5Pv/hS/vSzPEgszIM1c26Hrmb7Py+5+hrn8EH+E1bOLM+Dh+ar sdq0q88BW/gZxyqvwwSKdulKEKQMtEA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750838544; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DrvSwNdc81zvrML++2yKpFy57j7rZ8Jo3PIz7pXVsKM=; b=GYfHfzp43BZxq+QsvjasY0OR3usK3pRwsSiH3WlMquA5/4EhOaAxwWzV1B9ZNDVMzmtaZv 5l6CiULxfiA7xTCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 331D913301; Wed, 25 Jun 2025 08:02:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TEQiDBCtW2h2FQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 08:02:24 +0000 Message-ID: Date: Wed, 25 Jun 2025 10:02:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass To: Peter Zijlstra Cc: Christoph Hellwig , Christian Brauner , Sean Christopherson , Mike Rapoport , Shivank Garg , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, viro@zeniv.linux.org.uk, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> <20250619-ablichten-korpulent-0efe2ddd0ee6@brauner> <20250623-warmwasser-giftig-ff656fce89ad@brauner> <20250623142836.GT1613200@noisy.programming.kicks-ass.net> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250623142836.GT1613200@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0F817140007 X-Stat-Signature: tq68owzbica4o9usih8z87kqzeqbygh7 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750838545-217937 X-HE-Meta: U2FsdGVkX187JXOPEZ3rae2aYXjrTBktQirjh4DqJSp2BvRDI+Zz8xLV6m6UtJAXc1VK/g/my50sfVzvy+QUYu36SSp+VRPfwlg0IYSCZkqQTDqmXbLtOmLSTyasftHQtVrOcSubJ9y9hbJxhJ3gWofgcXs8u6c98DSn79X1P6ElSPoTRxfQ6Y4aZXFjfRA5bTtHgLOfZFLSh55x++yJR45VOk3AIH6sIcByUF0dZ/QRQZDEkM/HIWaaeYPLyH5k7t6O+RdQW7va7PruIqoGUcvimoYoXhp2LRr4aw5KdilE80l7w7xxv6PLAikMhZTMs48acXTiGT1dCkd0H7/RYyNxNrflHlB0BY6PzL/14M03FExuok50PEFM8MWSml07prYYcWYhY+nNNl2knlrg1XNcD0oERnWHyWcpktdaF1NPXtvXK5ka8WS1H62+a5E1gerLVlQjMCvzIVSjUYj+8TL1OgbWK95OP2ZNiOceks3XJDBdVQpBVyObOBa23zP/PQvWIB00DUv1Ha5Khl9aK2MCukhO+lxIboFudvl1yo/HnAFz63/8599KO2XUKSOyEwjuXiIhft8X0e+AQmm3+/fsDSzCE1BI65m0rQgN4qm2/HrMHJOptN7ieyD5nGa3+x9vojSXBb4DIHgXT+Nqb1PPrTxyH5SciMEngvSg6nXnAQ3OykCO5sJIovHGNjVjcpoXFyR4Aym0juRWLq2Yzrmr8H6Ao6wmcrf6c3snyGY/6D6IOunGPRgTuZl714ZvhHmM4RiVKc6AQ7eHt82IiXXhRgYk2eOYqBf/gBc/lb6S1lHcG7xh6pWpGmHHwUUhjUQZDJWEeGpvJz365d5CGiGKDZG+36zaLg03xY5tpdp1uQFp5C6uacs77VxX0f+Sqo8/70Jzgmkvt/Xi0MquDeBMUw3LlX9z8ix8MDcDqNjwDWbbRRnbvE63MT5ouAPuBBU/bL/aqVjDHcS1kYt AWVetKDe 3MKI+wHg2YbHoRsadX67kFkrf21q54PswjLmSFElUCyi4xtecMm9Kyix3JsBILvSeEMn/dSXVzo+jqgUG4neoE3ooWc8vYadn/zpmVgpn4Op6iAcnSPoIMGH//PcQdlVKwt7Kg7CWPNRfa2ohUvo0WlDibiE88UW/k0sj7iYIk9e+rLvuBKBA547HG3+JtG+iRep5Irt0kubXbDOYrgggscWeUdzqm6MLNYlvPCZTcuxI21mnQZy+WJNp1W4P9YN5PCGEjtn8BFIUzx12rPExNB9gdhLIRYBjBjDu0hPbqRB7YXxvnwHpdeWUtjVxZS0yj5Ifc60UZ5Oj+y4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 16:28, Peter Zijlstra wrote: > On Mon, Jun 23, 2025 at 04:21:15PM +0200, Vlastimil Babka wrote: >> On 6/23/25 16:01, Christoph Hellwig wrote: >> > On Mon, Jun 23, 2025 at 07:00:39AM -0700, Christoph Hellwig wrote: >> >> On Mon, Jun 23, 2025 at 12:16:27PM +0200, Christian Brauner wrote: >> >> > I'm more than happy to switch a bunch of our exports so that we only >> >> > allow them for specific modules. But for that we also need >> >> > EXPOR_SYMBOL_FOR_MODULES() so we can switch our non-gpl versions. >> >> >> >> Huh? Any export for a specific in-tree module (or set thereof) is >> >> by definition internals and an _GPL export if perfectly fine and >> >> expected. >> >> Peterz tells me EXPORT_SYMBOL_GPL_FOR_MODULES() is not limited to in-tree >> modules, so external module with GPL and matching name can import. >> >> But if we're targetting in-tree stuff like kvm, we don't need to provide a >> non-GPL variant I think? > > So the purpose was to limit specific symbols to known in-tree module > users (hence GPL only). > > Eg. KVM; x86 exports a fair amount of low level stuff just because KVM. > Nobody else should be touching those symbols. > > If you have a pile of symbols for !GPL / out-of-tree consumers, it > doesn't really make sense to limit the export to a named set of modules, > does it? > > So yes, nothing limits things to in-tree modules per-se. The > infrastructure only really cares about module names (and implicitly > trusts the OS to not overwrite existing kernel modules etc.). So you > could add an out-of-tree module name to the list (or have an out-of-free > module have a name that matches a glob; "kvm-vmware" would match "kvm-*" > for example). > > But that is very much beyond the intention of things. So AFAIK we have a way to recognize out of tree modules when loading, as there's a taint just for that. Then the same mechanism could perhaps just refuse loading them if they use any _FOR_MODULES() export, regardless of name? Then the _GPL_ part would become implicit and redundant and we could drop it as Christoph suggested?