From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27DFC04A95 for ; Thu, 29 Sep 2022 03:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F7978D0002; Wed, 28 Sep 2022 23:28:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A6FD8D0001; Wed, 28 Sep 2022 23:28:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F728D0002; Wed, 28 Sep 2022 23:28:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 370958D0001 for ; Wed, 28 Sep 2022 23:28:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11FA3A103A for ; Thu, 29 Sep 2022 03:28:02 +0000 (UTC) X-FDA: 79963689204.05.BDEAEBF Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf01.hostedemail.com (Postfix) with ESMTP id 7FEE24001D for ; Thu, 29 Sep 2022 03:28:00 +0000 (UTC) Received: from [10.20.42.170] (unknown [10.20.42.170]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxYOK6EDVjMZ0jAA--.2614S3; Thu, 29 Sep 2022 11:27:55 +0800 (CST) Message-ID: Date: Thu, 29 Sep 2022 11:27:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: Qi Zheng , David Hildenbrand , akpm@linux-foundation.org, muchun.song@linux.dev, =?UTF-8?B?6ZmI5Y2O5omN?= Cc: chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song References: <20220926115621.13849-1-zhengqi.arch@bytedance.com> From: maobibo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8CxYOK6EDVjMZ0jAA--.2614S3 X-Coremail-Antispam: 1UD129KBjvJXoW7uw18tr17ZF4rCry8XFy5Jwb_yoW8Zr1xpr 97G3WqqFWjqr1kCr1IqF1Dury0qw1UWa4UXryaya40qrnIqwn2grWUW3yv9w4UZr4kJa1U Jr42gr13ZFWUZw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9G14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCYjI0SjxkI62AI1cAE67vIY487MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbXdbUUUUUU== X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664422081; a=rsa-sha256; cv=none; b=6Ry9RLA1Z+mBj4S086MjK+xFB0JzksQmHk9+vSTSMvwUKtQkdBbjqhVKxPv61QCcQPkP/T aW5C1PdtJWpkguI8ze/uY2h0RdDHOGa2Mdy/HhTQeSOHe5vi/blHMmIhWaov4cEX/mvq+K Rpds3l9fxBAoJwjNXHXaOKaCZPwUOhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664422081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CcJdH25FwvIjsKkW5JUCPyp7ogQzmB4gcKbwDVzm5Qo=; b=LGB2Jf4K53VSbuXbWOcBeEkHsgPvBJ6zOAV2QiDZhNAKyKhxRA9dFHGxqZ6C92lqud+G3d 71jt9GS+1vRt6f7ciWJWasWQaMlrSprVc8Qc5KhImCtTPh2509txHHadXSQ9bUjpA3KHte wWgHVpTUrZZruV2RAsQ921pMfn9BNAQ= Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn X-Rspam-User: X-Stat-Signature: 4d3upan4qb8oczzkxzih3tjayu3kgfmy X-Rspamd-Queue-Id: 7FEE24001D X-Rspamd-Server: rspam05 X-HE-Tag: 1664422080-309875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/29 11:07, Qi Zheng 写道: > > > On 2022/9/26 22:34, David Hildenbrand wrote: >> On 26.09.22 13:56, Qi Zheng wrote: >>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>> if PTE entry exists") said, we should update local TLB only on the >>> second thread. So in the do_anonymous_page() here, we should use >>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>> >>> Signed-off-by: Qi Zheng >>> Reviewed-by: Muchun Song >>> --- >>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ >>> >>> Changelog in v1 -> v2: >>>   - change the subject and commit message (David) >>> >>>   mm/memory.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/memory.c b/mm/memory.c >>> index 118e5f023597..9e11c783ba0e 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >>>       vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, >>>               &vmf->ptl); >>>       if (!pte_none(*vmf->pte)) { >>> -        update_mmu_cache(vma, vmf->address, vmf->pte); >>> +        update_mmu_tlb(vma, vmf->address, vmf->pte); >>>           goto release; >>>       } >> >> >> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache]. >> >> So it looks good to me, but a confirmation from Bibo Mao might be good. > > Thanks, and Hi Bibo, any comments here? :) update_mmu_tlb is defined as empty on loongarch, maybe some lines should be added in file arch/loongarch/include/asm/pgtable.h like this: +#define __HAVE_ARCH_UPDATE_MMU_TLB +#define update_mmu_tlb update_mmu_cache regards bibo mao > >> >