From: Vlastimil Babka <vbabka@suse.cz>
To: Matthew Wilcox <willy@infradead.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com,
akpm@linux-foundation.org, peterz@infradead.org,
bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com,
hannes@cmpxchg.org, shakeel.butt@linux.dev, mhocko@suse.com,
tglx@linutronix.de, jannh@google.com, tj@kernel.org,
linux-mm@kvack.org, kernel-team@fb.com,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH bpf-next v6 0/6] bpf, mm: Introduce try_alloc_pages()
Date: Fri, 24 Jan 2025 15:19:47 +0100 [thread overview]
Message-ID: <e5c1eed1-3ea2-4452-a871-3308c90e932b@suse.cz> (raw)
In-Reply-To: <Z5OgvePdlqRoKMyx@casper.infradead.org>
On 1/24/25 15:16, Matthew Wilcox wrote:
> On Thu, Jan 23, 2025 at 07:56:49PM -0800, Alexei Starovoitov wrote:
>> - Considered using __GFP_COMP in try_alloc_pages to simplify
>> free_pages_nolock a bit, but then decided to make it work
>> for all types of pages, since free_pages_nolock() is used by
>> stackdepot and currently it's using non-compound order 2.
>> I felt it's best to leave it as-is and make free_pages_nolock()
>> support all pages.
>
> We're trying to eliminate non-use of __GFP_COMP. Because people don't
> use __GFP_COMP, there's a security check that we can't turn on. Would
> you reconsider this change you made?
This means changing stackdepot to use __GFP_COMP. Which would be a good
thing on its own. But if you consider if off-topic to your series, I can
look at it.
next prev parent reply other threads:[~2025-01-24 14:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 3:56 Alexei Starovoitov
2025-01-24 3:56 ` [PATCH bpf-next v6 1/6] mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation Alexei Starovoitov
2025-01-28 18:09 ` Shakeel Butt
2025-01-24 3:56 ` [PATCH bpf-next v6 2/6] mm, bpf: Introduce free_pages_nolock() Alexei Starovoitov
2025-01-28 18:18 ` Shakeel Butt
2025-01-24 3:56 ` [PATCH bpf-next v6 3/6] locking/local_lock: Introduce local_trylock_t and local_trylock_irqsave() Alexei Starovoitov
2025-01-28 17:21 ` Sebastian Andrzej Siewior
2025-01-28 18:50 ` Alexei Starovoitov
2025-01-29 8:17 ` Sebastian Andrzej Siewior
2025-01-30 20:51 ` Alexei Starovoitov
2025-02-06 11:13 ` Sebastian Andrzej Siewior
2025-01-24 3:56 ` [PATCH bpf-next v6 4/6] memcg: Use trylock to access memcg stock_lock Alexei Starovoitov
2025-01-24 3:56 ` [PATCH bpf-next v6 5/6] mm, bpf: Use memcg in try_alloc_pages() Alexei Starovoitov
2025-01-24 3:56 ` [PATCH bpf-next v6 6/6] bpf: Use try_alloc_pages() to allocate pages for bpf needs Alexei Starovoitov
2025-01-24 14:16 ` [PATCH bpf-next v6 0/6] bpf, mm: Introduce try_alloc_pages() Matthew Wilcox
2025-01-24 14:19 ` Vlastimil Babka [this message]
2025-01-24 16:19 ` Alexei Starovoitov
2025-01-24 16:28 ` Vlastimil Babka
2025-01-24 16:46 ` Alexei Starovoitov
2025-01-24 16:28 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c1eed1-3ea2-4452-a871-3308c90e932b@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andreyknvl@gmail.com \
--cc=andrii@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=elver@google.com \
--cc=hannes@cmpxchg.org \
--cc=houtao1@huawei.com \
--cc=jannh@google.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=memxor@gmail.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shakeel.butt@linux.dev \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox