From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AC4C433F5 for ; Fri, 28 Jan 2022 17:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD7676B010E; Fri, 28 Jan 2022 12:27:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B84E16B0110; Fri, 28 Jan 2022 12:27:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4D208D0002; Fri, 28 Jan 2022 12:27:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by kanga.kvack.org (Postfix) with ESMTP id 9501D6B010E for ; Fri, 28 Jan 2022 12:27:57 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5849860C9D for ; Fri, 28 Jan 2022 17:27:57 +0000 (UTC) X-FDA: 79080378594.02.5205965 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf03.hostedemail.com (Postfix) with ESMTP id DE60620015 for ; Fri, 28 Jan 2022 17:27:56 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id e79so8553585iof.13 for ; Fri, 28 Jan 2022 09:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hI+Pb4Qj4STgOuzbId2s9PWOgJpYgz54ZXJVFK6xdro=; b=LDrlVegD4OczCTpSThYZQahsywE58n2csztjLpYCX0DbQXsDPpnQjHsQ7NaVNe6s/U kZqQQCxgzePex3Wg9EhnUShaUaM/mYzddJOn9EyqW8wzZv5SImX4T8zxMjbnF1aC6fxo /tkGq0Wld2rlH7iw5TmoS/jf72nlYAj6Es4MQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hI+Pb4Qj4STgOuzbId2s9PWOgJpYgz54ZXJVFK6xdro=; b=mgvzDj/4bRqRT+8zzwJJGaphlAOjMiS4z67TiHsyPSrTbpbU6lsPVRZYAwm+RzD4uN 7UmnD2LhRBdyHAVbMh+QxS/mutg1fwdMmXL9vRfSlEAd2AWCZby8rLG43ezmqDfZlMF4 3KSPkhRXyA//rU5HbmFnJ/8Pr+a/TEw+cwKmWp75NDqHvxU6TpnepJAqLST9zWO9wUsV BNtbYkh22MY5tWw915WzJBZ89sNwBmcluN+5IMTrx3qEcEUVAsvGB43L2XFIE0NSn0W1 5y28+Gx4UPFOtmSUliIUwy4fzcESVmhjWDPn73VyxN0TsjB7sgpd41bGQzSMuSiusOjX U8HA== X-Gm-Message-State: AOAM531/96NUWboBiMYfisCZlzolQDHNbDGplj4TsYAe64Qq/4iyM0dI 2kWQA7nq4MNdmkTTcTa2d6Ym+Q== X-Google-Smtp-Source: ABdhPJwlAJwtqXZWsYjubtsCZ9BvWMOO/2eR7kskV3EhbH9JFJmtzo1ff4MXiwHTtwOHpfZvkqd52w== X-Received: by 2002:a02:95e7:: with SMTP id b94mr5287475jai.98.1643390876164; Fri, 28 Jan 2022 09:27:56 -0800 (PST) Received: from ?IPv6:2601:282:8200:4c:4e31:d3a8:3801:7e36? ([2601:282:8200:4c:4e31:d3a8:3801:7e36]) by smtp.gmail.com with ESMTPSA id k5sm3863748ilr.7.2022.01.28.09.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 09:27:55 -0800 (PST) Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail To: Alexei Starovoitov , Sean Young Cc: kernel test robot , Alexei Starovoitov , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot , Shuah Khan References: <20220128075346.GG8421@xsang-OptiPlex-9020> From: Shuah Khan Message-ID: Date: Fri, 28 Jan 2022 10:27:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DE60620015 X-Stat-Signature: d6oe31djbkp9fsrxur8xhftac36ketur Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LDrlVegD; spf=pass (imf03.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.44 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1643390876-182553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000657, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/28/22 9:49 AM, Alexei Starovoitov wrote: > On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: >> >>> ir_loopback.c: In function ‘main’: >>> ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’? >>> if (rc_proto == RC_PROTO_RCMM32 && >>> ^~~~~~~~~~~~~~~ >>> RC_PROTO_RC6_MCE >> >> So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h, >> so now the test uses /usr/include/linux/lirc.h. It appears that this file >> does not have RC_PROTO_RCMM32 defined on this system, which means it is a >> kernel header from v5.1 or earlier (this was added in commit >> 721074b03411327e7bf41555d4cc7c18f49313f7). >> >> It looks like this machine is redhat 8.3, which ships with kernel 4.18. >> >> I guess my change was far too optimistic; I had no ideal enterprise kernels >> were so ancient. >> >> We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry about >> the turbulence. > > I'd rather avoid reverting. > Just add ifdef or something to shut up the error on old distros. > Sean, Let's not add release checks. Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define just that one in ir_loopback.c with a comment that it can be removed. ifndef RC_PROTO_RCMM32 --- thanks, -- Shuah