From: Ye Liu <ye.liu@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Ye Liu <liuye@kylinos.cn>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: simplify lowmem_reserve max calculation
Date: Fri, 15 Aug 2025 09:59:04 +0800 [thread overview]
Message-ID: <e5b381aa-33a2-4537-9f71-a95f621441a7@linux.dev> (raw)
In-Reply-To: <20250814140713.GF115258@cmpxchg.org>
在 2025/8/14 22:07, Johannes Weiner 写道:
> On Thu, Aug 14, 2025 at 05:00:52PM +0800, Ye Liu wrote:
>> From: Ye Liu <liuye@kylinos.cn>
>>
>> Use max() macro to simplify the calculation of maximum lowmem_reserve
>> value in calculate_totalreserve_pages(), instead of open-coding the
>> comparison. The functionality remains identical.
>>
>> Signed-off-by: Ye Liu <liuye@kylinos.cn>
>
> You can remove the {} from the for block as well now.
I agree to delete it, but I noticed a patch has been added to the -mm
mm-new branch by Andrew Morton[1]. What should I do now? Send v2 ?
Or send a new patch? If this is my first time, please feel free to give me some advice.
[1]：https://lore.kernel.org/all/20250815004917.03FD7C4CEED@smtp.kernel.org/
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
Thanks,
Ye Liu
next prev parent reply other threads:[~2025-08-15 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:00 Ye Liu
2025-08-14 14:07 ` Johannes Weiner
2025-08-15 1:59 ` Ye Liu [this message]
2025-08-15 2:01 ` Zi Yan
2025-08-14 14:47 ` Zi Yan
2025-08-15 1:38 ` Ye Liu
2025-08-15 1:59 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b381aa-33a2-4537-9f71-a95f621441a7@linux.dev \
--to=ye.liu@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox